Bugzilla – Bug 4361
Albums with same name but different artists are wrongly grouped together if "Treat multi-disc sets as a single album" is set.
Last modified: 2009-07-31 10:14:03 UTC
I am using Slimserver 6.5.1 - 10284 - Debian - EN - iso-8859-1. Albums with same name but different Interprets are wrongly grouped together if "Treat multi-disc sets as a single album" is set. The error occours on the following scenario: I have two Albums named "Greatest Hits" but from different Interprets. The directory structure is: /test/Interpret A/Greatest Hits/ /test/Interpret B/Greatest Hits/ The files have only id3v2 Tags: TALB: Greatest Hits TPE1: Interpret A respectively Interpret B TPOS: 1/1 TIT2: title TRCK: nn/nn TYER: year Now if I set Slimserver to "Treat multi-disc sets as multiple albums" I get the following results after a "clear & rescan": Greatest Hits (Disc 1) from Interpret A Greatest Hits (Disc 1) from Interpret B But if I set Slimserver to "Treat multi-disc sets as a single album" I get: Greatest Hits from Intrepret A,Interpret B I figured out that this doesn't happen if I remove the TPOS entry from the Tags. But if you have albums with more than one cd you can't just remove the TPOS entry.
J�rg, what is an "interpret" in this case? I apologize for not understanding.
Ok, Interpret is not the right english word. I mean artist. The person who sings all the songs on the album.
Jorg, I assume since you reported this bug, that in addition to the Greatest Hits albums, you have some multi-disc sets that you want treated a certain way. :) Could you give me an example of how you have organized your multi-disc sets? Is it like: /test/Artist A/Multidisc Album (Disc 1)/tracks.mp3 /test/Artist A/Multidisc Album (Disc 2)/tracks.mp3 or /test/Artist A/Multidisc Album/Disc 1/track1.mp3 /test/Artist A/Multidisc Album/Disc 2/track2.mp3 or /test/Artist A/Multidisc Album/tracks-with-tpos1.mp3 /test/Artist A/Multidisc Album/tracks-with-tpos2.mp3 or how, exactly, you have them organized? I am trying to make sure that we fix this bug the 'right' way. Thanks for any info!
I have them organized this way: /test/Artist A/Multidisc Album/Disc 1/01 - Title - Album Name.mp3 /test/Artist A/Multidisc Album/Disc 1/02 - Title - Album Name.mp3 ... /test/Artist A/Multidisc Album/Disc 2/01 - Title - Album Name.mp3 ... But all information is also stored within the id3 tags. I'd like Slimserver to first rely on the Information stored in the id tags. I would use the Tags Compilation and TPOS to determine if it is a compilation album and if it has multiple discs. I you use only the file/folder structure, i can't imagine a way to seperate two albums with the same name from different artists.
We do pay attention to tags primarily, but if there is a problem with tag data, either real or due to a bug, Slimserver tries to 'guess' tag data using filesystem info. I'm not yet able to exactly duplicate what you are describing, so I wanted to see if arranging my music in the same directory structure would help me reproduce the bug.
I can confirm this is a bug. Simply put, Slimserver will group two different albums together when they have the same name IF the tracks from the albums are tagged with DISC X of DISC Y tags (sorry I don't know the tag frame names for this). I'm using iTunes to revise tags with MP3s. I have SS set to split multi disc sets (into Disc x of y) when using the Disc x of y tags. Discovery/Regresssion: Yesterday I identified the problem due to the following showing up... 1. Shown properly as two albums: X by INXS X by The Beloved 2. Shown incorrrectly as a single album entry: Wonderland by The Charlatans Wonderland by Erasure The difference between set #1 and set #2 was that #1 did not have Disc x of y tags. I did a sanity check by setting those tags and then unsetting them in #2. The situation reversed itself. Blanked them for both sets and everything now shows up properly. Additionally, to achieve unique listings for albums with the same name by two artists I believe requires having the ALBUM ARTIST tag set for every song on the album(s). Previously I was also getting the merged scenario before making this change to my tags. Currently the work-around of blanking the Disc x of y tags works for me. But as the original bug stated, this will likely break when one or both of the albums with the same name are multi disc sets.
*** Bug 4628 has been marked as a duplicate of this bug. ***
*** Bug 4801 has been marked as a duplicate of this bug. ***
I'm seeing this behaviour with FLAC files where the disc is commented as "DISCNUMBER"="n", with no comment for total discs. This is with SlimServer v6.5.5 r12598 on "Windows XP - EN - cp1252". For example, two folders with FLACs: \Dmitri Shostakovich - String Quartets\1.01.flac \Dmitri Shostakovich - String Quartets\... \Dmitri Shostakovich - String Quartets\6.09.flac and \Wolfgang Amadeus Mozart - String Quartets\1.01.flac \Wolfgang Amadeus Mozart - String Quartets\... \Wolfgang Amadeus Mozart - String Quartets\7.12.flac The comment used for disc is DISCNUMBER ("1" to "9" for the first album, and "1" to "12" for the second). There's no comment for total discs, e.g. TOTALDISCS, etc. Track numbers are the same (i.e. no total tracks). The album name is the same, i.e. "String Quartets". The artist name is different between the albums, i.e. "Wolfgang Amadeus Mozart" and "Dmitri Shostakovich". The groups discs pref. is enabled. The album isn't listed in the VA postcheck as having composite artists, although browse artists shows it under VA (no VA comments, just auto-detected as VA). I'll give them different album names as a short term fix (since the common album titles pref. is long gone). If there's any more info you need, please let me know.
Has anyone experiencing this bug tried 7.0 yet? Does it have the same issue? Note to self: get Steven/Wallace to make an automated test case for this problem.
*** Bug 5161 has been marked as a duplicate of this bug. ***
I did some testing today with this version: SqueezeCenter-Version: 7.0 - 13685 - Debian - DE - utf8 There seem to be some improvements over the last weeks, but the main issue ist still unresolved. When "Group Discs" is activated it still mixes together Albums from different artists. :(
Steven do we have a small set of sample tracks that illustrates this issue?
cc'ing Michael Herger, who will probably get the bug assigned to him.
*** Bug 5725 has been marked as a duplicate of this bug. ***
While investigating duplicate bug 5725, just having a DISC tag present in the file will change the behavior of the compilation auto detection. SC seems to ignore folder structure all together when determining compilation status if a DISC tag is present.
*** Bug 4644 has been marked as a duplicate of this bug. ***
*** Bug 4879 has been marked as a duplicate of this bug. ***
Changing to unassigned for review.
Andy: can you take a look at this?
If I understand this issue correctly, I think the fundamental problem comes down to: how do you determine if the following 2 files are part of the same album or not? /TrackArtist A/Greatest Hits/track1.mp3 /TrackArtist B/Greatest Hits/track2.mp3 Should we maybe check Album Artist, and only group them if Album Artist matches across all tracks with the same album title? It doesn't look like iTunes sets an Album Artist tag when you import an album like this though, but does set the Composer tag... Maybe it should only group them if Album Artist *or* Composer (or Band, or Conductor?) match? I'm sure it's not this simple, what am I missing? This would still break if you had 2 albums with Album Artist: Various Artists and Title: Greatest Hits, but I think it's impossible to solve that situation, and it seems unlikely such a generic album exists anyway.
It a long time since I last looked at this, but AFAIR it all works fine when multi-disc sets is not set, so it's only the case where you're also reading the disc number that causes this. If an album isn't a VA album, surely you just need to check trackartist and albumname and if they're the same it has to be the same album? If it's a VA album, then it has to be marked as such, and you can then only check against other VA marked tracks with the same albumname. If you have more than one VA marked album with the same albumname, then there isn't much you can do to distinguish them.
Not going to be fixed for 7.0.
*** Bug 6604 has been marked as a duplicate of this bug. ***
*** Bug 7712 has been marked as a duplicate of this bug. ***
In 7.0.1 change 18347 I have fixed this bug for the single-disc album case, such as: X by INXS X by The Beloved Wonderland by The Charlatans Wonderland by Erasure The fix was to simply ignore the disc tags if they were "1 of 1". Still need to work on fixing it for multi-disc albums.
*** Bug 7544 has been marked as a duplicate of this bug. ***
Checked in another fix as 7.0.1 change 18385. I believe this bug is now fixed for all cases. I specifically tested: Single Artist ------------- 2 single albums with same title 1 single album + 1 multi-disc album with same title 2 multi-disc albums with same title Various Artists --------------- 2 single albums with same title 1 single album + 1 multi-disc album with same title 2 multi-disc albums with same title (no compilation bit set) 2 multi-disc albums with same title (compilation bit set) All appeared to be handled properly.
Created attachment 3312 [details] Sample files
Still seeing this bug on 19177. Attaching some sample files to reproduce. Extremely annoying since this specific case will add 10-20 entries per item! I just found out that I, too, DO have separate artwork files in each subfolder (this is how iArt creates 'em). The zip file level is the top "folder" level, so I usually place them in an "artist" subdirectory called "economist".
The problem there is that you have the same 'album' stored in multiple directories. I wonder if we need a pref that says "Allow a single album to exist in multiple directories?" or something?
Find it hard to imagine cases where I do NOT want them grouped together. Would solve another issue, btw: I do have some folders with random collections of tracks (typically playlists with content I copied from elsewhere). The tracks in these folders, if tagged correctly, will show up as separate albums (if I also have the full album) instead of within the album. While I like this on iTunes because this way I can identify and remove duplicates I don't think it makes much sense in SC since I cannot delete tracks from here.
Are any of the other users on this bug still having problems or are Andy's fixes good for at least some people?
Where are the fixes at? I'm still having both issues: Different "Best of" Albums (and others) with different artists wrongly grouped together while my Economist Audio Edition lists as 25 entries albeit all of them have identical artist and album. So nothing looks fixed so far. I tried 7.0.1 on OSX and 7.2 on Ubuntu (debian)
Oh and I still have the duplicate anchors under "various artists" in the album view
Assigning to Steven to figure out what the desired behavior is. Maybe Andy fixed the problem for some of these people? Does a new bug need to be opened? Test with 7.1 please.
Joerg: Please see bug 8214, I think this is your issue now.
Don't understand? Why do you have two bugs for the same issue now? What am I supposed to do?
The remaining issue is covered in bug 8214
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC