Bug 9057 - Preview Alarm Sounds - IP3K players
: Preview Alarm Sounds - IP3K players
Status: RESOLVED PATCHWELCOME
Product: Logitech Media Server
Classification: Unclassified
Component: Alarm
: unspecified
: PC All
: -- normal with 12 votes (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-06 09:52 UTC by James Richardson
Modified: 2010-06-08 13:18 UTC (History)
8 users (show)

See Also:
Category: Feature


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2008-08-06 09:52:23 UTC
When setting an alarm on the boom, there is no way to Preview what the sound is like from the player UI in the alarm menu.

Please add a "play" option when an alarm sound it viewed.  Simply pressing the play button on the front panel / IR remote is acceptable.
Comment 1 KDF 2008-08-06 10:47:42 UTC
note: there isn't currently any framework for "preview" of tracks/sounds.  Having a "play" option would effectively mean replacing the current playlist with the potential alarm sound.


A more complicated process would be to use something like the announcement idea:
insert the track-to-be-previewed as the next song on the queue.
mark the current playback position if player is playing.
jump to preview track for...say 30s
jump back to previous track and goto previous position (start of song for transcoded songs)
remove preview track.

Potential Problems: interrupting currently playing remote tracks. surprised users who forget they have synced players when they preview barnyard sounds.

Currently the sound selection uses INPUT.Choice.  This means you have actions on Play, Add and Right.  Given that they are currently not treated as audio, all 3 select the sound.  Simple case may be to have onPlay and onAdd do the usual thing for audio tracks, and only have onRight do the selection.  In that case, the UI needs some thinking in order to reflect that (typically playable files have a note icon, while selectable items have the radio button or checkbox).

Comment 2 Blackketter Dean 2008-08-06 11:02:46 UTC
Alan: Does new_streaming make it easier to pause, play something else, then resume audio?
Comment 3 Alan Young 2008-08-12 12:59:20 UTC
No, not really. Maybe a little - the hooks you would need are more accessible. It would be nice though - you could do whole-house audio announcements ("dinner time"). 
Comment 4 James Richardson 2009-03-25 07:57:07 UTC
*** Bug 11462 has been marked as a duplicate of this bug. ***
Comment 5 James Richardson 2009-09-25 15:32:29 UTC
*** Bug 14293 has been marked as a duplicate of this bug. ***
Comment 6 James Richardson 2009-10-12 07:55:27 UTC
*** Bug 14704 has been marked as a duplicate of this bug. ***
Comment 7 Stefan Hansel 2009-10-12 11:35:54 UTC
this problem also exists on the radio and to have so many sounds is pretty useless without beeing able to prelisten to them.
Comment 8 Jim McAtee 2009-10-17 12:32:40 UTC
I'd like to suggest that this be given a much higher priority due to the release of the Squeezebox Radio, which is also being positioned as an alarm clock replacement.  Lack of alarm sounds preview has been brought up several times in the forums already and is even being mentioned as a downside in online reviews of the new product.

What about using the mixer to play the preview?  Then the current playlist needn't be wiped.  Mute whatever is playing (if something is playing), play the alarm sample, then unmute.
Comment 9 James Richardson 2009-10-17 12:46:25 UTC
The more votes, the higher the priority :)
Comment 10 Stefan Hansel 2009-10-17 13:13:25 UTC
Currently I consider the alarm-clock sounds as a non-existent 'feature'.

Selecting one, adjusting the alarm-time, waiting at least 1min to have the alarm go on just to hear one single sound is just a plain stupid thing to do.

Currently you need about 10 minutes, just to prelisten 5 short sounds !
Comment 11 James Richardson 2009-10-22 11:38:31 UTC
re-assigning Seth's bugs to Matt
Comment 12 Chris Owens 2010-02-02 15:08:29 UTC
Matt Weldon doesn't work for us any more.
Comment 13 Mickey Gee 2010-03-18 14:23:47 UTC
Brought up during Fab4 CX review.

Retargeting to engender discussion for next release.
Comment 14 KDF 2010-04-14 11:58:25 UTC
*** Bug 16017 has been marked as a duplicate of this bug. ***
Comment 15 Alan Young 2010-04-15 00:48:53 UTC
See bug 15321 for SP equivalent bug.
Comment 16 Alan Young 2010-04-15 08:48:29 UTC
I mean bug 15231
Comment 17 Ben Klaas 2010-04-21 09:42:18 UTC
This bug was originally brought up for Boom, but I'm hijacking it for the purposes of fixing it for Squeezeplay UI purposes. 

Alarm Preview on Squeezeplay players will be the scope of this bug for 7.5.1. I'm fine with it staying open past 7.5.1 for ip3K players (or webUI), but that's out of scope for what I'm going to be working on.

Bug 15231 is not the equivalent SP bug. That bug deals with alarm *volume* preview, not alarm tone preview.

I should also note: in the current SP UI implementation I'm working on, KDFs comment#1 still applies. A preview option will replace the current playlist with the potential alarm sound. I have some thoughts on possible ways to get past this limitation, but again this may be beyond the scope of what can be delivered for our next point release.
Comment 18 SVN Bot 2010-04-21 09:44:24 UTC
 == Auto-comment from SVN commit #30676 to the slim repo by bklaas ==
 == http://svn.slimdevices.com/slim?view=revision&revision=30676 ==

Bug: 9057
Description: add a 'preview' action callback to sounds in SP alarms. Note that this checkin is 100% inert until the SP-side is completed.
Comment 19 SVN Bot 2010-04-21 14:44:08 UTC
 == Auto-comment from SVN commit #8721 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8721 ==

Bug: 9057
Description: add ability to preview alarm sounds through a new 'preview' action from the server
alarm preview is done through either pressing play or + (or on the touch interface, through touch-hold) 
window pops up while the alarm sound is previewed. when the window is exited, the player is paused

current limitations of implementation:
1. very difficult to discover the means of previewing. there is currently no mechanism for sending help text from the server in a slimbrowse menu such as this to message the user.
2. previewing an alarm sound wipes the current playlist and replaces it with the alarm sound.
Comment 20 Mickey Gee 2010-04-22 12:06:08 UTC
I showed Matt Weldon what had been done so far. He said there were two ways of doing it. Although he said he was going to update this bug himself, Matt seems to be super busy. Before I forget what he said, I wanted to enter them in now and perhaps Matt can correct me later:

1. Make more discoverable by
  - Putting a hint like "Press and hold sound to preview" in the screen title, E.g., right under "Musical Sounds".
  - Once the user presses and holds, a new window would not appear. Instead the sound would preview for a fixed amount of time, like 30 seconds. You would not be able to shorten it, and no button to stop the preview is needed.
  - To indicate the sound is playing, the selection circle at the far right would turn into a spinny while it's playing.

2. Add choice to preview sound into a context menu. This would require a restructuring of alarm menus to make it fit into the flow of setting alarms. However, this would be consistent with a larger framework of items discoverable by context menus on many other screens.
Comment 21 SVN Bot 2010-04-22 13:03:14 UTC
 == Auto-comment from SVN commit #8724 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8724 ==

Bug: 9057
Description: add 'go' to the list of actions not ignored by the window
Comment 22 Stefan Hansel 2010-04-22 13:17:36 UTC
>> Add choice to preview sound into a context menu. [...]
>> However, this would be consistent with a larger framework 
>> of items discoverable by context menus on many other screens.

Screensavers are previewed by pressing the 'play'-button on the respective screensafer. Doing the same to preview/play an alarm-sound I'd consider consistent and intuitive.
Comment 23 Ben Klaas 2010-04-22 13:24:27 UTC
Weldon, very much appreciated on the input, and Mickey thanks for the legwork on that.

Choice #2 may be the best option, as it is a consistent UI model with e.g. browsing tracks in a library.

The problem with putting a hint that says "Press and hold sound to preview" is that this hint is coming from the server, and the text that's delivered would need to be platform-specific (e.g., on Touch it's press and hold, but on Radio it's the + button). In addition, we'd need to engineer in the ability to display a slimbrowse menu that includes both menu header text and a menu of non-standard (in this case, radio button) items. There is no support for that right now, and IMO adding it would not be particularly straightforward.

The second and third points in choice #1 are valid suggestions but dosn't actually address the discoverability issue, just the behavior of the preview. I'll noodle on them though, they are good thoughts as far as the UI goes.

Stefan, unfortunately SB Touch throws a wrench in things because there is no differentiation between a "play" action and a "go" action. On SB Touch, both play and go are invoked by touching the item. There needs to be a way to select the item as your configured alarm sound (the radio button) as well as playing it.
Comment 24 Stefan Hansel 2010-04-22 14:18:20 UTC
I'm happily take a Touch as present to try out myself :D

How do you do it for Screensafers on the Touch then ?
On Radio and Controller the 'Go'-Function is used to select a screensafer and 'Play' to preview it. 
If there is no dedicated 'Play' on the Touch ... um ... can't you preview screensafers on the Touch then ?

Anyway - if you do anything fancy with the + button for alarm-sounds, remember to adjust screensafer previews accordingly.
Comment 25 Ben Klaas 2010-04-22 14:28:48 UTC
Press-hold on Touch (same action as + button) is for previewing screensavers. Unfortunately this does not work as well as it should and is an open bug, bug 11096.
Comment 26 Ben Klaas 2010-04-22 14:56:31 UTC
Thinking about this a little further, I think that going with a context menu approach for the + button may be fine from a UI design perspective, but it also does nothing to enhance the discoverability of the feature. Either the current model or the context menu model require a user to hit the plus key or touch-hold to access (note: play button also works for preview in the current model)

So...if the task at hand is to let the user better know that sounds can be previewed, the only way to do effectively do this is through something visible on the UI.
Comment 27 SVN Bot 2010-04-23 11:14:23 UTC
 == Auto-comment from SVN commit #8728 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8728 ==

Bug: 9057
Description: pull the preview action listener into a separate clause from the _jive_button logic
Comment 28 SVN Bot 2010-04-28 15:10:51 UTC
 == Auto-comment from SVN commit #8745 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8745 ==

Bug: 9057
Description: call player:stopPreview() when alarm preview window is exited. Requires up-to-date 7.5.1 SBS for this to function properly.

unrelated to 9057:
allow a showBriefly to bring up a persistent window when duration is -1 
debug message for choose player window debugging
Comment 29 SVN Bot 2010-04-28 15:13:01 UTC
 == Auto-comment from SVN commit #30707 to the slim repo by bklaas ==
 == http://svn.slimdevices.com/slim?view=revision&revision=30707 ==

Bug: 9057
Description:
add 'playlist preview' cli command to support alarm sound preview and retrieval of last previous playlist before preview.
extend 'playlist resume' to include tagged params of noplay:1 and wipePlaylist:1. Used for not auto-starting after resume and to wipe a temporarily cached playlist, respectively.
document cli changes
Comment 30 SVN Bot 2010-04-28 20:30:05 UTC
 == Auto-comment from SVN commit #30708 to the slim repo by bklaas ==
 == http://svn.slimdevices.com/slim?view=revision&revision=30708 ==

Bug: 9057
Description: send a textareaToken in the window for Alarm Sounds
Comment 31 SVN Bot 2010-04-28 20:32:41 UTC
 == Auto-comment from SVN commit #8746 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8746 ==

Bug: 9057
Description: support for a textareaToken on a slimbrowse menu which can deliver platform-specific help for a window
note that using help to present menu header widgets like this can not coexist with decorated menu items like radio buttons or checkboxes
Comment 32 SVN Bot 2010-04-29 10:21:48 UTC
 == Auto-comment from SVN commit #8749 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8749 ==

Bug: 9057
Description: handle the alarm preview window correctly for the slimbrowse window step stack. this fixed a UI problem when backing out of windows after calling an alarm preview. I believe this is the final checkin for alarm preview support for Squeezeplay-based players.
Comment 33 Ben Klaas 2010-04-29 10:38:14 UTC
I believe this bug to be fixed for Squeezeplay-based players, which was the 7.5.1 target requirement. Rather than close this, I'm going to leave it open, untarget it, and change the summary to reflect that this is now only open for ip3k players.

FWIW, it could be that some of the 'alarm preview' cli work that was done server-side could be leveraged for ip3k player support. However, this will not be my task to fix.
Comment 34 Mickey Gee 2010-05-19 10:41:32 UTC
*** Bug 14293 has been marked as a duplicate of this bug. ***
Comment 35 Chris Owens 2010-06-08 13:18:41 UTC
Changed bug summary to reflect current status.