Bugzilla – Bug 6386
Extras should be able to have icons
Last modified: 2009-09-08 09:30:10 UTC
Content providing applets/services should all be able to have icons in the UI. Internet Radio and Music Services do now, but Extras should probably also have them too. Attached is a propose icon for the Info Browser, our only extra at this point on jive.
Created attachment 2534 [details] Infobrowser icon
CC'ing Michael as the web UI should also have icons for extras. Also uploading a SoftSqueeze icon for him. :)
Created attachment 2535 [details] softsqueeze icon
I don't have a Jive, but this makes me wonder whether the web ui should have icons for the other items too. I'm sure someone could come up with icons for everything under Music Library. Maybe items under Favorites could have a default icon with the ability for the user to select an alternate. I can open a new bug for this if you want...
Fletch: That's a good idea, feel free to open an enhancement/bug. Also, let's open a new thread in the forum...
Ben - would this take much more than moving the icon-id handling from OPMLBased.pm to Slim::Plugin::Base?
Should this be broken out into two bugs? Some extras on Jive will not have a server component. Not sure if Info Browser would get its icon from the server or the local fs.
You're right. Probably just a <pageIcon> attribute in install.xml? This could be used for SC plugins as well as for Jive.
Created attachment 2536 [details] control icon using install.xml That's a quick change to allow adding plugin icons through a install.xml directive. I added the InfoBrowser icon Dean uploaded.
(In reply to comment #4) > I don't have a Jive, but this makes me wonder whether the web ui should have > icons for the other items too. I'm sure someone could come up with icons for > everything under Music Library. Maybe items under Favorites could have a > default icon with the ability for the user to select an alternate. I can open > a new bug for this if you want... > Enhancement request filed as bug 6390.
Dean, Ben - Any thoughts about this patch?
change 15533 - I checked the above patch in. Please test.
CC'ing noah, in case he wants to change the attached SoftSqueeze and InfoBrowser icons.
I'm calling this an enhancement not a bug... per agreement last week, enhancements are marked as Target Milestone "future"
Ben - I thought this was resolved, only needing some testing. Plugins can easily have icons by defining <icon>/some/path/to/the/icon.png</icon> to the config.xml file.
Michael: do the icons you describe work on Jive? (This is a Jive bug.)
Sure. It's the same http code, only the way the images are announced to the server has changed. The path to the file has moved from the code to the .xml file, allowing to add icons for Jive only plugins, which don't add any SC code.
The issue is that the extras menu is not rendered in a style that includes icons. We can revisit this in the future, but at this point we are moving enhancements off the 7.0 target list.
Created attachment 2664 [details] Example of an item that needs the > graphic, not the play icon.
Created attachment 2665 [details] Correct usage of play icon
Just noticed this must be the only Jive bug assigned to me, but not targetted... Isn't this done? Plugins can have icons. What else needs to be done?
Dean - can this bug be closed?
Created attachment 2753 [details] Info Browser Artwork
Want to discuss this. The icons should be consistent between the SBC and web UI.
If you plan to revisit this bug, you might want to have a look at how we solved this for iPeng, which is probably a bit more flexible than the cuurent custom button scheme for the web UI Thre's some documentation in this thread: http://forums.slimdevices.com/showthread.php?t=42986&page=3 And a doc here: http://penguinlovesmusic.de/?page_id=180
Forget my last replay on this, mis-read the request
punting to 7.3
this isn't going to be fixed by 7.3. retarget for 7.3.1
Changing target to next release
with only these exceptions, my bug list is being retargetted for 8.0 for 7.3.2 (very soon): https://bugs-archive.lyrion.org/show_bug.cgi?id=7186 Browse albums/artists/genres/ years should remember previous state for 7.3.3 (later, but before 8.0): https://bugs-archive.lyrion.org/show_bug.cgi?id=7139 Add editable "Network Settings" page https://bugs-archive.lyrion.org/show_bug.cgi?id=7502 Add setup mode to set Static IPs (even if DHCP is present) https://bugs-archive.lyrion.org/show_bug.cgi?id=7829 Jive menu broken if BLOCK_SIZE == list count + 1 and "Pla... https://bugs-archive.lyrion.org/show_bug.cgi?id=8878 Party Mode https://bugs-archive.lyrion.org/show_bug.cgi?id=10064 SqueezeCenter doesn't always auto-generate playerstatus w... (which will fix 8300) https://bugs-archive.lyrion.org/show_bug.cgi?id=6334 add applet for network diagnostics (currently assigned to Tom)
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code. Feel free to move it back if it's specific to the single original product.
Reset priority before triage.
there is no extras with the home menu redesign