Bug 7186 - Browse albums/artists/genres/years should remember previous state
: Browse albums/artists/genres/years should remember previous state
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: All All
: P1 major with 11 votes (vote)
: 7.3.2
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-16 02:15 UTC by Max Spicer
Modified: 2009-09-08 09:29 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-02-16 02:15:44 UTC
If I've previously browsed into Music Library->Albums->An Album then next time I go into Music->Library->Albums, An Album should be initially selected.  Ditto for artists and years.  The Squeezebox gets this right but not the controller.
Comment 1 Blackketter Dean 2008-02-16 11:14:50 UTC
Will consider post 7.0.
Comment 2 Peter 2008-02-22 06:49:51 UTC
Shouldnt this also apply to browsing the music folder?
Comment 3 Simon Turner 2008-03-11 14:37:34 UTC
7.1? Not 7.01?
I'm surprised as I am vexed by the lack of this function almost every time I use the Controller.
Comment 4 Max Spicer 2008-03-11 14:38:59 UTC
7.0.1 will be a bug fix release not a feature release.  Please try to avoid comment spam.
Comment 5 Chris Owens 2008-04-16 09:28:52 UTC
*** Bug 7839 has been marked as a duplicate of this bug. ***
Comment 6 Ben Klaas 2008-06-19 10:50:54 UTC
*** Bug 8309 has been marked as a duplicate of this bug. ***
Comment 7 Ben Klaas 2008-07-01 09:12:49 UTC
this is not making it into 7.1

An added note on this bug: this is a very important bug to fix, and it's getting plenty of votes as well. The reason for punting this to 7.2 is not because of the bug's priority (high), but rather because of the non-trivial nature of the fix and the current timetable.
Comment 8 Ben Klaas 2008-07-25 07:01:44 UTC
punting to 7.3
Comment 9 Phil Turnbull 2008-07-25 15:53:16 UTC
(In reply to comment #8)
> punting to 7.3
> 

Seriously?  Isn't this a major issue?
Comment 10 Ben Klaas 2008-11-02 12:17:49 UTC
Yes, this is a major issue, but one without an obvious solution. 

Retargetting for 7.3.1. My intention is to make this one priority 1 for 7.3.1.

cc:ing Tom, whom I'll be soliciting help with scoping this one out.
Comment 11 Markus Schiegl 2008-11-29 14:55:03 UTC
*** Bug 10170 has been marked as a duplicate of this bug. ***
Comment 12 Ben Klaas 2008-12-10 10:08:37 UTC
The good news is this long-standing ugly bug has been fixed.

The bad news is that it's too close to 7.3 release to checkin for 7.3.

Fix checked into 7.4 trunk branch, r3484. I will try to pull the fix into the first available beta firmware after 7.3 is released.

the gory technical details, for those interested:

any "SlimBrowse" menu (browse menus driven solely by data from SqueezeCenter/SqueezeNetwork, e.g. everything underneath Music Library) is generated via a CLI command callback. By storing the last browse index for a specific CLI command callback, it is possible to jump directly to that index when re-entering a given browse menu. 

code change details here:
http://svn.slimdevices.com/7.4/trunk/squeezeplay/src/squeezeplay/share/applets/SlimBrowser/SlimBrowserApplet.lua?root=Jive&r1=3484&r2=3483&pathrev=3484

Further, the code to decide which chunk of the list to get next was rewritten to allow the first chunk loaded to include the previously selected index (or, in the case of no browse history, it will start with the first chunk), and then request the most logical next chunks until the list is complete.

code change details here: 
http://svn.slimdevices.com/7.4/trunk/squeezeplay/src/squeezeplay/share/applets/SlimBrowser/DB.lua?root=Jive&r1=3484&r2=3483&pathrev=3484

Comment 13 James Richardson 2008-12-18 14:50:35 UTC
Moving to next release, not going to make it for 7.3.1
Comment 14 Ben Klaas 2009-01-05 14:37:40 UTC
r3679 brings the changes I put into 7.4/trunk back to 7.3/trunk, which will push the fix into the 7.3.2, which is the next bugfix release.

QA- put this one through rigorous paces before certifying 7.3.2.
Comment 15 James Richardson 2009-01-22 09:57:54 UTC
Fixed - Closed Message (SC)

This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 16 James Richardson 2009-01-22 13:53:17 UTC
Correction: SqueezeCenter version is 7.3.2