Bugzilla – Bug 6390
Add web GUI main menu icons for favorites
Last modified: 2009-09-08 09:15:08 UTC
Now that some of the Extras have icons on the SC Web GUI, items in the main menu without icons seem noticeable absent. This enhancement request is to add the following (in approximate priority order): - Add icons for all items under Extras (part of bug 6386) - Add icons to all items under Music Library (Artists, Albums, etc) - Add icons for items under Favorites (have a default icon with the ability for the user to change the icon for each entry) - Add the ability to display the top-of-gui icons even for non-xmlbrowser plugins (as I understand it, the fix for bug 6279 only applies to xmlbrowser) - Add icons to the top level menu items (Music Library, Internet Radio, etc) (Not sure about this one...) I'm not sure if/how this request applies to Jive...
All we need is the artwork. The rest could easily be done. Dean - should we "order" some work from Scott or Noah?
Noah: I think that we should be trying to have icons for all the major areas in the SC web UI (as well as Jive). How should we work toward getting these made? Should Scott be doing this?
Dean- As a first step, it would be helpful to map out each area where we need icons. This could be as involved as the GPS aor simply a running list on the Projects-To Do posting. From there, we could have a better sense of how many icons we are talking about as well as a way to keep track of the output. Based on the number of icons we could then distribute/create the work more efficiently between Scott and myself.
See the attached image for where we're missing icons: Artists Albums Genres Years New Music Random Mix Music Folder Playlists Search Music Information Browser Softsqueeze Let's use this bug as a way to track this issue and make sure we've got coverage.
Created attachment 2551 [details] Screenshot illustrating the missing icons
(In reply to comment #4) > See the attached image for where we're missing icons: > Artists > Albums > Genres > Years > New Music > Random Mix > Music Folder > Playlists > Search Music > Information Browser > Softsqueeze > > Let's use this bug as a way to track this issue and make sure we've got > coverage. > Don't forget that OPML Playlist Browser & Editor will also show up under Extras when enabled. I also still think it would be nice to see something for the user added Favorite items...
What would you like to see for the favorites? User defined icons per station/playlist/whatever?
For the favorites, the icon should match the item that is the favorite. If it's a pandora station, use the pandora icon, if it's a song or album, use that the appropriate cover art (or placeholder if none is available), etc. If it's an artist, use the artist placeholder that Noah is creating.
(In reply to comment #8) > For the favorites, the icon should match the item that is the favorite. > > If it's a pandora station, use the pandora icon, if it's a song or album, use > that the appropriate cover art (or placeholder if none is available), etc. If > it's an artist, use the artist placeholder that Noah is creating. > I was just thinking exactly the same thing. Forget my suggestion that it should be user selectable.
Created attachment 2580 [details] Info Browser Artwork Proposal
Created attachment 2581 [details] "Nature Sounds" Artwork Proposal
Great! Let's get those in there and see how they look.
Created attachment 2582 [details] small icons (50x50) change 15711 - here you go
Created attachment 2624 [details] Music Library Artwork Attached are the missing icons for SqCenter's Music Libary. The artwork has been formatted similar to the service provider icons.
Created attachment 2625 [details] Music Library Artwork-example icon
Created attachment 2626 [details] Service Provider Artwork-revised set of icons
change 16432 - adding the music library icons Noah, the "New Music" icon imho is too detailed to be recognizable in the web interface (25x25px). I'm not sure we can do reasonable Favorites icons. Would need some major rework of the favorites handling. Will "downgrade" this bug to an enhancement request for the future.
Also need a MusicIP Moods icon, and probably a generic icon for each section (Browse, Extras at least) for other items wen they don't have icons. In fact, even just a generic icon of some type could be added through plugin manager if the plugins don't create one of their own.
Should the moods show up like playlists? I've never seen them.
Created attachment 2750 [details] New Music Artwork-SC revision Attach is the updated Music Library "New Music," icon for SqueezeCenter
Michael: moods currently get added as a browse menu item when found. They are a custom url/api so would need a protocol handler to relocate them to playlist/favourites.
Thanks Kevin. Meanwhile I have found them (created them using OSX X11 server to connect to my headless box...).
change 16853 - updated New Music artwork
Created attachment 2755 [details] Service Provider Artwork-revised set 7.0.1 release Most recent set of SC icons as of 01/28/08.
change 16882 - adding MusicIP Moods icon
change 17050 - adding a generic plugin icon for the web UI's Extras menu
(In reply to comment #7) > What would you like to see for the favorites? User defined icons per > station/playlist/whatever? It seems user defined icons are desired for favorites, but that entails a rework. As a temporary measure, how about providing icons to distinguish between folders and playable items? As it stands now, you can' tell the difference until you mouseover the items and view the controls. When user defined icons are implemented, these icons could then be used for the generic defaults. For playable items you might also distinguish between local files vs. radio or service items, but that's not as important.
That's what you filed bug 6008 for, isn't it?
*** Bug 6008 has been marked as a duplicate of this bug. ***
Thanks. Didn't realize it was already a part of this discussion. Favorites are now the only top-level item without icons in the Default skin.
I didn't mean it was already part of this bug, I only meant it was already mentioned elsewhere... Dean - do we want the favorites icons to be done for 7.0?
Yes, we want icons for favorites, but I think it's too late for 7.0, unless that information is already available. Can we pull an icon for the item based on its URL?
Yes, we do know whether a favorite is playable (entry.audio) or a folder (entry.outline). Based on these values we could use different icons.
Michael: do you feel comfortable adding this to the web UI for 7.0?
If we had the artwork, I'd be positive yes. But we don't have them.
What artwork is missing and to populate the Favorites? For songs and albums we have the cover art or placeholders; for radio stations, we have the generic radio icon; we have a folder icon for folders, logos for services (pandora stations, etc...) What's missing?
We were talking about favorite or folder, not about album, radio, year etc. We don't have that information available in the data. This would nees some additional work (and lucky guessing).
Ok, I think we're misunderstanding each other. I'm proposing that the items in Favorites have icons corresponding to their content. Examples: A favorite that's a song or album will have the artwork for that album. A favorite that corresponds to a genre, year, playlist, artist, playlist, A favorite that corresponds to a playlist would use the generic playlist icon we have. Pandora stations would use the Pandora icon, Rhapsody the same, etc... Plain radio stations would use the placeholder radio icon. Folders could use the musicfolder.png icon for now. A year would use the generic years icon we have. I'm guessing that this is too hard for 7.0. We'll get to it soon.
not a 7.0 bug - punting to 7.1
change 19195 - basic support for per favorite icons, currently service/station or generic icons are used on the web interface, but stored with the favorite. TBD: Jive/fav web interface, make icon configurable(?), use album art instead of generic art where possible
change 19198 - album art is used as favourite icon for albums/tracks
this actually was change 19199
Michael, this looks really cool and works great for anything in my music library. Reopening because I get the generic heart logo instead of the partner icon (for example when setting a Slacker station as a favorite). Actually, I'm not clear from your comments whether this should work or not. Also, SC support was recently added for individual station logos for RadioTime stations. It would be cool if the favorite logo used the station logo rather than the partner logo in this case. Let me know if you want me to open a separate bug for this.
> icon (for example when setting a Slacker station as a favorite). Actually, I'm > not clear from your comments whether this should work or not. Is it only Slacker? Might be I missed it because I can't test it. But I've successfully tested Pandora/Rhapsody/LMA/Shoutcast. They will not always work, but only as long as the special protocol handler URL is used as a favorite (eg. pandora://). Once it's just a standard http:// url there's not much we can do. > Also, SC support was recently added for individual station logos for RadioTime > stations. It would be cool if the favorite logo used the station logo rather > than the partner logo in this case. Let me know if you want me to open a > separate bug for this. I expected this bug not to stay closed for long :-P
I only tested with RadioTime, Rhapsody (a station only) and Slacker. In all 3 cases, the favorite icon on both SC and the SBC show up as the heart icon. I added the favorites via SC and they are created in the opml file as follows: <outline URL="http://opml.radiotime.com/StationPlaylist.axd?stationId=34804&Formats=mp3,wma,real&username=fletch" icon="html/images/favorites.png" text="KQED-FM (San Francisco, CA)" type="audio" /> <outline URL="slacker://stations/3302803/183.mp3" icon="html/images/favorites.png" text="Classic Rock" type="audio" /> <outline URL="rhapd://ps.8647980.rdr" icon="html/images/favorites.png" text="'70s Hits" type="audio" /> This is with today's 7.2. Let me know if I can provide more details. > I expected this bug not to stay closed for long :-P :-)
change 19262 - add favorite icons when adding favorites using player/CLI/Controller interface, too - add station icon for services which offer them
Created attachment 3310 [details] Favorite icons from various sources
I did some more testing and in all cases the favorite picks up the icon that I would expect (and as described by Dean in comment 38). IMO, it looks very cool, especially on the SBC. A couple minor comments/issues: - One of my RadioTime stations (KPCC) is missing the icon on the RadioTime site. When browsing RadioTime on SC, the icon is just missing, but when used as a favorite it adds additional text that overlaps. Works fine on the SBC. - On SC, when I click on a favorite (rather than play or add) and go to the "detail" screen, the large icon is displayed as the generic musical note or radio tower icon, not the custom icon. Works fine on the SBC. - What will happen when users upgrade from 7.0 to 7.1? Will they have to manually remove and re-add all their favorites, or should there be some kind of auto-migration of their favorites that fills in the icons?
Created attachment 3313 [details] screenshot screenshot showing text overlap described in comment 48, issue 1.
> - One of my RadioTime stations (KPCC) is missing the icon on the RadioTime > site. When browsing RadioTime on SC, the icon is just missing, but when used > as a favorite it adds additional text that overlaps. Works fine on the SBC. No idea how this could happen. Can you give me the way I have to take through RadioTime to ge to this station? > - On SC, when I click on a favorite (rather than play or add) and go to the > "detail" screen, the large icon is displayed as the generic musical note or > radio tower icon, not the custom icon. Works fine on the SBC. Please open a new bug for that issue. I'd like to get this one closed :-). > - What will happen when users upgrade from 7.0 to 7.1? The icons will be updated whenever the .opml file is loaded. If there's no icon in the file, it will be looked up. If it's a db query, it will be updated as well, as a db scan can change album IDs etc.
(In reply to comment #50) > No idea how this could happen. Can you give me the way I have to take through > RadioTime to ge to this station? Just go to radiotime.com, search for "KPCC" and add it to your RadioTime favorites. On SC, browse RadioTime->MyRadio and add KPCC to your SC favorites. > > - On SC, when I click on a favorite (rather than play or add) and go to the > > "detail" screen, the large icon is displayed as the generic musical note or > > radio tower icon, not the custom icon. Works fine on the SBC. > > Please open a new bug for that issue. I'd like to get this one closed :-). Will do. > The icons will be updated whenever the .opml file is loaded. If there's no icon > in the file, it will be looked up. If it's a db query, it will be updated as > well, as a db scan can change album IDs etc. Ah, I see now. If a favorite already has icon="html/images/favorites.png", it won't get updated to the correct icon, but if icon= is missing it pulls in the proper icon.
(In reply to comment #50) > The icons will be updated whenever the .opml file is loaded. If > there's no icon in the file, it will be looked up. If it's a db > query, it will be updated as well, as a db scan can change album > IDs etc. That sounds like a potentially expensive operation. When does the .opml file get loaded? I can see people with many, many favorites. Hitting a lot of random URLs out on the 'net could take quite a while.
> That sounds like a potentially expensive operation. That's why it's only doing it for empty icons. It's mostly a one time action. > When does the .opml file get loaded? When favorites are accessed for the first time. Typically when loading the web UI.
I see a heart icon for both folders and file favorites. I think maybe a different icon - maybe the music notes - might be better for local files - using the heart icon is kind of redundant under Favorites. Any chance that icons could be displayed at the edit level? Just something to distinguish between folders and playable items without having to mouseover. Also, I just copied a Slacker favorite (New Favorite, give it a name and enter a Slacker link) and it received a heart icon.
> > The icons will be updated whenever the .opml file is loaded. If there's no icon > > in the file, it will be looked up. If it's a db query, it will be updated as > > well, as a db scan can change album IDs etc. I'm sorry for the confusion, I wasn't very clear: when the update is done during the import of existing files, they will _not_ have the original station icon. This data is only available when browsing the various directories. Instead the generic plugin icon will be used.
> Also, I just copied a Slacker favorite (New Favorite, give it a name and enter > a Slacker link) and it received a heart icon. Icons are only found when added from within their browse structure. This information is only available when browsing, no way to look it up afterwards (see my previous comment).
(In reply to comment #56) > Icons are only found when added from within their browse structure. This > information is only available when browsing, no way to look it up afterwards > (see my previous comment). If a URL begins with 'slacker://' (and I imagine other service playables have similar urls) I would have thought you'd just use the Slacker icon.
> If a URL begins with 'slacker://' (and I imagine other service playables have > similar urls) I would have thought you'd just use the Slacker icon. You entered this and it ended up with the generic Favorites icon? It should do what you say. Will check.
(In reply to comment #50) > > - One of my RadioTime stations (KPCC) is missing the icon on the RadioTime > > site. When browsing RadioTime on SC, the icon is just missing, but when used > > as a favorite it adds additional text that overlaps. Works fine on the SBC. > > No idea how this could happen. Can you give me the way I have to take through > RadioTime to ge to this station? I reported this to RadioTime and they agreed to fix it. It also looks like they've added a placeholder icon to stations that are missing one. I suggest you don't spend any time on this part of my report. (And you probably won't be able to reproduce it anymore anyway...)
Thanks for the feedback. They now indeed deliver a generic icon.
change 19431 - adding the favorite icon to the detail page.
Sorry Michael... I just noticed that if I navigate (on SC) to Slacker->artist-search-> and then add the favorite, it picks up the generic radio station icon instead of the Slacker one. Probably because the favorite is added as "http://www.squeezenetwork.com/api/slacker/v1/opml..." instead of "slacker://stations...".
> Sorry Michael... You better be... :-) > "http://www.squeezenetwork.com/api/slacker/v1/opml..." instead of > "slacker://stations...". I fear we'll have to add hacks for this kind of url for most services. change 19523 - please give it another try. Thanks!
The Slacker favorite icons now work as expected. Further testing reveals that some of the favorites themselves don't quite work as expected, but that'll be another bug... > I fear we'll have to add hacks for this kind of url for most services. Yeah. I don't have paid subscriptions for the other services so I can't really test them myself.
Ok, then I'll try to close that bug again... Thanks for testing!
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC