Bug 9056 - Album mixers don't work if duplicate mixers registered
: Album mixers don't work if duplicate mixers registered
Status: RESOLVED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Browser
: unspecified
: PC Other
: P5 normal (vote)
: 7.4.x
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-06 02:07 UTC by Erland Isaksson
Modified: 2009-11-03 07:19 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Log file with cometd debugging (2.63 KB, text/plain)
2008-08-06 02:07 UTC, Erland Isaksson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erland Isaksson 2008-08-06 02:07:19 UTC
Created attachment 3747 [details]
Log file with cometd debugging

Album mixers doesn't work in the artist menu on the Controller if duplicate mixer implementations are registered. As long as the MusicIP plugin is the only mixer registered everything works correctly, but when I register an album mixer in another plugin (for example Dynamic Playlist or Custom Browse), the album_id parameter is no longer transfered to the JSON command registered for the mixer.

The result is that MusicIP mixers won't work correctly as soon as a third party plugin starts using the Controller mixer functionality. 

I think the problem is that when two or more mixers are available an intermediate menu is displayed which shows available mixers. In this menu only the "artist_id" and "menu" parameter seems to be available, while if the mixer is executed directly all parameters are available (including the album_id parameter).

You can see the problem in the attached log file which shows the contextmenu request sent from the Controller and the response containing the mixer items for the intermediate mixer selection menu. As you can see the album_id parameter is part of the request but isn't part of the items returned in the response.

I'll soon publish Dynamic Playlist and Custom Browse plugin versions that supports mixers, if you need them for testing. 

The problem is probably visible in other places, album mixes was just the occurrence which I noticed.
Comment 1 Ben Klaas 2008-08-06 06:58:44 UTC
thanks for spotting this Erland. Can you let me know, preferably by a comment on this bug, when the new mixer-supported versions of your plugins are available?

Comment 2 Erland Isaksson 2008-08-06 08:05:25 UTC
(In reply to comment #1)
> thanks for spotting this Erland. Can you let me know, preferably by a comment
> on this bug, when the new mixer-supported versions of your plugins are
> available?
> 

Dynamic Playlist 2.3 was released a couple of hours ago and supports mixers in the Controller interface. 
If you install Dynamic Playlist and SQL Playlist plugins, you should get duplicate mixers if you also have MusicIP configured.
Comment 3 Ben Klaas 2008-11-02 12:35:01 UTC
this isn't going to be fixed by 7.3. retarget for 7.3.1
Comment 4 James Richardson 2008-12-19 08:01:56 UTC
Changing target to next release
Comment 5 Ben Klaas 2009-01-05 10:13:20 UTC
with only these exceptions, my bug list is being retargetted for 8.0

for 7.3.2 (very soon):
https://bugs-archive.lyrion.org/show_bug.cgi?id=7186 Browse albums/artists/genres/  years should remember previous state 

for 7.3.3 (later, but before 8.0):
https://bugs-archive.lyrion.org/show_bug.cgi?id=7139 Add editable "Network Settings" page

https://bugs-archive.lyrion.org/show_bug.cgi?id=7502 Add setup mode to set Static IPs (even if DHCP is present)

https://bugs-archive.lyrion.org/show_bug.cgi?id=7829 Jive menu broken if BLOCK_SIZE == list count + 1 and "Pla...

https://bugs-archive.lyrion.org/show_bug.cgi?id=8878 Party Mode

https://bugs-archive.lyrion.org/show_bug.cgi?id=10064 SqueezeCenter doesn't always auto-generate playerstatus w... (which will fix 8300)

https://bugs-archive.lyrion.org/show_bug.cgi?id=6334 add applet for network diagnostics (currently assigned to Tom)

Comment 6 Blackketter Dean 2009-07-22 08:39:22 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the single original product.
Comment 7 Ben Klaas 2009-08-26 07:47:01 UTC
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Comment 8 Erland Isaksson 2009-11-02 20:14:36 UTC
If you like to get rid of this, I think you can close it because the new context menu support works correctly and this old mixer support isn't needed anymore.