Bug 8481 - Screen dim engages during key hold
: Screen dim engages during key hold
Status: NEW
Product: SqueezePlay
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: -- normal (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-18 14:47 UTC by Marc Auslander
Modified: 2011-11-06 23:23 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Auslander 2008-06-18 14:47:50 UTC
If I hold the fwd key for a long time, skipping forward  in a long track, the screen dims.  IMHO, the hold should count as activity and prevent dimming.  I don't use a screen saver, so I don't know if it would engage while holding the key.
Comment 1 Blackketter Dean 2008-06-19 11:45:35 UTC
Ben: Can you take a look at this for 7.2?
Comment 2 Richard Titmuss 2008-07-24 04:29:49 UTC
This should be a simple fix, for 7.2.
Comment 3 Ben Klaas 2008-07-24 12:47:48 UTC
this is an aside and not directly related to the bug itself, but Marc, I thought you'd like to here about this trick--

if you press-hold on fwd, then release after the song scanner popup shows up, you can use the scroll wheel to select the spot in the track you want to scan to, then hit the center 'go' button to start playing the track at that location. I find that a much more efficient UI for song scanning. The screen dimming bug doesn't show up when using this method either :)

You can do the same trick for volume up/down

Comment 4 Ben Klaas 2008-07-24 14:34:18 UTC
seemed like it was simple, but my first try did nothing to correct this...

=== SqueezeboxJiveApplet.lua
==================================================================
--- SqueezeboxJiveApplet.lua    (revision 24807)
+++ SqueezeboxJiveApplet.lua    (local)
@@ -225,6 +225,8 @@
                        if keycode == KEY_HOME then
                                settingsPowerOff(self)
                                return EVENT_CONSUME
+                       else
+                               wakeup(self)
                        end
                        return EVENT_UNUSED
                end)

Q to Richard: if you press-hold on a key and don't let go, does the KEY_HOLD event repeat itself every x seconds until the key is let go? If not, what should I do to make the controller not trigger the dimming timer while the user is holding the key?
Comment 5 Ben Klaas 2008-07-24 14:34:50 UTC
cc:ing Richard for feedback on last comment
Comment 6 Richard Titmuss 2008-07-25 02:50:13 UTC
ben, you need to stop the power mode timer on KEY_DOWN and restart it on KEY_UP. maybe add an extra argument to wakeup(self, enable). on KEY_DOWN set enable to false to stop the timer, KEY_UP sets enable to true to restart the timer. don't forget to update any other places were wakeup() is called.

i think you'll also need to apply a similar fix to the screen saver applet.
Comment 7 Ben Klaas 2008-11-02 12:48:19 UTC
this isn't going to be fixed by 7.3. retarget for 7.3.1
Comment 8 James Richardson 2008-12-19 08:01:44 UTC
Changing target to next release
Comment 9 Ben Klaas 2009-01-05 10:13:16 UTC
with only these exceptions, my bug list is being retargetted for 8.0

for 7.3.2 (very soon):
https://bugs-archive.lyrion.org/show_bug.cgi?id=7186 Browse albums/artists/genres/  years should remember previous state 

for 7.3.3 (later, but before 8.0):
https://bugs-archive.lyrion.org/show_bug.cgi?id=7139 Add editable "Network Settings" page

https://bugs-archive.lyrion.org/show_bug.cgi?id=7502 Add setup mode to set Static IPs (even if DHCP is present)

https://bugs-archive.lyrion.org/show_bug.cgi?id=7829 Jive menu broken if BLOCK_SIZE == list count + 1 and "Pla...

https://bugs-archive.lyrion.org/show_bug.cgi?id=8878 Party Mode

https://bugs-archive.lyrion.org/show_bug.cgi?id=10064 SqueezeCenter doesn't always auto-generate playerstatus w... (which will fix 8300)

https://bugs-archive.lyrion.org/show_bug.cgi?id=6334 add applet for network diagnostics (currently assigned to Tom)

Comment 10 Blackketter Dean 2009-07-22 08:39:14 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the single original product.
Comment 11 Richard Titmuss 2009-07-27 01:13:17 UTC
Reset priority before triage.
Comment 12 Ben Klaas 2009-08-26 07:51:33 UTC
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Comment 13 Chris Owens 2010-03-15 18:04:57 UTC
7.4.x milestone is in the past
Comment 14 Chris Owens 2010-05-06 15:37:51 UTC
Tom is no longer available to us
Comment 15 Alan Young 2011-11-06 23:23:13 UTC
Unassigned bugs cannot have a priority.