Bug 6757 – build safer method for SC plugins to add to jive menus without stomping on other items

Bug 6757 - build safer method for SC plugins to add to jive menus without stomping on other items

Summary:

build safer method for SC plugins to add to jive menus without stomping on ot...

Status:	NEW

Product:	SqueezePlay
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	Macintosh Other

Importance:	P5 normal (vote)
Target Milestone:	Future
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-01-24 06:51 UTC by Ben Klaas
Modified:	2009-10-01 10:27 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2008-01-24 06:51:15 UTC

SC plugins when not coded correctly can send data structures to Jive which stomp on other data structures.

Case in point, Random Mix often disappears when the wrong plugins are installed
http://forums.slimdevices.com/showthread.php?t=42605

thoughts:

add a parameter to the register function called 'overwrite'. Unless 'overwrite' is used, new items for the jive menus cannot be added if they share an id with something already in the main menu structure. That's only a partial fix though, because SC has no knowledge of what's been added on the Jive side.

automatically add a prefix with the plugin name to the id that's sent. This would cure a lot of ills, but I'm fairly certain some of Erland's plugins (custom browse?) actually seek to overwrite existing menu items. So...

Comment 1 Richard Titmuss 2008-03-11 13:50:11 UTC

Ben, should this be 7.1?

Comment 2 Ben Klaas 2008-03-25 07:33:50 UTC

wiping priority field in 7.1 target bugs, as the priorities that were set as 7.0 target bugs are not relevant here.

Comment 3 Ben Klaas 2008-07-01 09:10:12 UTC

this is not making it into 7.1

Comment 4 Ben Klaas 2008-07-25 06:58:48 UTC

punting to 7.3

Comment 5 Ben Klaas 2008-11-02 12:30:41 UTC

this isn't going to be fixed by 7.3. retarget for 7.3.1

Comment 6 James Richardson 2008-12-19 08:01:07 UTC

Changing target to next release

Comment 7 Ben Klaas 2009-01-05 10:12:59 UTC

with only these exceptions, my bug list is being retargetted for 8.0

for 7.3.2 (very soon):
https://bugs-archive.lyrion.org/show_bug.cgi?id=7186 Browse albums/artists/genres/  years should remember previous state 

for 7.3.3 (later, but before 8.0):
https://bugs-archive.lyrion.org/show_bug.cgi?id=7139 Add editable "Network Settings" page

https://bugs-archive.lyrion.org/show_bug.cgi?id=7502 Add setup mode to set Static IPs (even if DHCP is present)

https://bugs-archive.lyrion.org/show_bug.cgi?id=7829 Jive menu broken if BLOCK_SIZE == list count + 1 and "Pla...

https://bugs-archive.lyrion.org/show_bug.cgi?id=8878 Party Mode

https://bugs-archive.lyrion.org/show_bug.cgi?id=10064 SqueezeCenter doesn't always auto-generate playerstatus w... (which will fix 8300)

https://bugs-archive.lyrion.org/show_bug.cgi?id=6334 add applet for network diagnostics (currently assigned to Tom)

Comment 8 Blackketter Dean 2009-07-22 08:38:57 UTC

Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the single original product.

Comment 9 Ben Klaas 2009-08-26 07:46:44 UTC

this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.