Bugzilla – Bug 4633
Browse genres page bar and sort order are broken
Last modified: 2012-03-27 06:56:54 UTC
This is with SlimServer v6.5.1 - TRUNK - Windows XP - EN - cp1252, Perl v5.8.8 MSWin32-x86-multi-thread & MySQL v5.0.22-community-nt. It's r11088 with the bug 3255 patch applied (the modified patch described in comment 58). When browsing "Genres" > GenreName > "All Albums", with the sort order as "Artist > Album" or "Artist, Year, Album": 1. The page bar is broken in a similar way to bug 3255. For example, the first page lists artists A > D but the page bar has CR as bold. Clicking on E for the next page shows artists J > G with ADEJLMNOPSTUVW as bold. 2. Compilations are sorted by the ARTIST on the last track, not by "Various Artists". 3. Albums with ALBUMARTIST aren't sorted by ALBUMARTIST. Instead, they're sorted by something else. e.g. ALBUM=The Concerto Collection ARTIST=<varies by track> ALBUMARTIST=Jacqueline du Pr� COMPILATION=0 is sorted under A (so either by CONDUCTOR or COMPOSER - both start with A). e.g. ALBUM=Officium ARTIST=<varies by track> ALBUMARTIST=The Hilliard Ensemble ALBUMARTIST=Jan Garbarek COMPILATION=0 is sorted under A (so by ARTIST or COMPOSER - some tracks have these as "Anonymous"). Thanks.
I don't really think this is a different problem from that discussed in bug 3255. A fix for that bug was checked in today, so please check tonight's nightlies and close this bug if the problem is addressed.
I've checked with r11111 and the problems are still there.
Ah, I see it now. Yes, it's a different, but similar bug.
the fix for bug3255 was to Slim::Schema::ResultSet::Album->browse the problem here is the same, but occurs in Slim::Schema::ResultSet::Contributor->descendAlbum This means that not only does it affect Browse Genre-><genre>-all albums, but also Browse Artists-><artist> as long as the items per page cuts it up into several pages
(In reply to comment #4) > This means that not only does it affect Browse Genre-><genre>-all albums, but > also Browse Artists-><artist> as long as the items per page cuts it up into > several pages I can verify that this is true. Probably not seen that often unless there's at least one artist with a very large number of albums or items per page is set low. Does this mean that a similar fix to the one in bug 3255 can be concocted?
maybe. some similar code is already there, but clearly something required to make it work is missing. I suspect that it is the fixupSortKeys that isn't making the right fixes, but what also bothers me is that the resultset being used at this point in the Contributor, where the resulting list is actually Albums so it MIGHT be using the wrong resultset. I never really manged to get my head round the Schema/* modules.
How important is this bug?
I can't say how important, but it makes browsing Genres > GenreName > All Albums unusable. This is one where you say to yourself, "Wow, that's _really_ broken".
change 16058 - please test
Testing with r16093 and a wipe/rescan, it's still broken for me. The page bar isn't quite as broken, in that only contiguous letters are now selected (i.e. inverse/greyed). However, the artists are offset from the letters from A onwards, and that offset increases as you go through to Z (I have no artists listed from T onwards). Also, VA albums aren't ordered under V but under one of the track artists. I'm still seeing incorrect sorting for albums with ALBUMARTIST, COMPOSER, CONDUCTOR and BAND, with some albums being sorted by one of those tags instead of the ARTIST or ALBUMARTIST.
> The page bar isn't quite as broken, in that only contiguous letters are now > selected (i.e. inverse/greyed). However, the artists are offset from the > letters from A onwards, and that offset increases as you go through to Z (I > have no artists listed from T onwards). After some more digging I've come to the conclusion that the pagebar for album view is broken when sorting for contributors unless you're in the pure Album view or below an artist (where sorting for artist can't be wrong...). Anywhere you you've come along other browse modes and more than one artist is to be displayed (Artists->VA, Genre->All Albums, presumably Years->Year with lots of albums). > Also, VA albums aren't ordered under V > but under one of the track artists. > > I'm still seeing incorrect sorting for albums with ALBUMARTIST, COMPOSER, > CONDUCTOR and BAND, with some albums being sorted by one of those tags instead > of the ARTIST or ALBUMARTIST. Please open new bugs for these - if there aren't already.
change 16102 - as a temporary solution I've disabled the alphanumerical pagebar in these cases, falling back to a pure numerical pagebar. Consider this a temporary workaround until we've found the real solution. Let's rather have a correct numerical pagebar than a broken alphanumerical one.
I've opened bug 6577 for the incorrect sorting of VA/ALBUMARTIST albums when the sort method includes artist.
Pushing the remaining issue post 7.0 as it need major work to be done
*** Bug 6609 has been marked as a duplicate of this bug. ***
This could be a good way to resolve this very old and EXTREMELY ANNOYING bug: https://bugs-archive.lyrion.org/show_bug.cgi?id=8001
Punting new_schema bugs
new schema won't happen for 7.4
This is fixed in onebrowser. All of the issues in the description about the pagebar and album sorting.
should this bug be closed then if its fixed in onebrowser? looking forward to that going official, so we can see what actually works and solves some of these really old bugs.
It is still not certain that onebrowser will be shipped with 7.6. Until that decision is made, I am not marking any of the onebrowser-fixed bugs as fixed.
is it now safe to mark this bug closed?
No, it still doesn't work. In the web interface you get groups of shortcuts (e.g. A-H) and clicking e.g. on any of the characters will bring you to the first one, so if I click on "D" it will get me to "A" instead.
> In the web interface you get groups of shortcuts (e.g. A-H) and clicking e.g. > on any of the characters will bring you to the first one, so if I click on "D" > it will get me to "A" instead. Hu? Does work for me. What browser? Can you check what URL is being used when you click D?
Can't see the links. Browser is Firefox. Does indeed work fine in Safari so seems to be a Gecko-only problem.
> Browser is Firefox. Works for me (FF6 on OSX). Make sure your cache is clean and fully reload the page. Any other issue with the page bar?
FF6, OSX 10.6.8 I did clean all caches. It's all three pages ("1-G"), ("H-S") and ("T-W") that don't work. The only character that works, is "A", all others get me to the second entry of "A" ("Acid Punk") and After cleaning the cache, now most pages for "Albums" and "Artists" don't work either.
Pippin - the issue you've been reporting is with the web UI's links being broken in FF6. Is this still the case with more recent version? Also I think this is different from the originally reported issue where the bar would not represent the correct sort order. Can we close this case?
Yes, works fine for me with 7.7.1 nd FF10