Bug 3255 - alphapagebar links miss targets in browse artwork
: alphapagebar links miss targets in browse artwork
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5b1
: PC Windows XP
: P2 normal with 6 votes (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-09 14:37 UTC by Jim McAtee
Modified: 2008-12-18 11:11 UTC (History)
10 users (show)

See Also:
Category: ---


Attachments
Screen capture - browse Albums by artist/year/album (17.02 KB, image/png)
2006-08-20 10:53 UTC, Jim McAtee
Details
Fix for sort order and pagebar issues for album browser (873 bytes, patch)
2006-09-24 19:54 UTC, Jan
Details | Diff
patch to add specific contributor for album artist sorting (1.49 KB, patch)
2006-12-29 15:29 UTC, Adrian Smith
Details | Diff
updated potential fix (3.23 KB, patch)
2006-12-30 15:27 UTC, Adrian Smith
Details | Diff
alternative potential fix (2.34 KB, patch)
2007-01-02 18:54 UTC, Adrian Smith
Details | Diff
fixed alternative patch (2.35 KB, patch)
2007-01-03 04:40 UTC, Adrian Smith
Details | Diff
updated alternative fix for albumartists (2.35 KB, patch)
2007-01-03 06:13 UTC, Adrian Smith
Details | Diff
fix including graceful schema update (3.03 KB, patch)
2007-01-03 12:17 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2006-04-09 14:37:29 UTC
The in-page letter anchors in browse artwork aren't being correctly placed with respect to the sort order set in the prefs.  The letter anchors are placed according to the previous/default sort order of album name.

For instance, my browse artwork sort order is set to 'Artist, Year, Album'.  Click on the 'F' in the alphapagebar and it correctly takes you to the 'F' page by artist name.  But it also moves to the in-page anchor for the letter 'F', which gets placed at the first album name beginning with 'F'.
Comment 1 Dan Sully 2006-04-22 15:21:31 UTC
Adrian - this is related to the changes you made, correct?
Comment 2 Jim McAtee 2006-04-22 17:24:50 UTC
Maybe also from the elimination of the browse_artwork template: http://svn.slimdevices.com/?rev=6554&view=rev
Comment 3 Adrian Smith 2006-04-23 04:16:21 UTC
Please try svn 7070 - anchors should now be based on the defined sort order.
Comment 4 Jim McAtee 2006-04-23 09:32:29 UTC
Looks good.  Marking FIXED.
Comment 5 Jim McAtee 2006-07-27 11:07:35 UTC
I'm seeing this again in Browse Albums at r8703.  Looks like the letters link to the correct page, but the in-page anchors are being placed without regard to the sort order pref and are instead using the album name.
Comment 6 Adrian Smith 2006-07-27 12:28:12 UTC
Dan - I'm not sure how to best do this - we really want to use the results of the pagebar build to define the field used for the anchors.  At present Jim is correct anchors don't obey orderBy.

Comment 7 Jim McAtee 2006-07-27 12:32:35 UTC
I should point out that I'm only seeing it in the gallery view of browse Albums.  I didn't realize that the sort order differs now when the view changes.  The list view is anchored correctly.
Comment 8 Jim McAtee 2006-08-04 12:09:32 UTC
The developers are probably aware of this, but I'll report it here just as an update.  At r8785 I'm seeing different, more broken alphapagebar behavior in browse albums gallery view.  The pages pointed to are now mostly incorrect.  What I'm seeing is that the alphapagebar seems to be broken at the same places (I have a 1-B, C, D-E, etc. same as before these latest checkins), but the pages are broken completely differently.  First page is '1' to 'Clapton', the second page is 'Clarke' to 'Steve Earle', and the third page actually begins in the middle of Steve Earle.  It ends up with the last pagebar links of T through Z pointing at empty pages.
Comment 9 Adrian Smith 2006-08-04 13:04:11 UTC
Dan - I think this really ought to be yours seeing as I can't keep up with the database changes...
Comment 10 Dan Sully 2006-08-04 13:06:04 UTC
There shouldn't be any/much more in the way of DB changes, at least not on a large scale.

Also, have I mentioned that I despise the page bar?
Comment 11 Adrian Smith 2006-08-12 04:03:16 UTC
Jim - could you try r8941?
Comment 12 Jim McAtee 2006-08-12 10:16:27 UTC
(In reply to comment #11)
> Jim - could you try r8941?

That works for Browse Albums when in the default Album sort order, but not for any of the other sorts.  When sorted by Artist/Year/Album I still have the same behavior as mentioned in comment #8 above.
Comment 13 Adrian Smith 2006-08-12 10:55:41 UTC
Hum - it seems to work for me at present.  With Artist selected as the first sort parameter, it should use the contributor.namesort field to define what is on each page.

Do you have albums with more than one contributor which match the strange entries?
Comment 14 Jim McAtee 2006-08-12 11:34:50 UTC
Strange entries?  Yes, I do have some albums tagged with multiple contributors.  I also use ARTISTSORT to sort artist names by last/first.  Here's how my library of 966 albums is paginated when sorted by Artist/Album.

1 A B : 10,000 Maniacs "In My Tribe" -- Eric Clapton "Pilgrim"
C     : Eric Clapton "Slowhand" -- Steve Earle "Guitar Town"
D     : Steve Earle "The Hard Way" -- Dexter Gordon "Generation"
E F   : Dexter Gordon "Go!" -- J. Geils Band "Sanctuary"
G H   : Joe Jackson "Blaze of Glory" -- John McLaughlin "Devotion"
I J   : John McLaughlin "The Heart of Things" -- Charlie Musselwhite "Memphis Charlie"
K L   : My Morning Jacket "Z" -- R.E.M. "Green"
M     : R.E.M. "Lifes Rich Pagent -- Steely Dan "Pretzel Logic"
N O P : Steely Dan "The Royal Scam" -- Various Artists "Trainspotting"
Q R   : Various Artists "Yule Be Boppin' -- Yes "Tormato"
S     : Yes "The Yes Album" -- ZZ Top "ZZ Top's First Album"
T U V : [blank page]
W     : [blank page]
Y Z   : [blank page]

Like I said earlier, it looks like the pagebar itself is broken up correctly - these are the same breaks in the bar that I remember always having seen when sorted by Artist, but the pages that aren't being broken correctly.

Looking at the links in the pagebar, the start=NNN url parameters are screwed up.  The 'Y Z' page above, for instance, shows 'start=1214', which is much higher than the total number of albums in my library.

Comment 15 Adrian Smith 2006-08-14 14:14:10 UTC
Jim - do you have any artists in your collection with unicode names?  I found that the one hebrew test track I had could cause the pagebar to mess up, but it worked when I rescanned with the track removed.  [don't know why at present]
Comment 16 Jim McAtee 2006-08-14 14:29:16 UTC
Probably.  I have a number of artist names with what I'd call extended characters... accented e's and such - B�la Fleck, Mel Torm�, P�rez Prado, Andr� Previn, etc.  I often just cut and paste the characters when I tag the files on my Windows desktop system.

Looking in my database I can see that these characters don't appear to have been normalized in the contributors table namesort and namesearch columns.
Comment 17 Adrian Smith 2006-08-16 11:37:41 UTC
Do any of these have extended characters for the first letter?  If so do these correlate when then the page bar starts to miss?  [not really sure this is the issue, but my one Hebrew song caused this [on linux]]
Comment 18 Jim McAtee 2006-08-16 12:02:16 UTC
(In reply to comment #17)
> Do any of these have extended characters for the first letter?

No.  I just went through my contributors table and none of the names starts with one of these characters.  That includes both the name and namesort columns.
Comment 19 Chris Owens 2006-08-18 12:24:18 UTC
*** Bug 3918 has been marked as a duplicate of this bug. ***
Comment 20 Jim McAtee 2006-08-20 10:53:10 UTC
Created attachment 1456 [details]
Screen capture - browse Albums by artist/year/album

One thing I just noticed - my compilations aren't being grouped together.  See the attached screen cap, which shows the 'M' page in list view and shows a couple of VA albums mixed in where they should not be.
Comment 21 Patrick Dixon 2006-08-20 11:32:04 UTC
See Bug 3350
Comment 22 Jim McAtee 2006-09-07 11:09:21 UTC
A dump of my MySQL SlimServer database can be downloaded from the following URL (it's about 1MB in a zip file).  Hopefully this will be of some help with the current pagebar problem.

http://zolx.com/slim/slimserver.zip
Comment 23 KDF 2006-09-09 12:30:26 UTC
*** Bug 4072 has been marked as a duplicate of this bug. ***
Comment 24 Dan Sully 2006-09-17 14:37:57 UTC
This is not going to be fixed for 6.5 - sorry all. It's too risky with a release right around the corner.
Comment 25 Jan 2006-09-24 19:54:07 UTC
Created attachment 1585 [details]
Fix for sort order and pagebar issues for album browser

Browse by album with different sort orders seemed to get really confused by various artist albums. I figured it was missing the some filter that removes the individual contributors on a compilation album. I copied the related code out of Slim/Schema/ResultSet/Contributor.pm and it seems to work. I haven't tried every single combination of sort order and Various Artist preferences, but the the ones I tried all seemed to work fine.
Comment 26 Patrick Dixon 2006-09-25 08:26:10 UTC
This patch is definitely an improvement for me.

However, I still see a couple of problems:-

The albums run on past the highlighted letters (eg ABC has Ds too), with the result that XYZ are blank because they are all on the UVW page.

Various Artist Albums don't get listed at all.  I reckon they should either be listed under V, or in a special category of their own.
Comment 27 Jim McAtee 2006-09-25 08:45:10 UTC
I'm afraid I see no difference other than compilations are completely removed from the album list when Artist is part of the sort order.
Comment 28 KDF 2006-10-04 22:34:32 UTC
with artist, year, album as the sort option, this patch is working great for me.  targets work, and various artists are all listed properly under V.  I'm currently using this under trunk, so maybe there is something else needed that wasn't merged to 6.5 yet?
Comment 29 Patrick Dixon 2006-10-05 02:06:35 UTC
I have items per page set to 50.  Not sure if this makes any difference, and I can't recall what the defualt is.
Comment 30 Jim McAtee 2006-10-05 13:01:04 UTC
I just tried the patch again on Trunk 7.0, r10216 and the behavior appears to be exactly the same as without it.  Using artist/year/album sorting.  Various Artists albums are appearing in the listings, so I'm not sure if my comment above was incorrect or something else changed.  VA albums appear in one of two places: either scattered through the album listings or grouped under 'Various Artists'.  I think I made this comment elsewhere for another bug:  It appears VA albums are being sorted into the list at the first trackartist who also has a complete album.  VA albums without such a trackartist end up under 'Various Artists'.
Comment 31 KDF 2006-10-05 13:02:24 UTC
and how are the targets?
Comment 32 Jim McAtee 2006-10-05 13:22:17 UTC
Off, same as before.  http://67.177.205.130
Comment 33 Ivan 2006-10-05 13:29:22 UTC
I'm on 6.5.0, and the patch improves things but doesn't solve the problem (sorted by Artist,Year,Album):

1. Whereas there was gross "overshoot" with the targets, I now get anywhere from one to seven albums. Used to be be from several to dozens!

2. Various Artist albums are completely GONE from the list. Sorted by Album: 1106 albums with 14335 songs by 1397 artists. Sorted by Artist,Year,Album: 1029 albums with 13004 songs by 600 artists.
You have the following choices: 

Comment 34 Mike Walsh 2006-11-17 14:59:54 UTC
has anyone mentioned that as you go deeper into the alphabet, SS will completely crash and close without warning and / or notification?

i have to restart SS from the tray icon when this happens.

i'm using a fairly recent 6.5.1 and i browse artwork via artist - year - album.
Comment 35 Mike Walsh 2006-11-18 11:00:13 UTC
perhaps i should add that i am using a fairly recent 6.5.1 build, win xp pro sp2, that the error i get (when it crashes) is perl interpreter fails, and that i can reproduce it every time so far.  i doubt its 'flakey memory' btw since its corsair.  like i said i can reliably reproduce the crash, and i don't have issues with any other apps.

i also have about 1600 albums, 95% of which have artwork.

Comment 36 Adrian Smith 2006-12-29 15:29:59 UTC
Created attachment 1748 [details]
patch to add specific contributor for album artist sorting

For those people still having problems with this, please try the attached patch (as an alternative to previous patch).  It should show all albums including VA albums, but will sort the VA albums into one place (by default under V at present).

It will require a wipe and rescan as it adds additional entries to the database at scan time.

Patch is against 7.0, but should also patch 6.5 OK.
Comment 37 Jim McAtee 2006-12-29 19:48:57 UTC
Against 6.5.1, after a full clear/scan, I get '0 albums with 0 songs by 0 artists' and a blank page when the sort order contains Artist.  Looking at the contributor_role table, there are no rows with a role of 10.
Comment 38 Adrian Smith 2006-12-30 15:27:25 UTC
Created attachment 1749 [details]
updated potential fix

Updated patch.  This one is against 6.5.1 svn and should find and sort all albums identified as compilations as various artists.

Early testing by Jim and Patrick sounds positive - please test.
Comment 39 Nigel Birch 2007-01-02 02:43:40 UTC
With v6.5.1 r11077 and the comment 38 diff, the browse albums for "Year, Artist, Album", "Artist, Album", "Artist, Year, Album" and "Genre, Artist, Album" don't display any results.  The part with the breadcrumb and drop down list is shown but no page bar or albums.  This is with IE7 and Firefox with Default, after a wipe/rescan and a clear browser cache.

The other browse album orders look good.
Comment 40 Adrian Smith 2007-01-02 03:06:18 UTC
Nigel - could you rescan again with --d_import on and check that you see "Import: Starting addAlbumSortArtist()", if so, what does --d_info show when doing this (it will be noisy I'm afraid).  You can probably do this without a full wipe and rescan.
Comment 41 Nigel Birch 2007-01-02 05:01:52 UTC
With --d_import, the only debug line I'm seeing is "2007-01-02 12:29:14.4130 Import: Wiped all in-memory caches.".  I've doubled checked the merge and Slim::Music::Import has the "Import: Starting addAlbumSortArtist()." debug line in there, so I've no idea why it's not being outputted.  I might be being very stupid...
Comment 42 Adrian Smith 2007-01-02 18:54:08 UTC
Created attachment 1751 [details]
alternative potential fix

Alternative patch which stores the additional database info in the album table.  This probably requires deletion of the existing database before rescanning.  Advantage over previous patch is that it should not have any side effects on contributor info.  

Should also sort albums marked as compilations under the ALBUMARTIST if also set.  Please confirm this is desired.

Patrick/Jim + others, please test.
Comment 43 Nigel Birch 2007-01-03 03:55:59 UTC
No idea what was wrong before, but a fresh SVN checkout of 6.5.1 with the comment 42 patch works for me, with one exception.

If an album is detected as a compilation then it's listed under V (as Various Artists) (okay) but if the compilation status is set explicitly using COMPILATION=1 then it's not.  Instead, it's listed under the artist of the last track (not okay).

Listing compilations under ALBUMARTIST makes sense to me.
Comment 44 Adrian Smith 2007-01-03 04:11:03 UTC
Subject: Re:  alphapagebar links miss targets in browse artwork

> If an album is detected as a compilation then it's listed under V (as 
> Various
> Artists) (okay) but if the compilation status is set explicitly using
> COMPILATION=1 then it's not.  Instead, it's listed under the artist of the 
> last
> track (not okay).
>

Are you able to look at the database?  If so is the contributor column set 
for the albums tagged as compilations?  Are you scanning the music folder, 
or using another importer? 


Comment 45 Adrian Smith 2007-01-03 04:40:01 UTC
Created attachment 1752 [details]
fixed alternative patch

Sorry - please try this one instead of attachment 1751 [details].  This should work with albums tagged as compliations.
Comment 46 Nigel Birch 2007-01-03 04:52:05 UTC
[This was written before the comment 45 patch has been tried.]

There�s three other problems I�ve found when browsing Genres > Classical > All Albums with , list as "Artist > Album".

1. If COMPILATION=0 and ALBUMARTIST is set, the album isn't listed under ALBUMARTIST.  Instead, it's under something else.

For:

ALBUM=The Concerto Collection
ARTIST=<varies by track>
ALBUMARTIST=Jacqueline du Pr�
COMPILATION=0

it's listed under A (so either by CONDUCTOR or COMPOSER - both start with A).  From Browse Artists, it's under J.

2. If BAND is set, the album is listed as that rather ARTIST.

For:

ALBUM=Requiem
ARTIST=Wolfgang Amadeus Mozart
BAND=The Academy Of Ancient Music

it's listed under A (so either by CONDUCTOR or COMPOSER - both start with A).  From Browse Artists, it's under W.

3. The first page lists artists A > D but the page bar has C and R as bold.  Clicking on E for the next page shows artists J > G with ADEJLMNOPSTUVW as bold.  Item 2 above wouldn't help, but non-continuous letters shouldn't be bold?
Comment 47 Nigel Birch 2007-01-03 05:36:00 UTC
The comment 45 patch fixes the problem at comment 43.  Thanks.

I think I now see what you mean by "Should also sort albums marked as compilations under the ALBUMARTIST if also
set."  I have this album:

ALBUM=LateNightTales
ARTIST=<varies by track>
ALBUMARTIST=Nightmares On Wax
COMPILATION=1

When browsing albums, it's listed as "LateNightTales by Nightmares On Wax" and is sorted as if it was "LateNightTales by Various Artists".  I'd prefer it to be sorted as "LateNightTales by Nightmares On Wax", i.e. under N not V.  That way, it can be tagged as a compilation to reduce the artists clutter in browse artists but still be under the ALBUMARTIST.
Comment 48 Nigel Birch 2007-01-03 06:07:55 UTC
A couple more:

1. When browsing by genre, with an "Artist, Album" sort order, compilations are sorted by the ARTIST on the last track, not by "Various Artists".

2. When browsing by year, albums are sorted by "Album" only.  The drop down sort selector doesn't have any effect other than causing the page to refresh with the same "Album" sort order.
Comment 49 Adrian Smith 2007-01-03 06:13:16 UTC
Created attachment 1753 [details]
updated alternative fix for albumartists

Does this one sort the compilation=1 albums with albumartist under the albumartist? (bug in previous patch)
Comment 50 Patrick Dixon 2007-01-03 06:33:57 UTC
Unfortunately I am getting these errors in the log when I attempt to scan the library - the only way I can add things is using Browse Music Folder - so I'm unable to test this patch at all!

2007-01-03 13:16:36.5199 Warning: Migrating from 6.3.x used with MySQL!
2007-01-03 13:16:38.4504 About to look for files in /home/shared/Music
2007-01-03 13:16:38.4518 For files with extensions in: [(?i-xsm:\.(?:ape|wma|shn|wav|wave|mp3|mp2|flc|flac|m4a|mov|m4b|mp4|mp+|mpc|ogg|aif|aiff|cue)$)]
2007-01-03 13:16:40.6668 getpeername() on closed socket GEN25 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 13:17:23.1494 getpeername() on closed socket GEN26 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:02.5607 getpeername() on closed socket GEN42 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:05.4672 getpeername() on closed socket GEN43 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:09.9030 getpeername() on closed socket GEN44 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:12.2342 getpeername() on closed socket GEN45 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:14.2670 getpeername() on closed socket GEN46 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:14.4839 Use of uninitialized value in join or string at /usr/local/6.5/server/Slim/Web/Graphics.pm line 90.
2007-01-03 14:30:14.4840 Use of uninitialized value in join or string at /usr/local/6.5/server/Slim/Web/Graphics.pm line 90.
2007-01-03 14:30:16.9566 scanPathOrURL: Finding valid files in: /home/shared/Music/Disk3/ALW/Ani DiFranco/Little Plastic Castle
2007-01-03 14:30:16.9570 About to look for files in /home/shared/Music/Disk3/ALW/Ani DiFranco/Little Plastic Castle
2007-01-03 14:30:16.9602 For files with extensions in: [(?i-xsm:\.(?:ape|wma|asf|wax|asx|lnk|wpl|shn|smil|rpm|ram|rm|wav|wave|mp3|mp2|m3u|pls|xspf|flc|flac|m4a|mov|m4b|mp4|cue|mp+|mpc|ogg|aif|aiff)$)]
2007-01-03 14:30:16.9657 Found 12 files in /home/shared/Music/Disk3/ALW/Ani DiFranco/Little Plastic Castle
2007-01-03 14:30:19.7967 getpeername() on closed socket GEN47 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:30:25.5716 getpeername() on closed socket GEN53 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
2007-01-03 14:31:10.0042 getpeername() on closed socket GEN60 at /usr/lib/perl5/5.8.5/i386-linux-thread-multi/IO/Socket.pm line 206.
Comment 51 Nigel Birch 2007-01-03 06:47:17 UTC
Yes, it does (comment 49 patch fixes comment 47 preference).  However, it causes compilations to appear under the ARTIST on the last track) rather than under "Various Artists".
Comment 52 Adrian Smith 2007-01-03 07:20:48 UTC
Try:
if ($isCompilation && !scalar @{$contributors->{'ALBUMARTIST'}}) {

For the line in Slim::Schema.pm that I've been changing for these patches.
Comment 53 Patrick Dixon 2007-01-03 07:24:22 UTC
Is anybody using these patches with 6.5.1 and standalone MySQL?

'cos I'm dead in the water now - the scanner just won't run.

Anybody know what "Warning: Migrating from 6.3.x used with MySQL!" means?  - this is with a completely clean slimserver dB.
Comment 54 Nigel Birch 2007-01-03 10:20:17 UTC
(In reply to comment #52)
> Try:
> if ($isCompilation && !scalar @{$contributors->{'ALBUMARTIST'}}) {
> 
> For the line in Slim::Schema.pm that I've been changing for these patches.
> 
Yes, that works (VA albums under V and ALBUMARTIST albums under ALBUMARTIST).
Comment 55 Adrian Smith 2007-01-03 12:17:19 UTC
Created attachment 1754 [details]
fix including graceful schema update

Updated fix which should work without the need to delete your existing mysql database.  Will need a wipe and rescan before it displays correctly though.

Assuming this gets positive feedback I will put it in 6.5.1.
Comment 56 Jim McAtee 2007-01-03 14:33:55 UTC
(In reply to comment #55)
> Created an attachment (id=1754)

This latest patch works well for me. Once this is checked in don't forget that it's also a fix for bug 3350.

Comment 57 Mike Walsh 2007-01-03 22:10:11 UTC
when will this be in a nightly build?

as soon as its in one, i'll try it, i really think this is already way overdue.  i don't want to mess around with patches, as i already don't like using beta stuff, and i don't want to spend time learning how to patch beta stuff.

so the sooner its in a nightly build the better, and i'll def let you know if i have any problems with it.

thx, -mdw
Comment 58 Nigel Birch 2007-01-04 01:51:34 UTC
The comment 55 patch gives the same result as comment 51 (VA albums not under V).  Changing the line given in comment 53 makes it all work.  Thanks again.

The browse genres and years problems (comments 46 & 48) exist without the patch (just checked) so I'll create separate bugs for those.
Comment 59 Nigel Birch 2007-01-04 04:10:19 UTC
(In reply to comment #58)
> The browse genres and years problems (comments 46 & 48) exist without the patch
> (just checked) so I'll create separate bugs for those.
> 
For the record:

Comment 46, items 1 and 3 - I've created bug 4633 for these.
Comment 46, item 2 - I can't reproduce this now.
Comment 48, item 2 is bug 4079.
Comment 60 Adrian Smith 2007-01-04 05:37:46 UTC
Fix commited to 6.5 at change 11102.

Note this includes an updated database schema.  It includes logic to cause an automatic upgrade and rescan if you upgrade to this version from a previous versions of 6.5.

However if you downgrade from this schema to an older version of slimserver and as part of the downgrade you delete the schema_X_down.sql files for the later version, then you will probably have problems with the database.  These can be solved by manually deleting the Cache/MySQL directory or a mysql drop and create of the database 'slimserver' followed by restarting the server.
Comment 61 Ben Klaas 2007-01-04 07:40:58 UTC
updated to 11102, and my alphapagebar targets are lining up beautifully now...nice work.

An aside, I have an album by �-Ziq (if that didn't print correctly, the first letter there is the greek letter mu), and as a result I get an "M" after the "Z" on my alphapagebar. Click on the trailing M and I get the �-Ziq listing. Personally, I think that's better behavior than I ever could have expected...cool.

Comment 62 Larry 2007-01-04 07:57:24 UTC
Thanks for working on this guys!
Comment 63 Mike Walsh 2007-01-05 12:35:54 UTC
close...  no cigar...

i am using the jan 5th version of the nightly download.

things ARE better, most of the letters and so on work fine.

HOWEVER, when i try "T" or "U" or "V" not only doesn't it work, but my entire slimserver crashes and burns and turns itself off.

perhaps this is due to the amount of artists i have or something, i'm not sure.

and it crashes nearly right away.  but the IE window stays up, and it shows a slow "downloading" of the localhost artwork, which eventually stops, to reveal nothing.

something is amiss.  any ideas?
Comment 64 Jim McAtee 2007-01-05 12:46:23 UTC
I'm not seeing any issues. Did you run a full clear/rescan?
Comment 65 Adrian Smith 2007-01-05 12:47:35 UTC
Mike.  Could you start slimserver from the command line (windows cmd, c:\program files\slimserver\server\slim.exe) and post the output of it crashing here?
Comment 66 Mike Walsh 2007-01-05 13:01:12 UTC
i had to do a full clear and rescan after installing the jan 5th build.  i can do it again if u'd like.

and ur losing me on the cmd line thing...

i did "cmd" at the run window, and got a dos looking terminal window.

i then navigated to the ss directory, and ran "slim" in the server dir.

it seemed to start SS.

i then opened an IE window and clicked T.  the output is below, i hope this is what you wanted:

Microsoft Windows XP [Version 5.1.2600]
(C) Copyright 1985-2001 Microsoft Corp.

C:\Documents and Settings\MrSinatra>c:\program files\slimserver\server\slim.exe
'c:\program' is not recognized as an internal or external command,
operable program or batch file.

C:\Documents and Settings\MrSinatra>cd \

C:\>c:\program files\slimserver\server\slim.exe
'c:\program' is not recognized as an internal or external command,
operable program or batch file.

C:\>cd program files

C:\Program Files>cd slimserver

C:\Program Files\SlimServer>cd server

C:\Program Files\SlimServer\server>slim
2007-01-05 15:58:32.7806 Perl interpreter failed at /PerlApp/Slim/Web/Graphics.p
m line 146.

C:\Program Files\SlimServer\server>

and btw, its the same error i was getting before the new patch.  look back at my earlier comments in the thread.

thx.
Comment 67 Mike Walsh 2007-01-05 13:05:43 UTC
i should say "perl interpreter fails" is the same to be precise...

i don't know if "failed at /PerlApp/Slim/Web/Graphics.pm line 146" was part of the first errors i found or not, (kdf had me look in the windows error events logs the first time).
Comment 68 Mike Walsh 2007-01-05 21:41:29 UTC
first, i cleared and rescanned yet again, same problems.

i was thinking the whole crashing thing might be a coincidence, meaning unrelated to this bug, but it did start happening around the same time this bug became obvious.

i also think there is a relationship to this bug, and the "various artists" / compilation - soundtrack type albums.

also, there are other problems...

at my "home" SS page, it says this:

"Your music library contains 1629 albums with 20115 songs by 545 artists."

it also says that when i click "artists."

however, when i click "Albums" is says this:

"1628 albums with 20113 songs by 5608 artists."

crazy.

winamp btw, which i think is pretty accurate, says this:

"1621 albums, 20087 songs, 2091 artists"

it gets worse...

on many ONE artist albums, if u drill down to the individual album, it commonly says multiple artists.

for instance, eric claptons "slowhand" says this:

"
Home / Albums / Slowhand 
1 album with 9 songs by 9 artists. 

All Songs
1. Cocaine from Slowhand by Eric Clapton
2. Wonderful Tonight from Slowhand by Eric Clapton   
3. Lay Down Sally from Slowhand by Eric Clapton   
4. Next Time You See Her from Slowhand by Eric Clapton   
5. We're All the Way from Slowhand by Eric Clapton   
6. The Core from Slowhand by Eric Clapton   
7. May You Never from Slowhand by Eric Clapton   
8. Mean Old Frisco from Slowhand by Eric Clapton   
9. Peaches and Diesel from Slowhand by Eric Clapton
"

9 artists?  huh?  9 guys named eric clapton i guess.  this happens randomly, but a lot.  sometimes its 12 songs by 4 artists when its only one artist, etc... no rhyme or reason to it that i can see.

"Various artists" are also listed at the top of each page when browsing "artists" instead of under V where it belongs.

whats going on here?  
Comment 69 Jim McAtee 2007-01-05 23:16:25 UTC
(In reply to comment #68)
> ...
> whats going on here?  

Sounds like you have some serious tag problems.  Obviously tag problems should not be causing crashes, but then again if you have unusual metadata, you might be finding a bug that hasn't been seen before.

Artist counts in many places are inconsistent or wrong.  That's a known issue.  The counts will definitely be more screwy if your tags aren't pristine, but even with perfect tags you'll see some weirdness.

Under browse Artists, VA is supposed to be at the top of each page.  I don't know the history behind why, but that's the intended behavior.
Comment 70 Mike Walsh 2007-01-05 23:54:13 UTC
ok, here's my reply to that...

i made all my mp3's with EAC and lame 3.96 or later.

i did have WMP add metadata it thought was missing, but only ADD missing data, NOT overwrite existing data.  thats how i get the artwork.

in "mp3tag" i don't see anything weird.

now, even if i had satans tags, it doesn't explain a lot of the behavior i have described above.  on one page, SS says 545 artists, on another 5608.

and i don't see how it could be possible for any tag to cause a crash.

and winamp doesn't seem to have any problem with the tags.  i never seem to see things i can't explain with it, nor does it crash as i listen or browse music with it, nor does wmp.

i guess what i'm asking you is please define "perfect, pristine" tags?  

give me some kind of idea of what tools to use to examine my tags and what could be wrong in them.  (i don't put artwork in the tag btw)  give me a benchmark.

and i ask this b/c i think using eac the way i have, and using WMP either on its own to rip (which i don't) or in conjunction to get artwork/missing data (as i do) shouldn't be "unusual" or causing any problems.

it is my contention that it isn't my tags...  i think SS is screwed up, and badly so.  

i would guess that absent the crashing problem, you have and see all the same bad behaviors i am describing, yes?

and btw, i think PART of the SS problem may be that i categorize some CDs in the dir struture.  i have a root, (D:\mp3home) and my main artists are in that...  but i also have D:\mp3home\BLUES and \SOUNDTRACKS and so on...  and i put stuff under those.  i dunno, its a guess.

if there's something in my tags to be fixed, then i'll TRY ANYTHING, BUT i really doubt thats it.  i think the problem is with something SS is doing, and i think the focus should be there.
Comment 71 Kai Harris 2007-01-06 00:16:55 UTC
(In reply to comment #56)
> (In reply to comment #55)
> > Created an attachment (id=1754) [edit]
> 
> This latest patch works well for me. Once this is checked in don't forget that
> it's also a fix for bug 3350.
> 

Latest nightly works well for me too, running 6.5.1 - 11112 - Debian - EN - utf8.

I'm *so* thankful to the folks who fixed this - it's my last outstanding problem w/ slimserver!

Kai
Comment 72 Mike Walsh 2007-01-06 00:34:02 UTC
also, since the error says graphics.pm, it may be having problems with my artwork.

like i said, most is from wmp, but some i had to get off the net via google or something.  i know SS has trouble resizing some of them, because they are some format of jpg GD can't handle...  but i don't see how or why artwork would crash SS.

(i set my thumbs to 140pixels and i use the "Folder.jpg"s to make them, which are normally 200x200 but can be bigger or different, esp if they aren't from wmp)
Comment 73 KDF 2007-01-06 16:27:40 UTC
I'd suggest that the crashing is a completely different issue, and should be filed separately rather than being used to hold this report open (not to mention adding confusion)
Comment 74 Jim McAtee 2007-01-06 23:52:58 UTC
I agree. Marking this fixed.
Comment 75 Mike Walsh 2007-01-08 13:05:48 UTC
just for the record, i have no desire to hold reports open, i tend to agree that the bug is fixed and that whatever is crashing my SS, is not part of this bug.

like i said, SS starting crashing at the same time this bug came into play, so it was a coincidence i suppose.

in any case, i still have a crashing problem, so my question is this:

having never filed a bug report, and not being a programmer, can someone tell me how i should create a bug report now?

whatever is happening, is something i can reproduce everytime, and i think is surely a SS issue.

thx, -mdw