Bug 9874 - 24/96 flac playback on the SBC will crash it
: 24/96 flac playback on the SBC will crash it
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Linux (other)
: -- normal (vote)
: 7.3
Assigned To: Richard Titmuss
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks: 9989
  Show dependency treegraph
 
Reported: 2008-11-02 04:36 UTC by Markus Schiegl
Modified: 2011-03-16 04:39 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
tail -f /var/log/messages (1.46 KB, text/plain)
2008-11-02 04:36 UTC, Markus Schiegl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schiegl 2008-11-02 04:36:39 UTC
Created attachment 4194 [details]
tail -f /var/log/messages

playback of 24/96-flac files on the SBC (r3253) will crash it - hangs for a few seconds until the watchdog kicks in. It's no bandwidth issue (almost 100% if located near the AP) and no power problem (sits in its cradle). No problems with 24/48 flac files. I know the controller uses the same DAC as the receiver and is therefore incapable to do this natively but there should either be better error handling or some resampling within linux - the same applies probably to SqueezePlay on Windows. (how many soundcards - especially those onboard - have 24/96 DACs?)

The same tracks on SqueezePlay/Windows (nightly, 08/11/02) play back in half speed.

hint: could you include a "Squeezeplay Playback" component or where should squeezeplay related bugs (for the controller) be filed?

thanks!
Comment 1 Richard Titmuss 2008-11-03 10:01:28 UTC
I have just tried this here, and it seems to be working fine with the 96/24 flac files I have for testing. Does it crash on all 96/24 files for you, or just some files specifically?

Comment 2 Markus Schiegl 2008-11-03 12:10:29 UTC
I'm sorry i didn't run a full 24/96-test suite on the SBC. An now i'm away from my controller and can't test it, but i'm able to provide a link to my track which has crashed the SBC (the one from the log).
Comment 3 Markus Schiegl 2008-11-04 10:31:09 UTC
just because i've heard no feedback, a short notice that i sent the link to richard at slimdevices com a few hours ago...i'm hesitating to put a link to this file on a public place. thanks!
Comment 4 Markus Schiegl 2008-11-07 11:44:57 UTC
Hi,

this issue is now masked by change 23839

---
bug 9113 Disable 96KHz and 88.1KHz by default on products that can't play it 
bug 8327 Squeezecenter should downsample high-sample-rate files for older players
---

High high-bitrate tracks are transcoded using lame now. I'd prefer transcoding to flac then this would be no bad solution at all. Or should Squeezeplay be officially high-sample-rate compliant?

For further tests i've reverted 23839 but with SBC 7.3r3308 and
- found 24/96khz tracks which worked fine
- found 24/88khz tracks with crashed the SBC, too.
...
Nov  7 20:27:57 SqueezeboxController user.info jive: (Playback.lua:240) - resume bytesReceivedL=326880 outputTime=2321 threshold=261120
Nov  7 20:27:57 SqueezeboxController user.debug kernel: 256fs: div 2 => result 97656, deviation 9456
Nov  7 20:27:57 SqueezeboxController user.debug kernel: best: fs=256, div=2, rate=97656
Nov  7 20:27:57 SqueezeboxController user.err kernel: asoc: machine hw_params failed
...

If you need more information - i'll carry my SBC with me this weekend :-)
Comment 5 Richard Titmuss 2008-11-13 07:31:33 UTC
Thanks Markus, I've downloaded the track now.

I've confirmed that it is 88.2k files crash the Controller. The following SC patch is needed to enable downsampling on the Controller.


Index: Slim/Player/SqueezePlay.pm
===================================================================
--- Slim/Player/SqueezePlay.pm	(revision 23917)
+++ Slim/Player/SqueezePlay.pm	(working copy)
@@ -60,6 +60,10 @@
 	
 	return $ret;
 }
+
+sub maxSupportedSamplerate {
+	return 96000;
+}
 1;
 
 __END__

Comment 6 Richard Titmuss 2008-11-13 07:54:37 UTC
Fixed Controller crash on 88.2kHz tracks in r3358.

I'll open a new bug for the desktop SqueezePlay problem.
Comment 7 Markus Schiegl 2008-11-16 06:12:04 UTC
I can confirm
- 88,2kHz tracks won't crash the SBC anymore
- the proposed patch works fine, i.e. no transcoding anymore

Will this patch be added in the future? Besides being able to downsample on the controller how will this compare quality wise to server-side downsampling (using something like sox)?
Comment 8 James Richardson 2008-12-15 12:09:05 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.