Bugzilla – Bug 8537
GPF on Vista during installer clean up
Last modified: 2009-09-08 09:11:45 UTC
Created attachment 3475 [details] Error during Install See attached images, during an install of 7.1 or 7.2 I get the following error messages in Windows Vista (SP1). Installing 7.0.1 does not generate these errors.
Created attachment 3476 [details] Error after install
These errors happen using an Administrator account, with no 3rd party Virus/Firewall applications installed. Windows Firewall is set to installed defaults (no modification by me) Vista updated with latest patches as of 20JUN08
1. message: this is a feature, not a bug! It's the result of the new network testing code. It has discoverd a problem. It tells the user. Maybe we need to work on the wording/layout a bit :-). I'm glad somebody is actually testing it... 2. message: I know. I see this about 1/10 installations. Any Windows version, not only Vista. I know what part of the code is causing the issue, but I don't know what's wrong. And as it doesn't always show up I'm having a hard time debugging :-(. I guess it's some resource not being correctly freed or something. Good news about 2. is that it only shows up once the installation has finished, when the installer is cleaning up. SC should be running fine anyway.
change 21179 - destroy port listener before closing the installer The main issue (installer crashing on cleanup) should be fixed now. Changing bug title and severity to match the remaining issue of the not so user friendly messages... Brian - if you had a great idea how that message could be improved?...
Tested 7.1-21263 today on Vista, I still see the error after install messages
which of the two?
James - just tested on my Vista: no problem :-(. Have you been installing on a clean system? Or is there any older version running? Could you try again after removing all the other version, cleaning temp folders etc.? I wonder whether we're running into the same kind of issue reported elsewhere, where old versions aren't overwritten.
please note that the firewall window popping up is correct. We're probing the firewall at this time, it therefore asks you whether this is an allowed connection or not. Nothing we can do here.
Changing summary to reflect error case #2 GPF after installing on Vista Moved case #1 Firewall Dialog needs rework to bug 8586 ==================== Michael: I start with a clean VM of Vista for each install test, no other versions of SC are installed prior to testing
Just tried 21304 after I've removed the previous version. The same error appears after installing 21304.
(In reply to comment #10) > Just tried 21304 after I've removed the previous version. The same error > appears after installing 21304. Dennis: Thank you for testing this, what version of Vista are you running? Home, Pro, SP0, SP1. Also, what firewall / virus protection software do you have installed?
I'm using Vista Ultimate SP1, built-in Vista firewall and ESET NOD32 Antivirus 3.0.630.0
Just to be sure we're talking about the same message: it's the "protection failure" like https://bugs-archive.lyrion.org/attachment.cgi?id=3476 ?
"access violation", not "protection failure" - sorry for the confusion
Can you attach a screen shot of the error
It's still the same error as I reported here: http://forums.slimdevices.com/showthread.php?t=49229
And with the latest build too... See the attachment.
Created attachment 3533 [details] Error after install
Still a problem with 7.1-21605 Tested on 2 different VM images and 1 "real" Vista Home install. The error happens after the installer is done and the clean up after install has started. SC works properly after clearing the message(s) that appear.
Michael should probably look at this, no?
I've been looking at this for a long time. And right now I can't reproduce the issue any more. Are you all seeing this issue on Vista _only_? Are you running the installer while logged on as a user with admin privileges?
using 7.1-21761 I am able to still reproduce this error on either a VM or REAL install of Vista SP1. This happens if I run the installer with or without Admin privilege This happens if I do a first time install or an over install of either 7.0.1 or 7.1 Steps to reproduce: 1) Install Windows Vista (Home/Home pro/Ultimate) 2) Upgrade Vista install to SP1 3) Update Vista will all available updates (optional) 4) Download 7.1 5) Install either by double clicking the .exe file OR right clicking on the installer and selecting "Run as Admin" 6) Click Unblock when Windows Security Alert window appears 7) Click OK when Setup firewall message appears 8) Notice that installer is halted until above message is clicked, then installer continues 9) When installer is done, click Finish ** At this point, the Application Error message will appear
Still can't reproduce. First thought the missing SP1 might be "responsible" for this. But even after installing the SP (had to add another virtual disk first... 7GB needed for the SP?!?) I don't get the message.
Created attachment 3596 [details] No port probing James - I'm going to upload a few test installers. Please run them and check which one does, and which one does not throw an exception. If possible, test more than once per executable. Please note that these installers don't install SC (even though it pretends doing so :-)). And I'm not interested in the other messages telling the result of som test. I'm only interested whether they create the access violation/exception as seen in the screenshot some user posted. Thanks!
Created attachment 3597 [details] no check
Created attachment 3598 [details] no error message
Created attachment 3599 [details] no IP detection
Created attachment 3600 [details] no ping
Created attachment 3601 [details] No IsPortOpen/ProbePort
James are you going to have a chance to look at these? Please let me know.
Since Squeezecenter runs okay after clearing the error, the risk of not fixing this bug is a very high number of support calls.
Hi, I've tested the installers and did get the error on Squeezesetup 3,4, & 5. I also noticed an extra popup on Squeezesetup 3. Also, I can't click the 'OK' button on the error mrssages until after squeezecenter has been fully started. See the attachments.
Created attachment 3602 [details] Extra dialog box before error dialog box. (Squeezesetup 3)
Created attachment 3603 [details] error Squeezesetup 3
Created attachment 3604 [details] Error Squeezesetup 4
Created attachment 3605 [details] Error Squeezesetup 5
I don't know if this the right place to add these comments, but I've noticed that the 'warning popup' appears everytime, although I've opened all the necessary ports manually. Just for fun I've disabled the firewall completely, but I still get these 'warnings' I should open the ports necessary for Squuezecenter. I believe these 'warnings' are false. Squeezecenter operates without problems, just by ignoring these 'warnings' messages.
When installing the latest build, I've waited to click on 'finish' until Squeezecenter has been fully started. This way the GPF doesn't appear.
Dennis - thanks a lot for the testing! Did you run every test just once or is the result reproducible? QA - con you confirm these results? Can you provide me with access to a machine which shows the behaviour (remotely or VM over FTP)? Bad news is this just confirms what I thought, but I still have no idea why it's working for me, but not you :-(
(In reply to comment #37) > I don't know if this the right place to add these comments, but I've noticed > that the 'warning popup' appears everytime, although I've opened all the > necessary ports manually. Just for fun I've disabled the firewall completely, > but I still get these 'warnings' I should open the ports necessary for > Squuezecenter. I believe these 'warnings' are false. > Squeezecenter operates without problems, just by ignoring these 'warnings' > messages. > Maybe we should only popup the warning dialog if it detects the ports are closed or blocked?
I have both a system you can use, as well as a VM image that fails I can FTP to you. I'll drop the VM ware into our FTP drop box for you.
> Maybe we should only popup the warning dialog if it detects the ports are > closed or blocked? Dennis - what exact message do you see here? James - what size is the VM image?
1 = works 2 = Prob warning, but no GPF = works 3 = Windows Firewall (asking for unblock permission) then "nixda" setup dialog, no GPF = works 4 = Windows Firewall (asking for unblock permission), then Port Warning dialog, then GPF = Fails 5 = Windows Firewall (asking for unblock permission), then Port Warning dialog, no GPF = works 6 = Port Warning dialog only, no GPF = works All installs done in English, as a first time install. Vista SP1 with all updates but NO 3rd party AV, default Vista settings. The errors are repeatable on both a "real" vista box as well as VM image. User account is Admin, installers run normal (double click) as well "as admin" I also captured a demo of the error as I run it, i'll upload that to the FTP as it's 15MB, I won't attach it to the bug.
My VM image of VistaSP1 is ~15gb
I just saw this today installing SC 7.2 r21819 with new streaming on Windows XP SP2. It also appears to be an access violation. SqueezeCenter started up just fine, too. I'll post screenshots.
Created attachment 3616 [details] First window with error message on XP
Created attachment 3617 [details] Second window with error message on XP SP2
Correction -- r21819 SC7.2 appeared to start up OK, but players could not connect to it. From player's standpoint, it just couldn't find SC. I reinstalled same version a second time and it now saw my SB3 just fine.
The warnings I get when installing Squeezecenter, while the necessary ports are open or the firewall has been disabled. (See attachments)
Created attachment 3618 [details] warning1: Windows Firewall blocking the probe
Created attachment 3619 [details] warning2: Squeezecenter 'open ports' pop-up
> I just saw this today installing SC 7.2 r21819 with new streaming on Windows Mickey - how did you get this information? Could you please upload the _full_ error message? You can copy/paste it from that window (or upload the .txt file shown?).
> warning1: Windows Firewall blocking the probe This message is displayed by Windows when the installer tries to probe the ports. As Windows' firewall does open/block bugs on an application level, it will show it even if you had opened the ports for SC, as the installer is a different executable.
I'm still seeing the GPF on cleanup after installing 7.1 - 21854 on my Windows Server 2008 32-bit system.
Thanks to Dennis I've been able to run a bunch of tests on a machine exposing this issue. I'm down to about ten lines of code where the bug must be, but have _no_ idea at all, why they would fail on one machine but not the other. In fact it seems to behave ok, only the result returned is wrong. In a nutshell: I'm lost :-). I suggest we remove that port scanning test from the 7.1 installer and re-consider the solution. While working on this I've encountered more issues which make me doubt it's the right way to detect firewall issues at all. Eg. the annoying firewall warning asking for the ports to be opened. As the installer is not the same executable as SC itself, this test will always fail, even if the ports have been opened for SC: Windows firewalls don't open globally, but on an application level. Additionally some of them keep checksums on the binaries to recognize replaced executables. Thus the firewall will probably have to be re-configured after every updated anyway (not the case for Windows' own firewall). May be we should improve the SC code instead of trying to do an intelligent installer. SC could give better feedback when it fails. Or the tray icon could scan the logs for a port conflict etc.
What do you think? Should I take that part out, as it's a.) buggy, and b.) doesn't exactly do what we want, because SC is a different executable than the installer?
I would vote for option "b"
I vote for removing it from 7.1/7.2 as well. At least until we can get something working
Created attachment 3661 [details] tweaked strings for michael
Thanks Dean - change 22034
Now that the GPF is gone, I consider this bug "fixed" (change 22028). I'll come up with some ideas on how to better handle firewall issues.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC