Bug 7781 - 'Snooze' button(s) don't do anything...
: 'Snooze' button(s) don't do anything...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: All All
: -- major (vote)
: ---
Assigned To: Andy Grundman
: new_streaming
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-09 08:40 UTC by Matt Wise
Modified: 2009-09-08 09:24 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments
very rough patch (3.73 KB, patch)
2008-04-11 15:43 UTC, KDF
Details | Diff
specifically for boom (4.90 KB, patch)
2008-04-12 16:04 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Wise 2008-04-09 08:40:43 UTC
The snooze button doesn't do anything yet ... at all ... its very, very, boring.
Comment 1 Caleb Crome 2008-04-09 09:39:44 UTC
This is a firmware/SqueezeCenter issue.
Comment 2 KDF 2008-04-10 20:19:26 UTC
So we really want the button function to be sleep.*?  Won't that be confusing, function wise?  Or, is the plan to have it perform sleep functions as well as having the sleep button do the snooze function when the alarm goes?

I have a snooze feature in the extended alarm, so it's easy enough for me to add the feature to the existing alarm.
Comment 3 Felix Mueller 2008-04-11 01:27:18 UTC
I think Dean would like to have the functionality like this:

- If no alarm is currently going off and the player is turned on, act as sleep button and turn player off in 15, 30, ... minutes.

- If alarm is sounding, act as snooze button and delay alarm for a couple of minutes.
Comment 4 Blackketter Dean 2008-04-11 07:43:34 UTC
That's right, per the UI spec on wiki-corp.  :)

That said, I finally got a unit with a working snooze bar and it's really really too easy to accidentally press it when picking up the remote.

I propose that the bar only be a sleep button with press-hold to avoid this.
Comment 5 KDF 2008-04-11 07:54:06 UTC
I don't understand.  You want sleep to be something you can accidentally trigger, but have press-hold for snooze?  Or do you mean having snooze easy to activate, but sleep function as a press and hold?
Comment 6 Blackketter Dean 2008-04-11 08:03:46 UTC
No, I want Snooze to be something easy to do when the alarm goes off and you are half asleep.

I want Sleep to be something a bit harder and require explicit pressing on the bar.  

The button on the remote should remain easy for both cases.
Comment 7 KDF 2008-04-11 12:40:03 UTC
ok, so this may need a slight change in button naming.  Since front panel uses .down-.up to map to do a full button map, we have the following:

Alarm Active:
front panel 'sleep' - snooze for 10 mins
remote 'sleep' - snooze for 10 mins

No Alarm:
front panel 'sleep.hold' - sleep
front panel 'sleep' - do nothing
remote 'sleep' - sleep

That last pair are the problem, as we don't know the source of the button, just the name.  So I propose renaming the front panel to 'snooze' so we have:

'sleep' or 'snooze' when alarm active - snooze for 10
'sleep' or 'snooze.hold' when no alarm - do sleep functions.

Comment 8 KDF 2008-04-11 13:41:19 UTC
The next question is, do we want 'snooze' available for x minutes after the alarm is triggered (ie, I'll set a function callback on trigger, then clear it some time later), or should we work similarly to RandomPlay where once the alarm is triggered, we stay in "alarm active" state until one of the %stopCommands are issued?  

In the Alarm Plugin, the alarm is a completely different button mode, so alarm active features end when the user interacts in any way that takes you out of that mode.  The built in alarm, simply jumps to playing mode.

Comment 9 KDF 2008-04-11 13:54:24 UTC
oh yeah, meant to ask...wiki-corp? Is that what the naming implies - internal coporate wiki therefore useless to folks like me?  Gives me an excuse to ask questions already answered ;)

Comment 10 Blackketter Dean 2008-04-11 14:07:53 UTC
Your description is good, and yes, the snooze button shouldn't do anything when snoozing, until the alarm goes off again.

Re: wiki-corp, Yeah, sorry that server isn't open.  I can send you the contents of that page, tho.


Comment 11 KDF 2008-04-11 15:43:25 UTC
Created attachment 3225 [details]
very rough patch

rough patch done on 7.0 trunk (so no connection with the real snooze button).  This borrows the 0 button from the remote as a simulation.  I'm not sure the modeParam active flag will be enough, but it works for proof of concept.  It can be a tricky feature to implement since it is context sensitive based on events rather than states.
Comment 12 KDF 2008-04-12 16:04:35 UTC
Created attachment 3227 [details]
specifically for boom

sorry for being so quiet.  much to do even though we're fully relocated.  This one remaps the boom button and seems to work.  Needs testing and hardening.  I still think it will need a callback, but that will be part of hardening.
Comment 13 KDF 2008-04-16 22:10:22 UTC
initial version in change 18841
Comment 14 Max Spicer 2008-04-30 07:45:09 UTC
See also #7904 which maps a single press to briefly show the time.
Comment 15 KDF 2008-04-30 15:29:35 UTC
useless comment to the link to bug 7904, as I seem to have trouble finding it in searches.
Comment 16 Chris Owens 2008-05-14 09:43:00 UTC
Chris to see if snooze works well enough
Comment 17 Max Spicer 2008-05-14 10:38:45 UTC
I'm actually about to change the way it works.  See Bug 7946.
Comment 18 Mickey Gee 2008-05-15 16:28:59 UTC
Hey Max -- your description has piqued the interest of some people here, and they're anxious to try it out. Any chance we'll be able to check it out soon?

Thanks!
Comment 19 Max Spicer 2008-05-16 00:23:35 UTC
Which bit?  The changes to time input are all done and checked in to the Boom branch.  I'm doing the changes to the alarm itself at the moment.
Comment 20 Max Spicer 2008-05-17 05:58:06 UTC
See Bug 8183 for feedback on active snooze.
Comment 21 Max Spicer 2008-05-17 09:34:51 UTC
At the moment an active alarm is cancelled (but playback continues!) upon any activity other than sleep or snooze.  A snooze can only be started when an alarm is active.  This means that if the user does anything other than press sleep or snooze after an alarm starts, they can't then start a snooze.  Any activity apart from sleep/snooze during a snooze cancels the snooze.  This behaviour is temporary - we  need to decide what it should be.
Comment 22 Max Spicer 2008-05-20 00:39:09 UTC
Snooze button now successfully schedules a snooze during an alarm.  During a snooze anything that starts music playing again cancels the snooze and the alarm.  Alarms (and therefore snoozes) are cancelled by anything that stops the music.

During an alarm/snooze the snooze button also pushes into the datetime screensaver (bug 8183).
Comment 23 Chris Owens 2008-06-05 15:42:24 UTC
Re-open if anyone is still having an issue with the snooze bar not working (that is not explainable by hoopty hardware)
Comment 24 Matt Wise 2008-06-11 09:38:19 UTC
I think our Snooze button still acts funny... I like that it takes 1-2 seconds of holding the bar down to get it to respond the first time, but once its up you should be able to quickly tap to skip from 15Min to 30 to 45 to 60 to 90 to Off without having to hold it down two seconds each time. 

Anyone else disagree? 
Comment 25 Michael Valera 2008-07-22 12:50:02 UTC
The snooze button does not function at all, to snooze an alarm, with the latest new-streaming 7.2 as of this morning (7/22) via an SVN update done late last night (7/21).
Comment 26 Max Spicer 2008-07-23 04:57:32 UTC
It's not the snooze button that's the problem.  In the new streaming branch, extra stop events get generated from S::P::StreamingController.  These cause the alarm to stop straight after it sounds, so it's no longer valid to snooze an alarm because it's no longer active.  Not ideal.  ;-)
Comment 27 Michael Valera 2008-07-23 13:04:10 UTC
Can we assign this a priority?

Snoozebar functionality is important for launch.

Mike
Comment 28 Blackketter Dean 2008-07-23 13:09:52 UTC
We won't punt this.  Andy's covering the new streaming work for the time being.
Comment 29 Andy Grundman 2008-07-23 13:10:55 UTC
Please mark new streaming bugs appropriately.  This means new_streaming keyword or, if non-Boom, product 7.2-new-streaming.
Comment 30 Andy Grundman 2008-07-24 11:47:03 UTC
Fixed in change 22073.  Most likely this fix will break something else.
Comment 31 Max Spicer 2008-07-24 12:08:39 UTC
Re-opening so someone can address comment #24.  This bug could maybe do with splitting out.
Comment 32 Chris Owens 2008-07-24 14:17:32 UTC
I split Matt's comment 24 about the duration of the button press to bug 8860.
Comment 33 James Richardson 2008-08-13 10:11:44 UTC
Verified fix 7.2-22579 r26.  Snooze bar now functions as designed
Comment 34 Michael Herger 2009-04-08 05:16:13 UTC
As Alan has fixed what Andy's patch broke, this issue is back, now reported as bug 11582