Bug 8183 - DateTime screensaver should provide active alarm/snooze feedback
: DateTime screensaver should provide active alarm/snooze feedback
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Max Spicer
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-17 05:40 UTC by Max Spicer
Modified: 2008-12-15 11:58 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-05-17 05:40:19 UTC
When an alarm is first activated, the datetime screensaver should be activated in order to emulate a traditional alarm clock - anyone being woken up by the alarm can then glance at the device to see what time it is.  Furthermore, the datetime screensaver should provide feedback that an alarm is currently going off (to address the "why have I just been woken up by music???" question and also feedback about any active snoozes.

This UI has been okayed with Dean and others via campfire.  I'm filing this bug to make it easier to keep track of my changes.
Comment 1 Max Spicer 2008-05-17 05:42:39 UTC
R19794 implemented pushing into datetime screensaver when an alarm starts.  It also prevents other screensavers from overriding datetime during an active alarm.  Alarmclock previously did a 30 sec showbriefly to tell the user that the alarm is active.  This is reduced to 3 secs if the datetime screensaver has been activated by the alarmclock.

We now have $client->alarmActive and $client->snoozeActive
Comment 2 Max Spicer 2008-05-17 05:47:42 UTC
R19806 flashes the alarm symbol if an alarm is active.

Any ir activity after an alarm starts cancels the alarm active state (and exits the screensaver).  This doesn't stop music - it merely shows that the user has acknowledged the alarm.
Comment 3 Max Spicer 2008-05-17 09:29:39 UTC
R19829 adds a flashing ZZ if a snooze is active.  This should probably be the Sleep symbol from the remote but I don't believe that's in the font at present.
Comment 4 Bryan Alton 2008-05-17 16:27:04 UTC
I have problems getting snooze to work wit latest changes.  Any suggestions ? 

08-05-18 00:24:10.1386] Slim::Hardware::IR::lookupCodeBytes (435) 00010026 -> code: snooze.down
[08-05-18 00:24:10.1394] Slim::Hardware::IR::processIR (655) 00010026   896.111 1211066650.13928
[08-05-18 00:24:10.1401] Slim::Hardware::IR::processIR (661) Front panel code detected, processing snooze.down
[08-05-18 00:24:10.1407] Slim::Hardware::IR::processFrontPanel (754) IR: Front panel button press: snooze
[08-05-18 00:24:10.1415] Slim::Hardware::IR::lookupFunction (510) irCode not defined: [snooze] for mode: [SCREENSAVER.datetime]
[08-05-18 00:24:10.1422] Slim::Hardware::IR::processCode (1040) irCode: , 00:04:20:1e:00:4c
[08-05-18 00:24:10.1435] Slim::Hardware::IR::lookupFunction (510) irCode not defined: [] for mode: [SCREENSAVER.datetime]
[08-05-18 00:24:10.1443] Slim::Hardware::IR::executeButton (988) Trying to execute button [] for irCode: []
[08-05-18 00:24:10.1449] Slim::Hardware::IR::executeButton (1029) Button [] with irCode: [] not implemented in mode: []
[08-05-18 00:24:10.3181] Slim::Hardware::IR::lookupCodeBytes (435) 00020026 -> code: snooze.up
[08-05-18 00:24:10.3189] Slim::Hardware::IR::processIR (655) 00020026   896.29  1211066650.31881
[08-05-18 00:24:10.3196] Slim::Hardware::IR::processIR (661) Front panel code detected, processing snooze.up
[08-05-18 00:24:10.3202] Slim::Hardware::IR::processFrontPanel (779) IR: Front panel button release after 0.178999999999974: snooze
[08-05-18 00:24:10.3210] Slim::Hardware::IR::lookupFunction (503) Found function: snooze for button snooze.single in mode common
[08-05-18 00:24:10.3216] Slim::Hardware::IR::processCode (1040) irCode: snooze, 00:04:20:1e:00:4c
[08-05-18 00:24:10.3228] Slim::Hardware::IR::lookupFunction (510) irCode not defined: [snooze] for mode: [SCREENSAVER.datetime]
Comment 5 Max Spicer 2008-05-18 03:07:36 UTC
Can you provide steps to reproduce this with the latest svn version?
Comment 6 Max Spicer 2008-05-18 03:22:36 UTC
Apologies, it was me that needed to be running the latest svn version.  Andy's just changed the IR code and this seems to have introduced these problems.  Andy - is this a bug in the new IR code or should I be doing something different?
Comment 7 Max Spicer 2008-05-18 03:45:40 UTC
alarm code uses "Slim::Control::Request::subscribe(\&alarmEnd, [['button']], $client);"
to subscribe to button presses.  It then does "my $button = $request->getParam('_buttoncode');"
to work out what the button was, and ends the alarm if the button wasn't sleep or snooze.  After the latest IR changes, the getParam call only seems to return '' whereas previously  it returned sleep, snooze, power_toggle etc.
Comment 8 Andy Grundman 2008-05-18 06:18:46 UTC
What IR changes are you referring to?
Comment 9 Bryan Alton 2008-05-18 07:49:49 UTC
I am using latest SVN - in fact I deleted all and checked out another copy just in case.

All I do is set an alarm, push power off so that date time are displayed. Wait for alarm and when alarm is ringing push snooze.  If I hold long enough Sleep action is taken so button is working.
Comment 10 Max Spicer 2008-05-18 08:02:52 UTC
This was broken but should now be fixed by R19858.  It will probably break again soon though as there are many other alarm-related changes to do.  Make sure you've got a backup alarm clock.  ;-)
Comment 11 Bryan Alton 2008-05-18 09:42:37 UTC
Snooze now works. Nice additions Max. 
I am working towards my ideal alarm setup and Max's additions are meeting some of my needs.  Desirable functionality. 
* next alarm time to be shown under "bell" on Date/Time  
* dual alarm (kdf's plugin may do this)
* Tone alarms not just music - how to simplify setup playing for a specified time tone samples in file.
* Alarm playlist can be a button preset.
* configurable snooze time setting (not just 9 mins).
 
Comment 12 Max Spicer 2008-05-19 13:59:50 UTC
The sleep icon is now in the font and so is displayed by the screensaver.  I personally don't like it - I don't think it's at all clear what it's meant to be.  However, that's the subject for another bug!
Comment 13 Chris Owens 2008-06-05 16:17:59 UTC
Marking as fixed then.
Comment 14 James Richardson 2008-07-25 14:29:23 UTC
Verified with r19 & 7.2-22118
Comment 15 James Richardson 2008-12-15 11:58:30 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.