Bug 7904 - Flash the time by pushing a button
: Flash the time by pushing a button
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Windows Vista
: -- enhancement (vote)
: ---
Assigned To: Squeezebox QA Team email alias
http://forums.slimdevices.com/showpos...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-19 20:29 UTC by Sue Chastain
Modified: 2008-12-15 11:58 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
Make single press of snooze show time (523 bytes, patch)
2008-04-20 10:51 UTC, Max Spicer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sue Chastain 2008-04-19 20:29:52 UTC
>
> MeSue;293338 Wrote:
>> Alarm worked fine this morning. But I would like a quick way to
>> display
>> the time by pushing a button. Say your alarm goes off in the morning
>> and you leave the music playing as you are getting ready, then you
>> have
>> no way to see what time it is if this is your only clock radio in the
>> bedroom. Maybe press and hold on sleep/snooze could flash the time?
>
> That's a great idea. If the snooze button could show the clock
> whenever it was pushed, it would be great. Especially if this could
> work when the off screensaver is set to nothing. Touch the snooze
> button, display lights up and shows current time for 10 seconds, then
> goes dark again.
>
> Max
Comment 1 Max Spicer 2008-04-20 02:03:21 UTC
When on, the snooze button currently functions as a sleep button, so this conflict would need to be resolved.
Comment 2 Sue Chastain 2008-04-20 07:58:33 UTC
Maybe a quick press could show the clock and a longer press could do the sleep function? To me it seems like the sleep function already requires a longer press, but maybe it's just a little laggy.

Another thought is that maybe the clock should be shown when the alarm goes off and just stay up until there is user interaction. I know that when I wake up to an alarm, I am more concerned with keeping track of time than seeing what song is playing. But even with that, I think there needs to be some way to get quick access to the current time from anywhere, even if it is a menu item.
Comment 3 Max Spicer 2008-04-20 08:03:35 UTC
It turns out that holding the snooze button triggers sleep.  Unless an alarm is active, a single press of the snooze button currently does nothing, so this is a prime candidate for triggering the time display.  It's a very fine line between a single press and a hold though - hopefully future hw revs might solve this.
Comment 4 Max Spicer 2008-04-20 10:51:56 UTC
Created attachment 3268 [details]
Make single press of snooze show time

The attached patch fixes this by calling datetime when the snooze button is pressed and an alarm isn't active.  It also modifies datetime to set the brightness to power on level.

This doesn't play nicely with an active vu screensaver, but I think that's a showBriefly problem.

The time isn't displayed if an alarm is active, which I think is the desired behaviour, but this needs checking.
Comment 5 Max Spicer 2008-04-20 11:15:58 UTC
I've just committed that patch.
Comment 6 KDF 2008-04-21 07:28:27 UTC
Max, when making comments about merging, please make note of the change number.  When a change number is recorded, a report can be marked as fixed.  If there are then any issues, it can be reopened or verified if there are no issues.
Comment 7 Max Spicer 2008-04-21 10:33:51 UTC
Fair enough.  Patch was committed at r18969.

Should probably also consider using the timeformat setting from the datetime screensaver.  In fact, would it be better to move the datetime function into the screensaver and call that?  Would need to handle the case where someone disables the screensaver plugin.
Comment 8 KDF 2008-04-21 11:08:09 UTC
1) use server pref only and use server lines version
2) use screensaver pref and screensaver lines, do nothing if disabled.
3) use screensaver pref and screensaver lines, if disabled use server pref and server lines.

3 is overly complex and would inevitably end up with constant re-explaining as users disable datetime and complain about the formatting change. But, is probably the most thorough design.

2 is still going to have questions as to why there is no longer a time shown.

1 will probably ALSO end up with questions as to why the format is different (much like we already get).  This seems the simplest solution.

I never understood the need to have different formats.  Always seemed like a one-user demand
Comment 9 KDF 2008-04-30 11:42:24 UTC
thinking about it, I rather like the idea of keeping it a discrete entity and leave the screensaver for just the screensaver.  Let this be a feature under the alarm clock umbrella.
Comment 10 KDF 2008-04-30 15:28:14 UTC
re: show time, I think we should keep the datetime function call as is. This way, you don't have to care about the datetime screensaver state, since you don't use it. Also, the show briefly can then be kept as something that is part of standard functionality, rather than a side effect of the "plugin"

although, since there is already alarm leakage, it might be sensible to make DateTime into a proper Button module and no longer have it as a plugin than can be disabled
Comment 11 Ross Levine 2008-05-05 13:53:38 UTC
Great feature. :) I edited wiki-corp to reflect the functionality of this feature. 
Comment 12 Sue Chastain 2008-05-05 13:59:35 UTC
Could this be expanded to also flash the time from the remote control?
Comment 13 Sue Chastain 2008-05-06 18:37:15 UTC
(In reply to comment #12)
> Could this be expanded to also flash the time from the remote control?
> 

Just a thought I had today... maybe the current time could be included in the information that is displayed when you press the right arrow from the now playing screen. That would make it easy to access the current time from the remote control.
Comment 14 Max Spicer 2008-05-11 01:29:30 UTC
FW7 breaks this.  When the device is off, pressing the snooze button now shows the time for a tiny amount of time - the merest flicker.  It still seems to work okay when on.  My guess is that this could be to do with the ambient light sensor, but I've not been able to track it down.  Has anything else gone on that would change the behaviour of showBriefly when off?  I have my display level set to dark when off.
Comment 15 Chris Owens 2008-06-05 16:39:40 UTC
QA to verify the current behavior.
Comment 16 Ross Levine 2008-06-05 16:55:33 UTC
Looks good in firmware 11, quick tap shows the time for 5 seconds. 
Comment 17 Max Spicer 2008-06-06 01:19:31 UTC
This is broken at the moment.  If the off screensaver is set to dark, the time does not appear.  The call to showbriefly requests a power-on brightness so this should work.  I suspect that the snooze button has been remapped to dead in off mode.
Comment 18 Max Spicer 2008-06-27 02:16:50 UTC
Mapping snooze.single back to snooze in off mode makes the time appear again when the boom is off.  However, the showbriefly only appears for a fraction of the time it should.  This only happens when the device is off - in on mode it works correctly.  I don't know why this is.  Any ideas, Adrian?
Comment 19 Max Spicer 2008-06-29 02:22:53 UTC
Adrian tweaked the display code and this now works as designed.
Comment 20 James Richardson 2008-07-14 10:22:29 UTC
Verified fixed in FW 18
Comment 21 James Richardson 2008-12-15 11:58:26 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.