Bug 7094 – No visual feedback when pressing + on Rhapsody albums, etc

Bug 7094 - No visual feedback when pressing + on Rhapsody albums, etc

Summary:

No visual feedback when pressing + on Rhapsody albums, etc

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Controller
Version:	unspecified
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-02-12 04:57 UTC by Richard Titmuss
Modified:	2009-09-08 09:17 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
have XMLBrowser push a showBriefly when adding tracks (1.57 KB, patch) 2008-02-14 12:12 UTC, Ben Klaas	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Richard Titmuss 2008-02-12 04:57:01 UTC

It needs a show briefly popup, this is on SN and SC.

Comment 1 Ben Klaas 2008-02-12 13:14:38 UTC

SC changes 17451 and 17458 have code to send showBriefly when hitting 'add' for Rhapsody albums (e.g.) and Remote Streams (e.g., standard internet radio streams), respectively.

Comment 2 James Richardson 2008-02-14 09:42:57 UTC

Dean would like this bug fixed

Comment 3 James Richardson 2008-02-14 09:43:55 UTC

*** Bug 7140 has been marked as a duplicate of this bug. ***

Comment 4 Ben Klaas 2008-02-14 10:13:50 UTC

This bug also happens when adding an Mp3Tunes album

PlayerUI gives no feedback either

Comment 5 Ben Klaas 2008-02-14 12:12:30 UTC

Created attachment 2884 [details]
have XMLBrowser push a showBriefly when adding tracks

note that showBriefly for hitting 'play' is still managed (and should be) by Commands.pm

Comment 6 Ben Klaas 2008-02-14 12:42:23 UTC

fixed in change 17559

Triode's opinion is that user feedback (showBriefly) should be managed in Commands.pm for consistency, and believed that my patch in bug#7141 was a better solution than this one.

I'm going with this one as it is a simpler and less risky path for a solution, but there needs to be some re-evaluation of user feedback and at what layer of the SC command execution it is sent. What we have now is very difficult to maintain, as we have user feedback showBriefly's sprinkled at every layer.

Comment 7 Blackketter Dean 2008-02-14 19:59:49 UTC

Thanks, Ben.

Agreed, this should be cleaned up.  Generally speaking, the feedback should happen in response to some user input, so the user input handler (as opposed to some playlist management code, for example) should be the one doing the triggering of the showbriefly.

Comment 8 Chris Owens 2008-03-07 09:03:40 UTC

This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.