Bugzilla – Bug 7140
'added to playlist' showBriefly unceremoniously stomping on more relevant showBrieflys
Last modified: 2008-03-11 14:13:10 UTC
there was a showBriefly "Added to Playlist" message added in the playlistXCommand function to fix bug 7094. This fix created the side effect of, in other contexts, sending this showBriefly immediately after a more descriptive showBriefly is sent. examples: Music Library-> Albums-> Some Album, hit "+" showBriefly appears saying "Adding Some Album to Playlist" and it is on screen for a split second before the more generic "Added to Playlist" message overwrites it. Random Mix->Track advances on its own Random Mix is a special case where tracks are automatically added to the playlist after others finish. What you see now in jive is a "Now Playing" showBriefly that is immediately stomped on by an "Added to Playlist" message as RandomMix is adding to the playlist. What I think needs to happen here is the playlistXCommand be allowed to pull in a tagged parameter to suppress the showBriefly message. This way the fix for bug 7094 can be preserved without causing the bad behavior described here.
Created attachment 2879 [details] proposed patch to send optional _suppress param to playlistXtracksCommand I tested this in four contexts: 1. Adding Rhapsody album to playlist (does not suppress 'Adding to Playlist') 2. Adding internet radio stream to playlist (suppresses in favor of more descriptive showBriefly for action) 3. Adding album from local library (suppresses in favor of more descriptive showBriefly) 4. Advancing track while listening to RandomMix (suppresses because message user should see is what track is now playing) playlistXtracksCommand should be converted to a tagged command in the future, but it's called all over SC in fairly obfuscated ways, and changing that now would be too risky. Will open a separate bug for that.
*** This bug has been marked as a duplicate of 7094 ***
*** Bug 7039 has been marked as a duplicate of this bug. ***