Bug 6933 - full string review of SBS
: full string review of SBS
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Localization
: 7.4.0
: Macintosh All
: -- major with 1 vote (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks: 6040
  Show dependency treegraph
 
Reported: 2008-02-04 01:07 UTC by Michael Herger
Modified: 2013-10-11 08:42 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
Small patch that fixes some minor glitches (8.18 KB, patch)
2010-03-01 03:17 UTC, Christian Erpelding
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2008-02-04 01:07:02 UTC
Some of the web interface's strings are outdated and barely describe what they should. This is particularly true for the settings pages. Some are as simple as broken references ("...change below" while the option is to the right).  I also assume there are quite a few unused strings, dupes (eg. NOW_PLAYING, PLAYING, PLAYING_RANDOMLY, JIVE_POPUP_NOW_PLAYING). We're at a point where even translators not too familiar with the product are complaining about the quality of our strings.

We need to walk through the different interfaces (especially the settings pages) and clean up the descriptions, use unified wording etc.
Comment 1 Michael Herger 2008-05-05 01:19:20 UTC
- many redundant strings in settings *, *_DESC, *_CHOOSE, pretty often only two of these three are used
Comment 2 Chris Owens 2008-06-04 11:38:09 UTC
Brian, Mike Dilley says he will work with you on this.
Comment 3 Brian Dils 2008-06-04 11:46:27 UTC
Ok, I'll be in tomorrow (thursday) and we can work on this
Comment 4 Chris Owens 2008-06-23 10:18:19 UTC
How is this coming along, Brian?  Do you need additional support from anyone?
Comment 5 Brian Dils 2008-06-24 11:46:54 UTC
Pushing this to 7.3 for now, but we'll probably get to it sooner
Comment 6 Mickey Gee 2008-10-24 14:42:16 UTC
Targeted for future release which is not on the list of choices.
Comment 7 Michael Herger 2008-10-24 15:23:07 UTC
we could as well close it as "wontfix"...
Comment 8 Blackketter Dean 2008-10-25 07:56:01 UTC
We _should_ improve the strings, but I think we need some more specifics about what needs to be cleaned up, Michael. 

Are you expecting somebody (like Brian, Weldon or Barbara) to just read the strings.txt file?  Or review the UI?  

As far as redudancies, etc., I think you'll need to scour the code to find unused items (maybe a little script to aid?)

What process would you like to see in place?
Comment 9 Mark Miksis 2008-10-25 11:17:19 UTC
I offered to clean up some of the EN strings for 7.0, but was told not to bother.  If you want community help, I think it would be useful if one of the UI guys could create a simple style guide.  Things such as:

- When to capitalize the whole string
- Use (or not) of colons and other punctuation at the end of strings
- Which types of strings should be phrases 
- Which types of strings should be complete sentences
- Internet vs. internet, Ethernet vs. ethernet
- etc.

IMO, these little things would make SC look much more polished.
Comment 10 Blackketter Dean 2008-10-25 11:47:12 UTC
Terrific idea.  Starting this here:

http://wiki.slimdevices.com/index.php/Style_Guide
Comment 11 Michael Herger 2008-10-26 00:11:24 UTC
I think I was pretty clear in my initial comment about what we need to do:

"Some of the web interface's strings are outdated and barely describe what they
should. This is particularly true for the settings pages. Some are as simple as
broken references ("...change below" while the option is to the right). [..]

We need to walk through the different interfaces (especially the settings
pages) and clean up the descriptions, use unified wording etc."
Comment 12 Blackketter Dean 2008-10-26 10:09:11 UTC
Understood.  I think the "we" in this is Michael and Weldon.

Michael: Can you please show Matt where the strings are, how they are used, and give him a bit of orientation on what you see as needing to be cleaned up.

Comment 13 Michael Herger 2008-10-27 00:57:36 UTC
Matt - I've written a wiki page about our strings handling which should give you a good starting point:

http://wiki.slimdevices.com/index.php/Strings

The strings we're talking about here are SC's main strings, which have come a long way. You'll find them in the server folder of your SC installation. It's the strings.txt file. (You'll have to open the SC pref pane package)
Comment 14 Michael Herger 2008-11-03 09:18:39 UTC
James - you have to _target_ this.
Comment 15 Michael Herger 2009-01-14 01:08:59 UTC
*** Bug 10667 has been marked as a duplicate of this bug. ***
Comment 16 Michael Herger 2009-01-14 01:09:18 UTC
from bug 10667:

Ticket # 090103-002746

SqueezeCenter 7.3.1 (Mac or PC)

Symptom:

1)  On the Settings >Player Tab >Display Menu  Under the Font section the
Information states: 

 "Use the SIZE button on the remote, or the radio buttons...etc"  

The Squeezebox Boom Remote does not have a "Size" button


2)   On the Settings >Player Tab > Basic Settings Menu under the Now Playing
Information section, it states:  

"You can cycle through these settings by pressing Now Playing on the remote
repeatedly"  

The Squeezebox Boom Remote does not have a "Now Playing" button


Should this information be changed depending on what Player is Selected in
SqueezeCenter?  The Squeezebox Boom remote does not have these buttons.
Comment 17 Chris Owens 2009-01-14 09:09:33 UTC
That would be slick (changing the displayed text depending on what device is selected) but is of course an opportunity for bugs, and adds a test case to SC.

Alternatively, we could just replace the Font instructions with ones that are usable on all players and make a note in the 'now playing' instructions that not all remotes have this button, and that the setting can be changed in Settings -> Display -> Now Playing info.
Comment 18 Weldon Matt 2009-01-22 10:12:10 UTC
Both SC and SN UI are being completely overhauled for "8.0."  All strings will be reviewed as part of this process, and a style guide will also be available (and hopefully be kept current) starting with the development of "8.0."  Because this is such a large amount of work, it's not going to be possible/realistic to do this review before then.
Comment 19 Michael Herger 2009-03-13 15:41:59 UTC
change 25527 - I removed around 150 (hopefully!) unused strings from SC.
Comment 20 Michael Herger 2009-06-05 22:26:44 UTC
With every product name change I'll increase the importance of this bug :-).

As we've previously replaced "slimserver" or "server" with "SqueezeCenter", we're now facing some ugly repeating "Squeezebox Server" within single paragraphs. Matt mentioned using lowercase "server" in some places instead...

Somebody has to do this. Matt - I guess you're no longer serious about comment #18? Bummer!
Comment 21 Chris Owens 2009-06-06 12:26:50 UTC
Currently this bug is assigned to Matt Weldon.  Matt, is it clear to you what needs to be done?
Comment 22 Weldon Matt 2009-07-29 16:41:42 UTC
Retargeting for 8.1 redesign
Comment 23 Weldon Matt 2009-10-04 16:32:57 UTC
Will need to work with Michael on this.  I only speak English unfortunately...
Comment 24 Chris Owens 2009-10-05 08:03:42 UTC
Remember you can leverage our community; they're the ones that originally localized Slimserver (Squeezebox server)!
Comment 25 Michael Herger 2009-10-05 08:09:41 UTC
> Remember you can leverage our community; they're the ones that originally
> localized Slimserver (Squeezebox server)!

This task is not about localization, but about fixing broken descriptions  
("button below" when it's to the right, "the Wow! button" when it's called  
"oh well" etc.)
Comment 26 Chris Owens 2010-02-02 15:08:16 UTC
Matt Weldon doesn't work for us any more.
Comment 27 Christian Erpelding 2010-03-01 03:16:58 UTC
I've found and fixed some small glitches in the strings.txt while trying to import them into SqueezeCommander. (Wrong tags, e.g. "<BR" and "<HREF=...")

One string had "SC" as language code but I think it should be "ZH_CN" (although I do not understand chinese). :-)

I'll attach a patch.
Comment 28 Christian Erpelding 2010-03-01 03:17:57 UTC
Created attachment 6582 [details]
Small patch that fixes some minor glitches
Comment 29 SVN Bot 2010-03-01 03:49:30 UTC
 == Auto-comment from SVN commit #30283 to the slim repo by mherger ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30283 ==

Bug: 6933
Description: fix a bunch of typos. Thanks Christian!
Comment 30 Alan Young 2011-11-06 23:22:51 UTC
Unassigned bugs cannot have a priority.