Bug 6784 - Add Jive 'play all' item when audio items with duration in a list
: Add Jive 'play all' item when audio items with duration in a list
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: unspecified
: Macintosh Other
: P1 normal (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-25 14:09 UTC by Andy Grundman
Modified: 2009-09-08 09:16 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-01-25 14:09:24 UTC
 
Comment 1 Blackketter Dean 2008-01-25 17:26:29 UTC
Another for ben?
Comment 2 Ben Klaas 2008-01-28 21:53:27 UTC
Can you give me an example of where this happens as well?
Comment 3 Andy Grundman 2008-01-29 05:34:04 UTC
Sorry, sure.  Pandora station list, Rhapsody album list, etc.
Comment 4 Ben Klaas 2008-01-29 08:49:38 UTC
the play icon is only used in the jive UI when the center button plays music. I do not see that being the case for Rhapsody album lists or Pandora station lists. In both cases, you must hit play for the item to be played

see Dean's comment in this bug
https://bugs-archive.lyrion.org/show_bug.cgi?id=6220#c16

am I correct in thinking this is invalid?
Comment 5 Andy Grundman 2008-01-29 08:53:13 UTC
OK I think the confusion is that we want it to work like the player UI, where if you see a music note you know you can press play to play something.  There is no such visual cue on Jive to know where you can press play.  Center button should never play music but that's just MHO. ;)
Comment 6 Andy Grundman 2008-01-29 09:27:45 UTC
Passing this to Dean.
Comment 7 Blackketter Dean 2008-01-29 10:05:29 UTC
That's right, the play icon should only be shown when pressing go triggers playback.  (And I agree, Andy, this should be used sparingly.)

The first item in song/station info should be play, the second one should be add (if it's addable).
Comment 8 Andy Grundman 2008-01-29 10:15:30 UTC
I really wish the menus were consistent across all UIs, but I guess we can't have everything.

One problem is we don't have generic "info" pages for most of these services, so there is no way to add play/add items to those menus without affecting all UIs.
Comment 9 Ben Klaas 2008-01-29 10:27:47 UTC
That's not really true from the Player UI.

Go to Music Library->Artists->Some Artist
or Music Library->Albums->Some Album
or Music Library->Genres->Some Genre

you can hit play and it plays. there's no music note for any of these.

Discussion aside, is this a bug with Jive? I see it behaving the same way that the rest of the Jive UI does, as specified by Dean in bug #6220.
Comment 10 Andy Grundman 2008-01-29 10:38:12 UTC
OK I was thinking of just XMLBrowser things.  I guess we can close this one if it doesn't need to be changed.
Comment 11 Blackketter Dean 2008-02-01 13:20:41 UTC
Under Recently Played -> Station Name, the "Play Station" choice should have a play icon on it.
Also, saw the same thing when descending on an artist, "Play Artist Station" does not have a play icon on it either.
Comment 12 Ben Klaas 2008-02-01 15:03:08 UTC
fixed in SC change 17118
Comment 13 Ben Klaas 2008-02-11 07:30:46 UTC
fixing bug#7060 re-breaks this.

I need a clear understanding of the logic needed to determine whether hitting 'GO' on an XML browse item. I had been looking at the item 'type', and if it was 'audio', then styling with the filled play icon. Clearly that's not
correct.

assigning to Andy for comment.
Comment 14 Ben Klaas 2008-02-11 07:31:58 UTC
previous comment should have read:

I need a clear understanding of the logic needed to determine whether hitting
'GO' on an XML browse item should cause music to play.
Comment 15 Andy Grundman 2008-02-11 08:17:03 UTC
Well as I've said before I really disagree with the fact that pressing go ever plays anything because it differs from the player UI.

There is a difference between something that is playable and something you want to play when you press Go.  Take for example drilling into a Rhapsody album, this is a playable item (the album) but you don't want it to play when you drill into it if you are just looking at the album details.  Even a Rhapsody track has a detailed sub-menu and you would not always want to have this auto-play.

Comment 16 Chris Owens 2008-02-11 09:53:19 UTC
Dean notes that the communication between SC and Jive needs to be expressive enough for Jive to determine that it's appropriate to display a play icon next to the menu item or not.
Comment 17 Andy Grundman 2008-02-12 06:58:56 UTC
Fixed in change 17433.  To test, try an MP3tunes album or Rhapsody album.
Comment 18 Chris Owens 2008-03-07 09:03:30 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.