Bug 7060 – Pressing go on (triangle)play icon doesn't always play

Bug 7060 - Pressing go on (triangle)play icon doesn't always play

Summary:

Pressing go on (triangle)play icon doesn't always play

Status:	RESOLVED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	UI
Version:	unspecified
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	---
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-02-09 10:24 UTC by Mark Miksis
Modified:	2008-02-11 07:29 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mark Miksis 2008-02-09 10:24:25 UTC

Maybe this is desired behavior, but it seems unintuitive.  The following has been observed using Slacker and Rhapsody, but may apply to other Music Services or Internet Radio as well.  An example with Slacker:

On Jive, browse to a station such as Slacker->Slacker Stations->Rock->Classic Rock.  The station menu looks like:

Play Station
Description
Artists playing ...
Save station...
Remove an artist...

The Play Station entry has a triangle play icon, but pressing GO on this item doesn't play, it advances to the next screen which is:

Play
Add
Title
URL
Delete

This Play entry also has a triangle play icon and pressing GO plays the station as expected.

IIRC, the planned behavior was that pressing GO on any triangle play icon will play.  IMO, either the first screen should allow GO to play the station, or the play icon should be replaced with a >

Comment 1 Blackketter Dean 2008-02-10 21:15:06 UTC

Ben:  Weren't you looking at this code?

Comment 2 Ben Klaas 2008-02-11 06:53:07 UTC

something went wrong recently. I'm seeing the play icon in a lot of places that I shouldn't.

I'll look into it this morning...likely a result of the many tweaks to how XMLBrowse items are identified and rendered to Jive.

Comment 3 Ben Klaas 2008-02-11 07:29:59 UTC

the fix for bug# 6784 is what broke this. Backing out the change for that and reopening 6784.

I need a clear understanding of the logic needed to determine whether hitting 'GO' on an XML browse item. I had been looking at the item 'type', and if it was 'audio', then styling with the filled play icon. Clearly that's not correct.