Bug 6220 – Play all, Play song, etc should have play icon on right, instead of >

Bug 6220 - Play all, Play song, etc should have play icon on right, instead of >

Summary:

Play all, Play song, etc should have play icon on right, instead of >

Status:	CLOSED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	Macintosh Other

Importance:	P2 normal (vote)
Target Milestone:	7.0
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-11-24 08:55 UTC by Blackketter Dean
Modified:	2009-09-08 09:15 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Play icon reference artwork (67.22 KB, image/png) 2007-12-06 12:37 UTC, ndijulio	Details
Add icon reference artwork (67.17 KB, image/png) 2007-12-06 12:38 UTC, ndijulio	Details
Arrow icon reference icon (66.91 KB, image/png) 2007-12-06 12:38 UTC, ndijulio	Details
Icon-add artwork (190 bytes, image/png) 2008-01-04 18:06 UTC, ndijulio	Details
Icon-play artwork (201 bytes, image/png) 2008-01-04 18:06 UTC, ndijulio	Details
Add selection-reference guide (67.15 KB, image/png) 2008-01-04 18:07 UTC, ndijulio	Details
Play selection-reference guide (67.20 KB, image/png) 2008-01-04 18:08 UTC, ndijulio	Details
This item should have a > symbol not a play symbol (58.59 KB, image/png) 2008-01-15 23:29 UTC, Blackketter Dean	Details
This item uses the play icon correctly. (59.32 KB, image/png) 2008-01-15 23:29 UTC, Blackketter Dean	Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2007-11-24 08:55:56 UTC

And add all/add song should have a plus icon on the right instead of +

Comment 1 Blackketter Dean 2007-11-24 22:45:27 UTC

We'll need some updated graphics from noah.

Comment 2 ndijulio 2007-12-06 12:37:37 UTC

Created attachment 2474 [details]
Play icon reference artwork

Comment 3 ndijulio 2007-12-06 12:38:03 UTC

Created attachment 2475 [details]
Add icon reference artwork

Comment 4 ndijulio 2007-12-06 12:38:26 UTC

Created attachment 2476 [details]
Arrow icon reference icon

Comment 5 ndijulio 2007-12-06 12:40:52 UTC

I attached some reference artwork for the icons.  Let me know your feedback.

Comment 6 Ben Klaas 2007-12-26 08:37:22 UTC

Target 7.0/Priority P4

Comment 7 Blackketter Dean 2008-01-02 15:46:36 UTC

This approach should also be used with Random Mix choices that can be played.

Comment 8 ndijulio 2008-01-04 18:06:13 UTC

Created attachment 2615 [details]
Icon-add artwork

Add artwork for selection box

Comment 9 ndijulio 2008-01-04 18:06:55 UTC

Created attachment 2616 [details]
Icon-play artwork

play artwork for selection box

Comment 10 ndijulio 2008-01-04 18:07:43 UTC

Created attachment 2617 [details]
Add selection-reference guide

Comment 11 ndijulio 2008-01-04 18:08:23 UTC

Created attachment 2618 [details]
Play selection-reference guide

Comment 12 Richard Titmuss 2008-01-11 05:41:54 UTC

*** Bug 6547 has been marked as a duplicate of this bug. ***

Comment 13 Richard Titmuss 2008-01-11 06:29:03 UTC

Ben I think this is an important UI feature, bumped up to P2.

Comment 14 Ben Klaas 2008-01-11 20:34:15 UTC

artwork checked in. will be adding the Lua hooks early next week.

Comment 15 Ben Klaas 2008-01-11 21:47:56 UTC

fixed in r1418

Comment 16 Blackketter Dean 2008-01-15 23:25:19 UTC

alas, not quite.
I see the play icon in many places now, it should only appear on items that play music when you press the go/center button.  As far as I know these are the Play All and Random Mix items.

See attachment.

Comment 17 Blackketter Dean 2008-01-15 23:29:19 UTC

Created attachment 2666 [details]
This item should have a > symbol not a play symbol

Comment 18 Blackketter Dean 2008-01-15 23:29:49 UTC

Created attachment 2667 [details]
This item uses the play icon correctly.

Comment 19 Ben Klaas 2008-01-16 06:39:23 UTC

Okay. I thought the logic was good (anything that had a play action gets a play icon), but I guess that's not what's desired.

Comment 20 Ben Klaas 2008-01-16 08:32:16 UTC

fixed as specified in Jive r1465 and SC change 16348

Comment 21 Mark Miksis 2008-01-17 10:50:45 UTC

This seems to only apply to Music Library items.  In bug 6547 (which was marked as a duplicate of this), I suggested that something similar be done for all menu items that can be played, including OPML plugins.  Is that being considered?  Should I reopen that bug?

Comment 22 James Richardson 2008-05-15 13:00:24 UTC

This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html