Bug 624 – MP3s may be decoded with a data rate not supported by S/PDIF

Bug 624 - MP3s may be decoded with a data rate not supported by S/PDIF

Summary:

MP3s may be decoded with a data rate not supported by S/PDIF

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Audio
Version:	unspecified
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	Future
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-10-15 09:25 UTC by Jim Knepley
Modified:	2008-12-15 13:05 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Patch to Source.pm and MP3.pm to force the resampling of mp3s if the samplerate < 44100 (3.25 KB, patch) 2004-12-02 04:02 UTC, Craig Eales	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jim Knepley 2004-10-15 09:25:54 UTC

Specifically, 22khz data doesn't play on most S/PDIF devices.
Since we have the ability to recode MP3s based on a bitrate limit, it seems a
relatively short road to identify "illegal" sample bitrates and recode them to a
supported rate.

Comment 1 KDF 2004-10-15 13:43:22 UTC

nto sure if slimserver tracks samplerate currently.  plus it depends on whether
you mean MP3 files or MP3 streams

Comment 2 Jim Knepley 2004-10-15 18:01:41 UTC

It appears that sample rate is tracked in the frame header, regardless of file
vs. stream. The problem is certainly more prevailing in streams, but there are
files that are mute as well.

Comment 3 KDF 2004-10-15 21:40:59 UTC

any files that are transcoded will be fine, but its the mp3's that are natively
lower bitrate than the max bitrate set for a given player.
Source::getconvertCommand would be the place to start working on a patch, I think.

Comment 4 Craig Eales 2004-12-02 04:02:44 UTC

Created attachment 216 [details]
Patch to Source.pm and MP3.pm to force the resampling of mp3s if the samplerate < 44100

Here is a patch to server/Slim/Player/Source.pm and server/Slim/Formats/MP3.pm,
it forces the mp3->mp3 conversion via lame if the sample rate of an mp3 <
44100.

Currently this only works for mp3 files, not mp3 streams.

Craig

Comment 5 Blackketter Dean 2005-03-11 15:02:02 UTC

Vidur will knock his sox off.

Comment 6 Blackketter Dean 2005-03-11 16:12:08 UTC

*** Bug 810 has been marked as a duplicate of this bug. ***

Comment 7 KDF 2005-08-20 10:17:53 UTC

*** Bug 1999 has been marked as a duplicate of this bug. ***

Comment 8 Blackketter Dean 2007-10-22 16:26:21 UTC

This should be fixed in Squeezebox2 or later.

Comment 9 James Richardson 2008-12-15 13:05:56 UTC

This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.