Bug 6234 - Cosmetic: Classic Clock-Redundant Info.
: Cosmetic: Classic Clock-Redundant Info.
Status: CLOSED WORKSFORME
Product: SB Controller
Classification: Unclassified
Component: Screensavers
: unspecified
: All Other
: P2 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-26 14:58 UTC by ndijulio
Modified: 2009-09-08 09:14 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Classic Clock Design (5.93 KB, image/png)
2007-11-26 15:02 UTC, ndijulio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ndijulio 2007-11-26 14:58:04 UTC
The top information bar currently displays:

1. date
2. month
3. year
4. and the day of the week

We should either:

Remove the day of the week from the top
or
Purpose a re-design to fit this option of configuration

I will attach a screen shot of the intended design.
Comment 1 ndijulio 2007-11-26 15:02:21 UTC
Created attachment 2447 [details]
Classic Clock Design

Intended design layout
Comment 2 ndijulio 2007-11-26 15:04:18 UTC
In addition, the am/pm should be aligned with the upper right edge of minute number.  See attached.
Comment 3 Richard Titmuss 2007-12-06 16:01:31 UTC
Dean, this is because the time/date preferences on jive are too big for the screen. They were made the same as slimserver at your request, but I think we have too many options, and they are too long. This came up before but we didn't change the list (bug 6075 and bug 5496). I think we should revisit this, its a simple code change to fix if we decide on the date formats to include.
Comment 4 Blackketter Dean 2007-12-06 17:22:15 UTC
Is it possible to have the clock wrap to a second line in the case that the text is too long?  
Comment 5 ndijulio 2007-12-06 17:54:56 UTC
For what it's worth, I think this is one instance where we do not want text wrapping.  Less is more!
Comment 6 Richard Titmuss 2007-12-10 03:40:44 UTC
Ben, please discuss with Dean and Noah and reach a conclusion :)
Comment 7 Ben Klaas 2007-12-10 07:04:41 UTC
What this bug was originally opened against I feel is not an issue that needs resolution. The format of the date string is user-defined and can/will change as a result. There may be redundant info printed, there may not be--it's kind of up to the user. I'm personally fine with that. Power to the people.

Moving to RESOLVED/WORKSFORME. Feel free to reopen if you think it warrants further discussion.

Much of the rest of what's discussed in comments to this bug is already fixed--

The date string that prints across the screen is done with a user-defined format--when it is laid out to the Classic Clock screen, the string object is checked to see if it exceeds the width of the box it is going in. If it does, fall back to a short date format.

this is the code:

        local theDate = os.date(datetime:getDateFormat())
        local dateSrf = Surface:drawText(self.datefont, self.datefont_color, theDate)
        local dw, dh = dateSrf:getSize()

        -- if date width exceeds border width, then fall back to a format that will fit
        if dw > bw then
                theDate = os.date("%a %d %b %Y")
                dateSrf = Surface:drawText(self.datefont, self.datefont_color, theDate)
                dw, dh = dateSrf:getSize()
        end


am-pm is now properly aligned, and clock centering has also been fixed for both 12 and 24 hour clock formats.


Comment 8 James Richardson 2008-05-15 13:00:29 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html