Bug 2726 – Date/time screensaver doesn't use same language as menu/web interface

Bug 2726 - Date/time screensaver doesn't use same language as menu/web interface

Summary:

Date/time screensaver doesn't use same language as menu/web interface

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Localization
Version:	6.2.2
Platform:	PC Debian Linux

Importance:	P3 enhancement with 2 votes (vote)
Target Milestone:	Future
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-12-19 03:46 UTC by VolkerOth
Modified:	2008-12-15 13:07 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
localize strftime function (1.11 KB, patch) 2007-03-20 12:00 UTC, Michael Herger	Details \| Diff
strftime patch for trunk (1.12 KB, patch) 2007-03-20 12:01 UTC, Michael Herger	Details \| Diff
better patch for trunk (1011 bytes, patch) 2007-03-20 13:51 UTC, Michael Herger	Details \| Diff
...even better for 6.5.x (983 bytes, patch) 2007-03-20 15:00 UTC, Michael Herger	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description VolkerOth 2005-12-19 03:46:40 UTC

The date/time screensaver seems to be the only component that uses the OS locales settings to chose its language settings. This is a little inconsistent because all other language settings are derived from the server settings.
Also, when starting Slimserver as a Linux boot script, the locales settings are not defined yet and would have to be set inside the start script - which contradicts the idea of using the OS settings.
I'd suggest to let the screensaver use the same server settings that all the other components use.

Comment 1 Dan Sully 2006-06-13 00:12:34 UTC

Yes - you are correct.. not sure if this will make 6.5 though.

Comment 2 Michael Herger 2007-03-20 12:00:23 UTC

Created attachment 1845 [details]
localize strftime function

This is a patch against the latest 6.5.2 branch. Please give it a try.

Comment 3 Michael Herger 2007-03-20 12:01:07 UTC

Created attachment 1846 [details]
strftime patch for trunk

Comment 4 Michael Herger 2007-03-20 12:03:12 UTC

I'm sorry, I didn't find working codes or test cases for Japanese, Hebrew, Chinese and Portuguese.

Comment 5 Michael Herger 2007-03-20 13:51:44 UTC

Created attachment 1847 [details]
better patch for trunk

set the locale once, not at every call to some date function

Comment 6 Michael Herger 2007-03-20 15:00:58 UTC

Created attachment 1848 [details]
...even better for 6.5.x

Comment 7 Michael Herger 2007-03-21 13:33:53 UTC

checked in to trunk in change 11659

(can't close the bug report)

Comment 8 Dan Sully 2007-03-21 13:37:04 UTC

Thanks Michael

Comment 9 James Richardson 2008-12-15 13:07:19 UTC

This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.