Bug 14986 - auto-dimming won't kick in when radio is switched off (soft switch off)
: auto-dimming won't kick in when radio is switched off (soft switch off)
Status: VERIFIED FIXED
Product: SB Radio
Classification: Unclassified
Component: Screensavers
: Include FW version in comment
: PC Ubuntu Linux
: P2 normal with 2 votes (vote)
: 7.5.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-29 00:29 UTC by dirk husemann
Modified: 2010-04-23 11:02 UTC (History)
7 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dirk husemann 2009-10-29 00:29:31 UTC
i've enabled auto-dimming on my SB Radio device and it does auto-dim when on --- VERY NICE. 

however, once i do a soft switch off (brief tap on the power button), the display comes on quite bright and stays that way --- VERY ANNOYING when the SB Radio is next to your bed.
Comment 1 James Richardson 2009-11-02 09:52:09 UTC
QA to verify all the screen savers.

Dirk: what hardware version Radio do you have?  on the radio, go to settings > advanced > Diagnostics.  tell us the hardware revision #

Also, which screen saver were you using?
Comment 2 dirk husemann 2009-11-04 14:37:08 UTC
firmware version: 7.4.1 r7915
hardware version: 4

screen saver when off: digital clock (black)
Comment 3 James Richardson 2009-11-11 09:29:29 UTC
*** Bug 15088 has been marked as a duplicate of this bug. ***
Comment 4 elziko 2009-11-11 10:08:27 UTC
I use the Digital Clock (Black) and I also have this problem. When the Radio is off it does dim but NOWHERE near as much as when they player is on.
Comment 5 Simon Turner 2009-11-20 00:56:57 UTC
Dimming works on my radio but the clock screensaver (black background) does not go dim enough and disturbs my sleep. I'd be happy if the minimum brightness was configurable, ala the Boom.
Comment 6 James Richardson 2009-12-01 11:27:01 UTC
*** Bug 15211 has been marked as a duplicate of this bug. ***
Comment 7 Ryan 2009-12-10 15:39:29 UTC
I have found settings that make this reproducable.

with unit set 
screen,screen savers, delay, 10 seconds  
screen,screen savers, when off, screen off 

place unit in diagnostics 

settings, advanced, diagnostics 

push power to go to standby mode. Wait for the screen delay 10sec and the
backlight comes on with the screen black.

there other conditions when this happens but this is reproducable.
Comment 8 Ryan 2009-12-10 15:41:54 UTC
This happens when on battery too which would drain the battery at a faster rate than expected
Comment 9 Felix Mueller 2009-12-14 09:10:10 UTC
Note: Screensaver should not kick in on Diagnostics (request from factory).
Comment 10 Felix Mueller 2009-12-15 05:38:41 UTC
Minimal brightness setting for Radio is covered in bug #11851.
Comment 11 SVN Bot 2009-12-15 06:43:17 UTC
 == Auto-comment from SVN commit #8224 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=8224 ==

Bug: 14986 
Description: Fix backlight turning back on after a while when using blank SS.
Comment 12 Ryan 2010-02-16 14:29:20 UTC
okay not reproducible as in comment 7. in 7.5.0 8445 

 it still does it in  7.4.2 8423
Comment 13 SVN Bot 2010-04-23 07:56:59 UTC
 == Auto-comment from SVN commit #8726 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8726 ==

Fixed Bug: 16023
Bug: 14986
Description: only ignore the _activate() screensaver method to fulfill bug 14986 if the_screensaver is the same as the currently running screensaver

I've tested this as correctly fixing bug 16023, and attempted to test that 14986 still works as desired. AFAICT, bug 14986 is still fixed, but I could use some independent verification of that one.
Comment 14 SVN Bot 2010-04-23 11:02:00 UTC
 == Auto-comment from SVN commit #8727 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8727 ==

Bug: 16023
Bug: 14986
Description: checkin r8726 fixed 16023 but regressed the fix for 14986
I've adopted a new approach, which is to allow a ssName to come in with the service method screensaverWindow(), and that name is attached to self.current when that ss window comes to screen
Then in _activate(), the check is for whether a screensaver is active and whether self.current == 'BlankScreen'. If those conditions are met, don't do anything (this fixes bug 14986). If those conditions are not met, go ahead and activate the SS (this fixes 16023).

note that in most cases, by the time _activate() is called, self.current will have been set to nil because the ss from the previous mode (e.g., going from when playing->when stopped) will already have been popped from the stack. That's fine, as in this case we'd want _activate() to continue going about its business.