Bugzilla – Bug 14145
XMLBrowse CMs should be richer
Last modified: 2010-08-13 15:07:02 UTC
To support 7.4 XMLBrowse CMs were delivered in a very minimal fashion: 3 items, Add to End, Play Next, and Play. There are many more items that could be provided, particularly at the track level. Suggest that the _playlistControlContextMenu does not provide 3 items and return, but rather provides three items, changes the chunk count data accordingly, and executes the rest of the query, providing a longer menu of options.
*** Bug 14319 has been marked as a duplicate of this bug. ***
Moving to 7.5, since the CM state of affairs currently is somewhat poor. At a minimum (and I think low hanging fruit), I think SP should offer Save to Favorites in the CM for anything that is presetable. Currently most music service related content can be saved as a preset but there is no way (other than the web ui) to save it as a favorite.
Also, while playing a favorite one should be able to remove it from the favorites list. It's not good enough to just be able to add favorites from the remote -- you have to be able to minimally manage them.
It's essential for the success of the duet to have the add favorite radio station function...
This looks like a duplicate of 14088. Not sure what the proper procedure is for marking it as such.
Ben to look to see if it's safe and easy to add a 4th item for 'add to favorites'. Andy notes that if the item is already in the favorites the menu item should be 'remove from
bumped to 7.4.1 P1 with intention of adding a fourth item for Favorites adding/deleting. bug will stay open for the meat of the bug, which is to deliver "the rest"
== Auto-comment from SVN commit #28845 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=28845 == Bug: 14145 +3 Description: Save/Delete favorites item in XMLBrowse context menus works for all xmlbrowse items tested except for napster and rhapsody albums
assigning to Andy for a look at Rhapsody and Napster album favoriting. These two URLs were saved to favorites but both result in failures when trying to issue a 'playlist play...' on them: http://www.mysqueezebox.com/api/rhapsody/v1/opml/library/getAllTracksForAlbumInLibrary?albumId=Alb.23824749 http://www.mysqueezebox.com/api/napster/v1/opml/menu?menu=favorite%3Aalbum%3A13361657&title=Love%202 this is the request that was sent for a Rhapsody album favorite: { --[[table: 0x174750a0]] "favorites", "playlist", "play", "favorites_title:Remind Me In 3 Days... by The Knux (2008)", "favorites_url:http://www.mysqueezebox.com/api/rhapsody/v1/opml/library/getAllTracksForAlbumInLibrary?albumId=Alb.23824749", "isContextMenu:1", "item_id:30a77cbd.72", "type:audio", "useContextMenu:1", } this is the request that was sent for a Napster album favorite: { --[[table: 0x1747e3d0]] "favorites", "playlist", "play", "favorites_title:Love 2 by Air", "favorites_url:http://www.mysqueezebox.com/api/napster/v1/opml/menu?menu=favorite%3Aalbum%3A13361657&title=Love%202", "isContextMenu:1", "item_id:30a77cbd.71", "type:audio", "useContextMenu:1", } Let me know if I can provide better debug...
== Auto-comment from SVN commit #28852 to the slim repo by andy == == https://svn.slimdevices.com/slim?view=revision&revision=28852 == Fixed bug 14145, pass around the favorite type so favorites of playlists can be saved correctly
The root of this bug is not fixed, but what we needed to get done for 7.4.1 (adding a favorites item) is. Reopening, retargetting.
Does this bug cover the issue of not being able to save last.fm stations to favourites once the station is started? There are plenty context menue entries (more than 3) but none says "save to favourites"
Well, 7.4.1 is now officially released, but the problem is still the same. Even on 7.5.0-29017 and jive_7.5.0_r7956 this is still exactly the same. Is it being worked on?
*** Bug 15043 has been marked as a duplicate of this bug. ***
(In reply to comment #14) > *** Bug 15043 has been marked as a duplicate of this bug. *** Bug#15043 was mine. Are you sure it was a duplicate? The information I was looking for is already available in the Now Playing context menu just not the menu where you choose which station to listen to. I'm happy with you marking my bug as a duplicate - I just wanted to make sure you understood what my iisue was. Thanks.
It's a good question as this is not obvious, but it is the same bug. XML Browse items, which include Internet Radio menu items, only have four items in their CMs because of a challenge on the server side that this bug encapsulates, and that's exactly the same bug as was described in 15043. The Now Playing CM is delivered differently and does not have the same limitation as when browsing through menus, which is why you see better behavior there.
fyi, in our complicated target milestones, 7.4.x/P1 is a higher priority than 7.5.0 P2
This is important to me. My Duet (used for Internet radio) has two Favorites lists. I see one when my computer (with SS) is on; the other, when off. Turning on "mysqueezebox.com Integration" should fix that, but it's either broken or underdesigned. To sum up, my desire is (1) to be able to add a radio station to favorites with the computer off (as in 14088) and (2) to have ONE set of favorites, so when I add a station with the computer ON, I can find it with the computer OFF. The latter seems so logical that it is hard to understand why it would ever work otherwise . . . but it does.
I should add, it's not clear to me that this bug includes the non-syncing of Favorites. If not, should I open a new bug, or would it be considered an enhancement request?
*** Bug 14088 has been marked as a duplicate of this bug. ***
== Auto-comment from SVN commit #29945 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=29945 == Fixed Bug: 14145 Description: instead of forking the xmlBrowseInterimCM requests off to a subroutine that delivers only 3 or 4 items, instead deliver these items prepended to the rest of the XMLBrowse response. The result is that Add Next/Add to End/Play and Favorites are all available in the CM, plus all additional information that can be delivered on that item. Tested against internet radio items, Pandora, Rhapsody, Napster, Slacker, and Last.fm. All work as expected. there is an underlying bug that if the CM items > BLOCK_SIZE the chunked response will result in a broken CM menu on the squeezeplay side because the count will be off. The fix for that is much more involved, and since BLOCK_SIZE is 200 and we're dealing with CMs only here, it's highly unlikely we're ever going to hit this condition.
Hm. The menu itself works, also including the Play, Add... items. However, at least for Napster the underlying Menus are mostly wrong. For an Album or Playlist, for example, they contain every track of that playlist (if you open the context menu on the playlist item). Since playlists can be pretty long, I would not be sure that your <200 items assumption will hold.
> However, at least for Napster the underlying Menus are mostly wrong. that strikes me a separate bug...what this bug was dealing with is getting around the problem that CMs need to have both transport control options at the top, and whatever the *info callback would send back for a particular item. What's being delivered by Napster for an album or playlist's *info callback is not really my territory. Suggest opening a new bug on that behavior...not sure, but it's probably Andy or Michael to address that.
https://bugs-archive.lyrion.org/show_bug.cgi?id=15551
I can't assign a bug.
duplicate entries seen in CM for items in local music. Couldn't arrive at a quick conclusion on this today, so reopening the bug. This is a P1 for 7.4.2 IMO, but will only be a server-side fix.
== Auto-comment from SVN commit #29962 to the slim repo by bklaas == == https://svn.slimdevices.com/slim?view=revision&revision=29962 == Fixed Bug: 15564 Fixed Bug: 15562 Fixed Bug: 14145 Description: don't prepend playlist control CM items for local music *info menus, which are pushed through XMLBrowser. Will test a bit further with this on Monday, but afaict this fixes local music CMs and retains the enhancement to internet radio and online service CMs
This seems to be an issue with non-local items, too. And it doesn't seem to be fixed for these. See http://forums.slimdevices.com/showthread.php?p=568929
Oh, and it looks like I can't reopen this bug...