Bug 1311 - Squeezebox2 FLAC decoder needs REPLAY-GAIN type capability
: Squeezebox2 FLAC decoder needs REPLAY-GAIN type capability
Status: RESOLVED FIXED
Product: SB 2/3
Classification: Unclassified
Component: Audio
: unspecified
: All All
: P2 enhancement with 8 votes (vote)
: ---
Assigned To: Vidur Apparao
:
Depends on: 1320
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-05 06:12 UTC by Jeff Coffler
Modified: 2009-09-08 09:21 UTC (History)
12 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Coffler 2005-04-05 06:12:13 UTC
Having just received my Squeezebox2, I noted that it didn't appear to have any 
capability (using the built in FLAC decoder) to apply REPLAY-GAIN tags in the 
FLAC file.

So I'm back to either decoding to WAV using FLAC executable (with appropriate 
REPLAY-GAIN tags) or going from FLAC->WAV->FLAC and sending that.

Might it be possible to have the built-in FLAC decoder understand how to apply 
REPLAY-GAIN tags?

A well-implemented feature would also have support in the SlimServer, such 
that the "Players" settings allowed album gain, track gain, or no gain to be 
applied.

Thanks.
Comment 1 Vidur Apparao 2005-04-05 08:44:59 UTC
Marking as an enhancement. We'll be looking at this after the initial crunch of
SB2 launch issues.
Comment 2 James Sutula 2005-07-13 10:02:27 UTC
A suggestion for selecting which type of gain should be applied:

A "smart" setting should exist that would check the previous and next file in
the playlist.  If either file's tags matches both the album name and album gain
tags in the current file, use album gain, otherwise use track gain.  This would
be very useful for people who switch between a shuffled and non-shuffled
playlist frequently.
Comment 3 michael 2005-07-13 10:31:32 UTC
if such a "smart album detection" feature as mentioned above were to exist, I
can think of other places it would come in handy apart from replay gain.
That is, if whoever implements this were to seperate out the smart detection
into it's own function, that would be nifty. 
Comment 4 Blackketter Dean 2005-08-19 16:20:32 UTC
*** Bug 1368 has been marked as a duplicate of this bug. ***
Comment 5 zengelman 2005-09-07 20:35:43 UTC
Could this logic be added to both the slimserver and sb2 flac decode logic 
with the ability for us to decide where the replay-gain is done.  That way we 
can continue to stream to sb2 in flac with lower bandwidth and apply 
replaygain there OR use stream.mp3 decoding at the slimserver side to stream 
to other devices in mp3 where replaygain was applied already in slimserver.
Comment 6 Vidur Apparao 2005-09-15 13:33:00 UTC
Fixes checked in as change 4292 and change 4301. 

From the checkin message for change 4301: "Added pref to allow disabling of
replay gain and a choice between track gain and album gain. Currently, we only
use the type of gain information specified by the pref. We could change the pref
to mean
prefer that type of gain information, but fall back to the other if it exists."
Comment 7 Abdomen 2005-09-15 14:25:23 UTC
"We could change the pref to mean prefer that type of gain information, but 
fall back to the other if it exists"

Thank you, Slim Devices, for this wonderful enhancement! Regarding the above 
quote, I would love it if James Sutula's suggestion in comment #2 were 
implemented. James also proved how nicely it can work with his Dynamic 
Transition Updater and "Smart Gain" Replaygain plugins 
(http://www.sutula.us/james/slimserver/).
Comment 8 Vidur Apparao 2005-09-15 16:57:21 UTC
OK - you asked for it. The default setting is now a "smart" gain selection based
on code in James Sutula's plugin (thanks James!). Album or track gain only are
also options. Enjoy!
Comment 9 Jeremy Daalder 2005-09-15 17:42:08 UTC
Fantastic!  Have been waiting for this since I bought the SB2 - the one really
big missing feature needed to make my 438 day mega music shuffle perfect!!

Does this work for all music formats (mp3 in particular) or just flac so far?

So this will be in the next nightly?
 
Comment 10 Vidur Apparao 2005-09-15 17:54:21 UTC
See http://forums.slimdevices.com/showthread.php?t=16409 for more information.
Comment 11 Dan Sully 2005-10-16 10:14:58 UTC
*** Bug 2299 has been marked as a duplicate of this bug. ***