Bug 12800 - Support snooze
: Support snooze
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI
: unspecified
: All All
: P1 normal (vote)
: 7.4.0
Assigned To: Ben Klaas
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-11 10:31 UTC by Fred
Modified: 2009-10-05 14:35 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
reference screen (13.19 KB, image/png)
2009-08-19 21:18 UTC, Ben Klaas
Details
screenshot of current alarm window (9.61 KB, image/png)
2009-09-02 20:03 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fred 2009-07-11 10:31:01 UTC
There is currently no way to snooze Fab4. 

The proposal in the linked thread is a new "Now Playing" screen design, that could only be active during alarms, that would propose clock + snooze + stop + volume and minimal artwork.
Comment 1 James Richardson 2009-07-13 10:09:10 UTC
Matt: would this be yours to design?
Comment 2 Weldon Matt 2009-07-13 10:23:23 UTC
Yes, working on this today actually.
Comment 3 Weldon Matt 2009-07-29 14:56:35 UTC
Part of the overall alarm clock design for 7.4.  Time estimate is just for this bug, not the whole feature.
Comment 4 Weldon Matt 2009-07-29 15:54:35 UTC
retargeting for 8.0
Comment 5 Weldon Matt 2009-08-19 14:55:00 UTC
I screwed up, this is indeed a 7.4 issue.  Assigning to Noah for a screen comp (which I believe is done?)

CM items when alarm is going off:

"Snooze"
"Turn Off Alarm"
Comment 6 ndijulio 2009-08-19 15:14:09 UTC
See QVGASkins >Guidelines >bb_cm_title_options_alarm.png

Context Menu

1. Title: "Alarm"
.............................
2. Time of alarm set: ex. "12:34"
.............................
3. Option 1 - Snooze
4. Option 2 - Turn Off
Comment 7 ndijulio 2009-08-19 17:09:41 UTC
This should be reassigned to the engineer responsible for implementation.  Guidelines are in place.
Comment 8 Weldon Matt 2009-08-19 17:40:03 UTC
Ben,

Apologies, I lied when I said there was no more work on the alarm clock :-).  This is the last thing, along with making the "alarm" button launch the alarm clock menu, and the alarm-setting widget.
Comment 9 Ben Klaas 2009-08-19 21:18:02 UTC
Created attachment 5642 [details]
reference screen
Comment 10 Fred 2009-08-20 04:48:28 UTC
(This bug does overlap with bug 12799)

This is cool, save for the fact this does not show CURRENT TIME (if I understand comment 6). There may be some time elapsed between the alarm starting (and music playing) and the user watching at this screen. In particular, I do believe that in many case, the snooze decision is based on the current time (i.e. "yes I have time for another 5 minutes in bed" or similar).
In fact, I don't think we care much at the alarm time at all. If music started/this screen is on, an alarm was (most likely) enabled in the recent past.

The other thing is I really would like to have VOLUME here. SC and iTunes go to some length to try to smooth out volume differences between songs - because there *are* volume differences in between songs. However, when setting the alarm volume, it will always be safer to turn it a little bit louder, to be sure it wakes you up (depending on the playlist, some songs in it may be very quiet). Now once you wake up, a slighly too loud setting coupled with a loud song not properly compensated by the mechanism above results in an alarm screaming in the morning (or that sounds like it in the early morning quietness). With the current design, I can turn it off or snooze it, when all I want is to turn it down a notch.
Comment 11 Ben Klaas 2009-08-20 14:29:31 UTC
notes to self: 

display current time in popup
Icons/icon_alarm.png for alarm icon asset
Comment 12 SVN Bot 2009-08-28 10:55:47 UTC
 == Auto-comment from SVN commit #28326 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28326 ==

Bug: 12800
Bug: 13146
Description: support for alarm_state flag in playerstatus response to Squeezeplay
three potential states right now: 'active', 'set', and 'none'
may still add something in that key/val pair for snooze
Comment 13 SVN Bot 2009-08-28 11:07:47 UTC
 == Auto-comment from SVN commit #7308 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7308 ==

Bug: 12800
Bug: 13146
Description: remove playerAlarmSet notification in favor of playerAlarmState
change getAlarmSet method to getAlarmState method
(these are API changes but I feel confident that no one is using them yet; getAlarmState is more appropriate for what is needed)
change clock applet to support new notification method
alarm icon on clock will show unless the alarmState is nil
Comment 14 SVN Bot 2009-08-28 14:04:49 UTC
 == Auto-comment from SVN commit #7311 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7311 ==

Bug: 12800
Description: some player methods that will eventually be used for snooze support
Comment 15 Pat Ransil 2009-09-01 09:10:38 UTC
A reviewer recently dinged us for the "bizarre choice of a 1 minute snooze" when reviewing Boom. What is the default snooze time? Is there any "standard" for clock/radios?
Comment 16 Ben Klaas 2009-09-01 09:13:26 UTC
9 minutes is default on every clock I've ever used, and I was nearly certain that the boom worked like that too.

Plan for Baby boom is a 9 minute snooze. I'm working on it today, actually.
Comment 17 Ben Klaas 2009-09-01 14:42:51 UTC
Still hoping to complete this later tonight, but taking longer than anticipated
Comment 18 SVN Bot 2009-09-01 23:00:18 UTC
 == Auto-comment from SVN commit #7364 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7364 ==

Bug: 12800
Description: Alarm Snooze applet (currently disabled as it's not totally functional)
changes to Player.lua to support alarm notification
fix in SlimBrowser for ampm calculation
Skin style for alarm window in QVGAbase
Comment 19 SVN Bot 2009-09-01 23:01:01 UTC
 == Auto-comment from SVN commit #28410 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28410 ==

Bug: 12800
Description: server-side support for SP-side snooze/cancel alarm request
Comment 20 SVN Bot 2009-09-02 07:16:10 UTC
 == Auto-comment from SVN commit #28414 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28414 ==

Bug: 12800
Description: snooze and alarm notifications are going to be handled by squeezeplay, so suppress the stock server-side showBriefly
Comment 21 Ben Klaas 2009-09-02 09:15:03 UTC
update- I think this is about 80-90% done. Hope to have a checkin to make it live later today.
Comment 22 SVN Bot 2009-09-02 14:38:36 UTC
 == Auto-comment from SVN commit #28418 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28418 ==

Bug: 12800
Description: remove stop_alarm logic as it's not needed. The stop alarm command from SP will be pause, which will pause the music and stop the alarm
Comment 23 Blackketter Dean 2009-09-02 15:23:45 UTC
Why pause and not stop?

-dean

On Sep 2, 2009, at 2:38 PM, bugs@bugs.slimdevices.com wrote:

> https://bugs-archive.lyrion.org/show_bug.cgi?id=12800
>
>
>
> --- Comment #22 from SVN Bot <svnbot@slimdevices.com> 2009-09-02  
> 14:38:36 PDT ---
> == Auto-comment from SVN commit #28418 to the slim repo by bklaas ==
> == https://svn.slimdevices.com/slim?view=revision&revision=28418 ==
>
> Bug: 12800
> Description: remove stop_alarm logic as it's not needed. The stop  
> alarm command
> from SP will be pause, which will pause the music and stop the alarm
>
> -- 
> Configure bugmail: https://bugs-archive.lyrion.org/userprefs.cgi? 
> tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
Comment 24 SVN Bot 2009-09-02 15:57:24 UTC
 == Auto-comment from SVN commit #7390 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7390 ==

Bug: 12800
Description: incremental checkin for Alarm Window. still not operational
Comment 25 SVN Bot 2009-09-02 19:39:40 UTC
 == Auto-comment from SVN commit #28419 to the slim repo by bklaas ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28419 ==

Bug: 12800
Description: send snooze as a separate state from active in playerstatus message
Comment 26 SVN Bot 2009-09-02 19:58:09 UTC
 == Auto-comment from SVN commit #7393 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7393 ==

Bug: 12800
Description: working alarm window with snooze and cancel alarm options is complete
mute button also works as snooze
back button hides window and continues alarm until playback is stopped by traditional means (e.g., pause key)

there are some loose ends yet, but this is, for the most part, working as designed now
Comment 27 Ben Klaas 2009-09-02 20:02:49 UTC
loose ends:

skinning of window is not to spec

alarm icon needs to go into status bar and be updated accordingly

clock applet needs to start showing the icon for the local player's alarm setting, not the player it is currently controlling

time in alarm window needs to update each minute the window is on screen (as you lay in bed not believing it's time to get up)

if controlling another player and the alarm for the local player goes off, switch squeezeplay to local player

setSelectedIndex on menu item for snooze is not styling it correctly (this is probably open as a separate bug somewhere)
Comment 28 Ben Klaas 2009-09-02 20:03:38 UTC
Created attachment 5778 [details]
screenshot of current alarm window

had trouble skinning this to spec, this is how it is right now
Comment 29 SVN Bot 2009-09-03 11:32:41 UTC
 == Auto-comment from SVN commit #7400 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7400 ==

Bug: 12800
Description: alarm icon in status bar for baby
Comment 30 SVN Bot 2009-09-03 11:56:35 UTC
 == Auto-comment from SVN commit #7404 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7404 ==

Bug: 12800
Description: only indicate alarms for local player
note-- if local player is controlling another player, currently it will not show anything for its local alarm indicator
Comment 31 Ben Klaas 2009-09-03 12:04:10 UTC
"clock applet needs to start showing the icon for the local player's alarm
setting, not the player it is currently controlling"

this can't be fixed easily and IMO does not need doing for 7.4 release. Baby will not show indication of an alarm set locally when controlling a different player on screen. see bug 13838 for details.
Comment 32 SVN Bot 2009-09-03 12:11:37 UTC
 == Auto-comment from SVN commit #7406 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7406 ==

Bug: 12800
Description: update time in alarm window to always reflect current time
Comment 33 SVN Bot 2009-09-03 12:24:30 UTC
 == Auto-comment from SVN commit #7408 to the jive repo by bklaas ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7408 ==

Bug: 12800
Description: dormant code to switch to local player when local alarm goes off and local player is not current player
does not work due to bug 13839
Comment 34 Ben Klaas 2009-09-03 12:29:10 UTC
all loose ends are tied up or have separate bugs opened for them.

This should be functional now. When we get a new baby fw out, please give this a whirl (note: update your Squeezebox Server as well)
Comment 35 Fred 2009-09-04 16:53:58 UTC
Cool. I still would have liked volume on the popup - it would fit IMHO on Fab4, maybe not on Baby (but it's got hard buttons for that!).
Comment 36 James Richardson 2009-10-05 14:35:47 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.