Bugzilla – Bug 9970
Scanner crashes when handling FLAC with embedded cue and external cue
Last modified: 2009-07-31 10:31:47 UTC
I have a customer who's scanner crashed when he is trying to scan large FLAC files. I have asked James about this issue and he was able to reproduce it via 7.2.1 and 7.3 RN ticket # 081025-001915
Created attachment 4236 [details] Scanner log Here is a log of the scanner. Notice it will some time give an error, and sometimes just fail with no error
The same behavior exists if I attempt to add an errant FLAC file to a playlist when browsing the music folder directory. SqueezeCenter churns for a while, uses up a huge amount of memory, and then eventually dies in the same manner as scanner.exe. I'm presuming that the same logic for parsing the FLAC file/CUE sheet exists in both programs.
Alan: would this be yours to look at?
No, I don't really have any experience with the scanner.
It might be useful to note that this problem did not exist until version 7.2. These FLAC files have been around for some time and all versions of SqueezeCenter and SlimServer from version 7.1 back were able to digest them without problems. The issue seems to have started with version 7.2 and continues in version 7.2.1.
Comment on attachment 4236 [details] Scanner log James to keep looking at this.
James to work on getting a 'smaller' reproducible set of files
James to continue looking at this issue. Andy is happy to look at this once we get a good reproducible case.
If it's any help, I have FLAC files on my end that fail every time. I'll be happy to provide them.
Ken: that would be great if you could point us to a location. They would be too big to attach to this bug however.
Try this file - http://misc.lemmingstothesea.com/MTV_Unplugged.zip The unzipped directory, when scanned as the only item in the SC music directory, will cause scanner.exe to go haywire once it hits the file singlefile_2006_8_13_21h19m09s. Once the web UI indicates that it's scanning this file, the working set memory for the scanner.exe task jumps to over a GB, and eventually dies on its own. This seems to be completely reproducible on my computer using the released version of 7.2.1. The upload speed of the connection is about 1 Mbps and the zip file is about 400 MB, so the download may take a little while. Let me know if you have any trouble getting a hold of the file.
Thanks Ken, I'll test it out today
*** Bug 10255 has been marked as a duplicate of this bug. ***
*** Bug 10304 has been marked as a duplicate of this bug. ***
I'm gonna take a look at this one as well. I will also investigate bug 4717 and bug 4691.
This issue is easily produced with the cue/flac that is provided in comment 11, thanks Ken. The odd thing is I have not been able to figure out what is special about this cue/flac combination other then the flac has "type: 5 (CUESHEET)" metadata at block #3. When I create a new cue/flac that has this same information the scanner does not have an issue with it. I must be missing something.
Fixed in change 24506. QA should add all of the following to the standard test plan: * FLAC with external cuesheet only. * FLAC with embedded cuesheet only. * FLAC with both external cuesheet and embedded cuesheet, with the external cuesheet alphabetically sorted before the FLAC file. *FLAC with both external cuesheet and embedded cuesheet, with the external cuesheet alphabetically sorted after the FLAC file. This bug occurred because the cue sheet was scanned before the FLAC, causing the FLAC file to be added to the database by the cue sheet code instead of the scanner code, and later scanned as a playlist instead of as a file. The original customer with the 10,000 Maniacs album should fix or remove the embedded cuesheet. Since it contains no artist/title information, the scanner ends up adding a No Artist entry. I'd suggest removing the embedded cuesheet, as you should not have both external and embedded cuesheets for the same file.
Verified to be fixed in 7.3.3 - 24684.
Fixed - Closed Message (SC) This bug has been fixed in the 7.3.3 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Correction: SqueezeCenter version is 7.3.2
Reduce number of active targets for SC