Bug 9638 - mov123 and wmadec transcoding broken with new streaming
: mov123 and wmadec transcoding broken with new streaming
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 7.3.0
: All All
: P1 critical (vote)
: 7.x
Assigned To: Alan Young
: MOV123, new_streaming
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-02 12:40 UTC by Bruno Liechti
Modified: 2009-09-08 09:24 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
sample m4a coded with Nero AAC (2.73 MB, audio/x-m4a)
2008-10-02 12:40 UTC, Bruno Liechti
Details
Server Log (108.56 KB, text/plain)
2008-10-03 15:19 UTC, James Richardson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Liechti 2008-10-02 12:40:33 UTC
Created attachment 4092 [details]
sample m4a coded with Nero AAC

Many of my CDs are coded with Nero AAC codec (version 1.1.34.2). SqueezeCenter 7.2.1 is the last version which is able to play these files. Version 7.3 looks like it is playing them but there is no sound out of the Duet Receiver. The Controller is showing the now playing screen and playback time is running.

This seems to be a cross-platform problem. In our network there is a PC with Windows XP SP3 and a PowerBook G4 with OS X and neither of them can play the files.

The file extension is *.m4a.
Comment 1 James Richardson 2008-10-03 15:08:52 UTC
Confirmed, SC 7.3 PC and MAC both fail to play the attached file.

Verified the latest QT installed on both systems.

see attached logs
Comment 2 James Richardson 2008-10-03 15:19:03 UTC
Created attachment 4106 [details]
Server Log
Comment 3 Spies Steven 2008-10-07 10:22:35 UTC
This looks like a file path issue with mov123 as a result of new streaming changes.

Alan, would this one be for you?
Comment 4 Alan Young 2008-10-08 06:57:10 UTC
(One way of looking at) the problem is that there is a deficiency in mov123 in that it does not know how to interpret "-" as a filename meaning standard input. I guess that this should not be too difficult to fix, for someone familiar with the code (Dean?), as it appears to be able to deal with the source being a remote stream.

The problem arises because, with new-streaming, all transcoding is handled via Pipeline, which passes the source stream to the transcoding pipeline on its standard input. The transcoding command no longer gets its hands on the actual input filename. I can see some arguments for changing this but the current transcoding configuration-management functionality does not really provide the necessary info to make the right decisions. Some generic redesign in this area could help in various ways.

Dean, can you look at mov123?
Comment 5 Blackketter Dean 2008-10-08 10:30:53 UTC
When you say "look at it" can you be more specific?  Is what we need some command line options to specify the input format?  That would be pretty straightforward.
Comment 6 Spies Steven 2008-10-08 11:48:07 UTC
wmadec like mov123 also appears to have the standard input limitation.

Perhaps the description of this bug should be updated to something like "mov123 and wmadec transcoding broken with new streaming."

I also wanted to mention that faad2 and mplayer might provide a transcoding solution for the limitations of wmadec and mov123.
Comment 7 Alan Young 2008-10-08 14:03:44 UTC
The current codes in mov123 is something like:

IF file-path looks like a remote URL
THEN
    use some code that knows how to open remote streams
ELSE
    use come code that knows how to open a local file
ENDIF

It needs an extra clause:

ELSIF file-path == "-"
THEN
    just use stdin
Comment 8 Patrick Ferdig 2008-10-16 07:14:37 UTC
FYI, faad and mplayer are broken in Linux as well.  I found a workaround in this post: http://forums.slimdevices.com/showthread.php?p=349044&highlight=faad#post349044

the $FILE$ param within the converter definition is being ignored.  fix is in Song.pm: (though now I see this only fixes faad)

my $filepath = '-';
if ($command =~ /faad/) { $filepath = $track->path; }
$command = Slim::Player::TranscodingHelper::tokenizeConvertCo mmand($command, $type, $filepath, $url, 0 , $maxRate, 1, $quality);
Comment 9 James Richardson 2008-10-27 10:51:42 UTC
*** Bug 9817 has been marked as a duplicate of this bug. ***
Comment 10 Alan Young 2008-10-29 23:06:49 UTC
Fixed with change 23721
Comment 11 Alan Young 2008-10-29 23:13:14 UTC
*** Bug 8858 has been marked as a duplicate of this bug. ***
Comment 12 Dave Nanian 2008-10-30 14:06:53 UTC
Checked this with last night's build, and while the AAC tracks are working, ALC don't seem to be...
Comment 13 Alan Young 2008-10-31 01:51:58 UTC
Alc would be bug 9794 but his should also be fixed.
Comment 14 Ross Levine 2008-12-10 16:54:22 UTC
Verified in 7.3 - 24723. 
Comment 15 James Richardson 2008-12-15 12:37:05 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 16 Chris Owens 2009-07-31 10:30:33 UTC
Reduce number of active targets for SC