Bugzilla – Bug 9394
SqueezeScrobbler not using Request::renderAsArray correctly
Last modified: 2008-09-09 09:25:54 UTC
I've updated to 7.2/trunk SVN 23036, and I see the following in the log: [16:56:20.1293] Slim::Control::Request::renderAsArray (2185) Error: request should set useIxHashes in Slim::Control::Request->new() [16:56:20.1298] Slim::Control::Request::renderAsArray (2185) Backtrace: frame 0: Slim::Utils::Log::logBacktrace (P:/Music/SlimServer/trunk/server/Slim/Control/Request.pm line 2185) frame 1: Slim::Control::Request::renderAsArray (Plugins/SqueezeScrobbler/Scrobbler.pm line 946) frame 2: Plugins::SqueezeScrobbler::Scrobbler::otherCommand (P:/Music/SlimServer/trunk/server/Slim/Control/Request.pm line 1996) frame 3: (eval) (P:/Music/SlimServer/trunk/server/Slim/Control/Request.pm line 1996) frame 4: Slim::Control::Request::notify (P:/Music/SlimServer/trunk/server/Slim/Control/Request.pm line 846) frame 5: Slim::Control::Request::checkNotifications (P:\Music\SlimServer\trunk\server\slimserver.pl line 510) frame 6: main::idle (P:\Music\SlimServer\trunk\server\slimserver.pl line 481) frame 7: main::main (P:\Music\SlimServer\trunk\server\slimserver.pl line 1043)
Philip: does this work with the Release version of 7.2?
I've never really had the release version of 7.2 installed, having moved from the private beta testing SVN branch to 7.2/trunk when it was released. I usually update SVN once a day, but I have been away the last 5 days. I think it was alright last friday.
very likely to change 23014
I meant to say: very likely due to change 23014
*** Bug 9402 has been marked as a duplicate of this bug. ***
(In reply to comment #5) Please note about <span class="bz_closed"><a href="show_bug.cgi?id=9402" title="RESOLVED DUPLICATE - Streaming does not work anymore!">Bug 9402</a></span>, that upgrading to squeezecenter 7.3~23045 does not help. Nor does removing the last.fm scrobbler. Still not able to play the stream remotely. However I cannot confirm that these log messages are related to that bug. Yes, I get those errors, but only after changing the loglevel after my problem started.
(In reply to comment #6) (Sorry about the code above. I just cannot use Bugzilla.)
going forward (7.2.1 -> 7.3) won't help you, but 7.2.0 should. The scrobbler was a red herring - sorry for the confusion. Are you on Windows XP too?
> Are you on Windows XP too? Nop, I'm running Ubuntu Linux.
Yes with the change to 7.2.x the caller needs to set a flag when it creates the request if it is going to call renderAsArray - in this case it means the SqueezeScrobber needs updating. This is really a warning, but I left it as an error message so plugin authors would see it - the issue is that the result of renderAsArray may be wrong. The reason for these changes are that they give a reasonable performance improvement to the normal use of the request mechanism, so it was worth making this change.
Please note, that I did not file this Bug 9394. I filed a Bug 9402, but it got resolved and marked duplicate to this where we are now. My problem still remains - streaming does not work - and it may not even have anything to do with this error message.
I see the same on SC 7.3/linux. I don't use the scrobbler plugin and the included one (to scrobble) is disabled. Fortunately everything else works fine so far - from my POV it's "just" an error message...
OK, what are the steps to reproduce the error?
Markus, can you post exactly what you see as if you don't have the Scrobbler plugin installed then the message should be different.
really easy on my side: just select "play", "add", "delete" on any album (in the webinterface, on the left side)... before it gets confusing (for me): i've not installed an external scrobbler plugin (there has been an external one, hasn't it?) BUT there is the included one in Slim/Plugins/Lastfm which lists as: Last.fm Audioscrobbler (v1.0) <- disabled Last.fm Radio (v1.0) <- enabled If everybody is talking about the included one, then it's installed but disabled in the plugins page. Finally the error message: [08-09-05 21:18:45.3798] Slim::Control::Request::renderAsArray (2182) Error: request should set useIxHashes in Slim::Control::Request->new() [08-09-05 21:18:45.3804] Slim::Control::Request::renderAsArray (2182) Backtrace: frame 0: Slim::Utils::Log::logBacktrace (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 2182) frame 1: Slim::Control::Request::renderAsArray (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 1926) frame 2: Slim::Control::Request::callback (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 1828) frame 3: Slim::Control::Request::executeDone (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 1816) frame 4: Slim::Control::Request::execute (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 864) frame 5: Slim::Control::Request::executeRequest (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Web/HTTP.pm line 974) frame 6: Slim::Web::HTTP::processURL (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Web/HTTP.pm line 789) frame 7: Slim::Web::HTTP::processHTTP (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Networking/IO/Select.pm line 248) frame 8: (eval) (/opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Networking/IO/Select.pm line 248) frame 9: Slim::Networking::IO::Select::select (/opt/squeezecenter/slimserver.pl line 531) frame 10: main::idle (/opt/squeezecenter/slimserver.pl line 481) frame 11: main::main (/opt/squeezecenter/slimserver.pl line 1043)
ah, just saw the difference in the logs myself (Slim::Web::HTTP)...
Ah - ok this probably cosmetic for you then, but we need to review whether to remove that bit of code. Andy - this is coming from the code saying: # This is a hack to make passing back of the "@p" array work. But limit it to # generateHTTPResponse, as Jonas Salling is the only caller. Andy - suggest we get rid of this now? Its not going to work with this new code unless we disable the optimisation just in case...
Oh yeah, I saw that nasty code, let's remove it. Especially since it's calling the slow Slim::Utils::PerlRunTime::realNameForCodeRef
Markus's case should be fixed by change 23055. This leaves the original bug which is an issue with SqueezeScrobbler and is probably not related to streaming in 7.3.
(In reply to comment #19) > Markus's case should be fixed by change 23055. thanks. no more error messages.
(In reply to comment #20) > (In reply to comment #19) > > Markus's case should be fixed by change 23055. > thanks. no more error messages. Yes, I also confirm. No more error messages. Remote streaming does not work either though. I have now tried with two different clients (XP+Winamp). With both the same bahaviour, clicking the play button in squeezecenter's album list on the left side does not populate the playlist on the right, thus no ear candy. What gives? From the logging settings I did set the player.streaming.remote -> Debug, but not still receiving any entries in the server log.
Sami - could I suggest you reopen the other bug for this as its more likely to be due to remote streaming in 7.3.
Done: Bug 9418
(In reply to comment #21) > (In reply to comment #20) > > (In reply to comment #19) > > > Markus's case should be fixed by change 23055. > > thanks. no more error messages. > > Yes, I also confirm. No more error messages. > Closing this bug per above comments.