Bug 9296 - SqueezeCenter doesn't error out if LAME is missing and Transcoding is Enabled
: SqueezeCenter doesn't error out if LAME is missing and Transcoding is Enabled
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 7.2.1
: PC Other
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-26 13:50 UTC by Matt Wise
Modified: 2009-07-31 10:28 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Wise 2008-08-26 13:50:22 UTC
Looks like SC is no longer telling a user when the LAME binary is missing but they've enabled any form of transcoding. When you set Bitrate Limiting on FLAC files and have LAME missing (OSX install, for example), it looks like its working ... but really is streaming full FLAC to your player.
Comment 1 KDF 2008-08-26 14:16:15 UTC
The fallback is as designed (can't recall the bug number). So lack of playback isn't a normal way to tell that LAME isn't involved.

Does the bitrate limiting setting no longer report that lame is missing?

File types settings should be automatically disabled if LAME isn't found.  Are the checkmarks showing up?  Trying to check an invalid option may not be reporting the full message (prefs errors aren't fully worded in some cases), but the checkmark should not be getting accepted.  

Otherwise, the only other place is in logging.
Comment 2 KDF 2008-08-26 14:19:31 UTC
for me: file types show as disabled, bitrate limiting reports that lame is missing.
Comment 3 Matt Wise 2008-08-26 14:20:39 UTC
I'm mainly concerned with the 'standard' Player page where you can enable Bitrate limiting. You flat out shouldn't be able to enable it if LAME is missing. If you DO enable it and LAME is missing, it needs to let the user know. 

The logs are very unclear as well ... a new user would not know that the limiting is failing because there is no error message. Instead there are indications of calling 'flc' with a maxrate of 128k (for example), with no indication that it failed.
Comment 4 KDF 2008-08-26 14:21:57 UTC
oh, and the old bug in question is bug 343 - If lame isn't found, streaming falls back to other supported formats.
Comment 5 Matt Wise 2008-08-26 14:22:30 UTC
I do see that it tells the user that lame is or isnt there ... but it does it in a very subtle way. It should not allow you to set the bitrate if the LAME encoder is missing. It's extremely easy for someone to glance over that and not read the Note at all. 
Comment 6 KDF 2008-08-26 15:00:00 UTC
Michael can probably grey out the option if lame isn't found.
Comment 7 Michael Herger 2008-08-26 19:48:56 UTC
Will do. Would have bet bitrate limiting was disabled without lame installed.
Comment 8 Michael Herger 2008-08-27 03:38:04 UTC
change 22919 - disable transcoding options if Lame is not installed
Comment 9 Spies Steven 2008-10-14 17:34:03 UTC
Verified with SqueezeCenter Version: 7.2.1 - 23502
Comment 10 James Richardson 2008-12-15 12:35:38 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Chris Owens 2009-07-31 10:28:18 UTC
Reduce number of active targets for SC