Bugzilla – Bug 343
songs requiring transcoding fail unless lame is installed
Last modified: 2009-09-08 09:21:43 UTC
For a Squeezebox that is rate limited (wireless Squeezeboxes, for example), songs requiring transcoding (wma, aac, ogg, etc.) fail to play if LAME is not installed. Rather than failing, we should fall back to streaming uncompressed PCM. Dean suggests that line 1060 of Source.pm should be: return 1 if !Slim::Utils::Misc::findbin('lame'); instead of: return undef if !Slim::Utils::Misc::findbin('lame'); Kevin, what do you think?
Marking this (using the Target Milestone field) as a 5.2 requirement.
returning 1 wouldn't be good, because other players (slimp3) would be returned ok if lame doesn't exist. What I need to do is check the logic again in getConvertCommand so that it allows the unlimited playback if underMax returns undef.
Created attachment 42 [details] checks formats and allows fallback if lame isn't found. I've tested with softsqueeze and triplefat and the server uses the correct fallback. Slimp3 should skip songs that MUST be translated to mp3 and will play mp3 at native bitrate. Squeezebox will play mp3 at native, and fallback to conversions to WAV/AIFF if found/enabled.
The patch works for me on wireless SQ and S3. In the future, we may want to have a query method for whether a player deals with uncompressed streams, rather than the formats[0] stuff that's there now. But let's go with what you have now.
*** Bug 358 has been marked as a duplicate of this bug. ***
Final fix checked in on 6/10/2004.
This Slimserver bug was fixed a very long time ago, and is now being marked as Closed. If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.
Routine bug db maintenance; removing old versions which cause confusion. I apologize for the inconvenience.