Bug 9291 - 22050 Sample Rate 56k cbr mp3 does not play correctly
: 22050 Sample Rate 56k cbr mp3 does not play correctly
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 7.2
: PC Debian Linux
: -- minor (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-26 08:42 UTC by Marc Auslander
Modified: 2009-07-31 10:28 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
22050 sample rate 56k CPR only plays about 18 seconds. (1.32 MB, audio/mpeg)
2008-09-22 11:39 UTC, Marc Auslander
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Auslander 2008-08-26 08:42:28 UTC
I have an MP3 clip with 22050 sample rate at 56k cbr.  I plays correctly under Winamp.  Both the receiver and SB3 play a bit of the clip and then skip to the next entry in the playlist.

Is this a known restriction or a bug.

I consider this minor since this is a funny mp3, made by accident.  My fix was to recreate it with sensible parameters.  However, others may need the space efficiency of this combination.

I will attach the clip if requested.
Comment 1 Joe Bowbeer 2008-09-19 12:17:09 UTC
I can play 22kHz MP3 (32kbps, 56kbps & 64kbps) on SC 7.2 on Windows, but the first few seconds are always skipped when I play them on Boom or SB3.  WMP and Quicktime have no problem with these same tracks.

22kHz is a reasonable setting for audio books.

(The clips above are each about 80 minutes long. An 8-hour clip won't play at all. See Bug 9515.)
Comment 2 Andy Grundman 2008-09-22 11:01:44 UTC
Please attach a file that fails to play.
Comment 3 Marc Auslander 2008-09-22 11:39:23 UTC
Created attachment 4041 [details]
22050 sample rate 56k CPR only plays about 18 seconds.

this may be more subtle than I thought, since I have one that fails, but I tried creating another 22k sample, 56k CBR and it plays correct.

I've attached the one that fails.
Comment 4 Andy Grundman 2008-09-22 12:58:31 UTC
This is probably an SC bug, we are detecting the offset value wrong.  Hacking the offset to 0 lets it play fine, so likely not a firmware issue.
Comment 5 Andy Grundman 2008-09-22 14:40:44 UTC
Fixed in 7.2.1 change 23238.  MPEG::Audio::Frame's CRC check is broken for this file.  CRC check in MP3 is silly anyway, so I've just disabled it here.
Comment 6 Marc Auslander 2008-09-22 15:26:43 UTC
I'm curious as to why CRC check is silly.  It's not for detecting damaged files, but doesn't help find a valid frame in a misaligned segment?

(Not that my alignment check code uses it - but I'm lazy and what I have is good enough).
Comment 7 Andy Grundman 2008-09-22 15:33:51 UTC
CRC check is still used in the decoder, it's just not necessary in MPEG::Audio::Frame.

It's silly because a file with an invalid CRC won't play at all, whereas without CRC one damaged frame is still a mostly-playable file.
Comment 8 Andy Grundman 2008-09-23 08:07:34 UTC
*** Bug 9515 has been marked as a duplicate of this bug. ***
Comment 9 Spies Steven 2008-10-14 17:56:46 UTC
Verified with SqueezeCenter Version: 7.2.1 - 23502
Comment 10 James Richardson 2008-12-15 12:35:34 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Chris Owens 2009-07-31 10:28:06 UTC
Reduce number of active targets for SC