Bugzilla – Bug 9184
Too easy to hit PLAY and clear the playlist. Add confirmation.
Last modified: 2009-07-31 10:27:24 UTC
If you've carefully built a playlist with the remote by hitting ADD, and then accidentally hit PLAY and lost your work, you've felt the pain of this bug. I propose that we do the following: If the user presses PLAY to play an item and the last modification to the playlist was by using ADD, pop up a confirmation screen that asks: Playing <itemname> Clear playlist and play now > Add to end of playlist > Play after current song > Selecting one of these and hitting RIGHT/GO or PLAY will confirm that choice. Hitting LEFT/BACK will back out. Given the limitation above (only after ADD), this won't affect radio stations or just playing a single item (song/artist/album/genre/etc...) Reactions?
Great idea. Maybe the first (easiest) selection should be 'Add to playlist', though. This seems somewhat related to having a "party mode" that's been requested for so long. Would this be a good time to also implement a switchable party mode where Play always means 'Add to end of playlist'? I would imagine the logic would fit in at the same points in the code.
Yeah, this idea came out of informal discussions about "party mode". I'd like to fix the basic UI problem, then think of party mode as a enhancement.
How would this feature interact with the "Play other options in album or directory" pref? For example, if I have a player set to "play other songs in album or directory" and I hit play on a track and select the sub-option to "play after current song", what will happen? Will all the rest of the songs in the album be added next or not? Either way, this may be confusing... For the record, I don't think I'd like this feature. If I select a track and press play, I'd like it to play without requiring additional button presses. At the very least, I disagree with Jim that the "default" should be changed to anything other than "play this track now".
(In reply to comment #3) > How would this feature interact with the "Play other options in album or > directory" pref? For example, if I have a player set to "play other songs in > album or directory" and I hit play on a track and select the sub-option to > "play after current song", what will happen? Will all the rest of the songs in > the album be added next or not? Either way, this may be confusing... What would be confusing, the submenu or the Play Next ability? They're two different issues. I don't see the problem. If "play other songs" is set, then Play Next should queue up all the rest of the album, the same if you did an Add. If you're thinking in terms of using this for a party, then you probably wouldn't want that option enabled during the party. > For the record, I don't think I'd like this feature. If I select a track and > press play, I'd like it to play without requiring additional button presses. > At the very least, I disagree with Jim that the "default" should be changed to > anything other than "play this track now". Have you thought about it? How often do you expect that you do an "add" and then "play"? For that 1/n'th of the time you do the submenu wouldn't be much of an inconvenience. The first selection in the list isn't a default in any way - it's just the selection requiring the fewest button presses. The reason I suggested it is that I can see that if this feature is implemented then very new users (guests at a party, for example) might use Play in place of Add all the time. Making 'Add to playlist' the first choice would make things simpler for them and less likely that they'll blow away the playlist.
(In reply to comment #4) > What would be confusing, the submenu or the Play Next ability? They're two > different issues. I don't see the problem. If "play other songs" is set, then > Play Next should queue up all the rest of the album, the same if you did an > Add. It's confusing because doing an "add" or "play next" via the + button does not honor this pref. It (correctly IMO) only adds the selected track. You're proposing to create an alternate way to do "add" or "play next" via the "play" button that does honor this pref.
If the user chooses to add or play next from this confirmation menu the behavior should be the same as if they had pressed that button.
(In reply to comment #6) > If the user chooses to add or play next from this confirmation menu the > behavior should be the same as if they had pressed that button. > And this is probably almost as confusing as Jim's way. In this case, I press play and am presented with 3 suboptions. One of them will honor that pref and the other two will not. This is what I meant in my original post when I said it's confusing "either way"...
The existing pref behavior is maintained and not changed. The only change is that in the event that the user has recently pressed ADD, we confirm a press of PLAY with the option to behave as if they pressed (or held) the ADD button instead.
An alternative (which does not address party mode), would be to keep the old playlist and implement an undo function which allows you to return to it. Reason for suggesting this is that it does not get in the way if you really do want to play the new track. Its also useful to have a quick listen to something before adding it to your playlist. I've not thought of the UI for the undo function though...
Re: Undo - See comment 7 in bug 3779 (https://bugs-archive.lyrion.org/show_bug.cgi?id=3779#c7) It's not really an undo mechanism, but it lets you go back and see what you lost and recover it.
party mode / playlist mode This would be yours to address Ben?
IMO, playlist mode (and the extended party mode) fix this issue acceptably. See bug 8878 and http://wiki.slimdevices.com/index.php/PlaylistModePartyMode FYI, playlist mode and party mode are supported as of last night (controllerUI only right now) Moving to closed/wontfix
Reduce number of active targets for SC