Bug 8845 - MMM doesn't generate mixes on Linux (UTF-8) where artist, album or track name has accented characters
: MMM doesn't generate mixes on Linux (UTF-8) where artist, album or track name...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: MusicIP
: 7.1
: PC Linux (other)
: -- normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-23 06:42 UTC by Markus Schiegl
Modified: 2011-03-16 04:39 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
alternative 1 - fix decoding for (utf-8) linux, too (731 bytes, patch)
2008-07-23 06:43 UTC, Markus Schiegl
Details | Diff
alternative 2 - fix decoding for (utf-8) linux, too (854 bytes, patch)
2008-07-23 06:43 UTC, Markus Schiegl
Details | Diff
track with album tag containing an accented character + MIP fingerprint (deleted)
2008-10-17 10:55 UTC, Markus Schiegl
Details
track with album tag containing an accented character + MIP fingerprint (4.85 MB, application/octet-stream)
2008-10-17 11:00 UTC, Markus Schiegl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schiegl 2008-07-23 06:42:33 UTC
+++ This bug was initially created as a clone of Bug #1938 +++

2nd run:

After having updated my linux box from 8859-15 to utf-8, i ran into this bug.
See forum: http://forums.slimdevices.com/showthread.php?p=321489

database is ok:

mysql> select url from tracks where id=4789;
+---------------------------------------------------------------------------------------+
| url                                                                          
        |
+---------------------------------------------------------------------------------------+
|
file:///data/common/All%20Music/S%C3%B6hne%20Mannheims/Noiz/11%20-%20Dein%20Leben.mp3
| 
+---------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

Decoding fails in the MusicIP-Plugin:

[08-07-21 23:24:12.4179] Slim::Plugin::MusicMagic::Plugin::getMix (754)
Creating mix for: song using: /data/common/All Music/Söhne Mannheims/Noiz/11
- Dein Leben.mp3 as seed.
[08-07-21 23:24:12.4184] Slim::Plugin::MusicMagic::Plugin::getMix (771) Request
http://localhost:10002/api/mix?song%3D%2Fdata%2Fcommon%2FAll%20Music%2FS%C3%83%C2%B6hne%20Mannheims%2FNoiz%2F11%20-%20Dein%20Leben.mp3&variety=1&rejectsize=10&mixgenre=0&style=135&sizetype=tracks&size=50
[08-07-21 23:24:12.4221] Slim::Plugin::MusicMagic::Plugin::getMix (780)
Warning: Couldn't get mix:
song%3D%2Fdata%2Fcommon%2FAll%20Music%2FS%C3%83%C2%B6hne%20Mannheims%2FNoiz%2F11%20-%20Dein%20Leben.mp3&variety=1&rejectsize=10&mixgenre=0&style=135&sizetype=tracks&size=50

both patches will do the same for linux what they are already doing for mac +
windows.
Comment 1 Markus Schiegl 2008-07-23 06:43:11 UTC
Created attachment 3657 [details]
alternative 1 - fix decoding for (utf-8) linux, too
Comment 2 Markus Schiegl 2008-07-23 06:43:36 UTC
Created attachment 3658 [details]
alternative 2 - fix decoding for (utf-8) linux, too
Comment 3 Markus Schiegl 2008-07-23 06:48:12 UTC
I have successfully tested both patches on my linux system.

As the world of encodings/escapings and charsets has many traps further tests - on other systems - are probably recommended.
Comment 4 Chris Owens 2008-07-28 09:19:33 UTC
Michael to review the patch and commit if it's ok, otherwise push off to 7.3
Comment 5 Michael Herger 2008-07-29 02:09:22 UTC
Easily reproducible on my system (eg. Züri West/Bümpliz - Casablanca/10 - Heiwäg.mp3 :-)).

Change 22187 - Don't encode to UTF-8 before escaping.

Thanks!
Comment 6 Ross Levine 2008-10-16 17:01:53 UTC
In trying to verify this I find that when I add an umlaut to a MM validated song, it is no longer validated and I cannot create a mix with it. Maybe someone can attach an UTF-8 validated track and help me out? :-)
Comment 7 Markus Schiegl 2008-10-17 11:00:19 UTC
Created attachment 4148 [details]
track with album tag containing an accented character + MIP fingerprint

Ross, enjoy the track :-)
MIP should be able to pick it up (it did on my system)

p.s. it's from http://www.jamendo.com.
Comment 8 Ross Levine 2008-10-17 14:41:24 UTC
Thank you Markus! MIP was indeed able to pick it up and it's mixable in SC, verified in 7.2.1 - 23353 with Ubuntu. Also thanks to MWise for your help. :-)
Comment 9 James Richardson 2008-12-15 12:34:22 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 10 Chris Owens 2009-07-31 10:25:12 UTC
Reduce number of active targets for SC