Bug 8725 - Fix 'Volume Control' in Boom to behave more like Transporter...
: Fix 'Volume Control' in Boom to behave more like Transporter...
Status: CLOSED FIXED
Product: SB Boom
Classification: Unclassified
Component: Audio
: unspecified
: PC Other
: -- normal (vote)
: 7.2
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-14 09:10 UTC by Matt Wise
Modified: 2008-12-15 12:39 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Wise 2008-07-14 09:10:31 UTC
Currently the Boom can easily flood the server with Volume commands by spinning the knob. This can cause timeouts and other strange behavior. Apparently we have some code in Transporter that we used to solve this same issue ... we should implement that in the Boom FW as well.
Comment 1 Chris Owens 2008-07-14 10:12:40 UTC
Maybe Sean knows in more detail what is magic about the Transporter that it doesn't show this issue.
Comment 2 Caleb Crome 2008-07-14 10:14:28 UTC
Richard knows about TP I think.  Adding him. 

Comment 3 Adrian Smith 2008-07-14 15:19:24 UTC
Is it the server or the tcp connection where the problem is occuring - i.e. is it due to lack of cpu in the server or network congestion?  Is this for SN or a local connection too?

Its most likely to be congestion for display messages to be sent to the player which backup when you spin the knob as each click of the knob creates a new screen update.

TP rate limiting is to send one report of knob position per round trip on the slimproto connection.  I am not sure this is possible with boom without implementing the TP knob protocol in boom as it would need to send position rather than left/right messages.  It may be possible to do something in the server to avoid generating a screen update for every click through.  Which input modes is this seen in most often?

If you reproduce the problem - can you see the slimproto queue length building up on the Health web page for that player?
Comment 4 Caleb Crome 2008-07-14 17:02:21 UTC
Boom, more than any other player needs local volume.   Sometimes when the network goes out, you need to hit pause, or stop, or volume down, or whatever....  But the only way to affect it is to unplug it.  Not very graceful.
Comment 5 Matt Wise 2008-07-14 19:30:12 UTC
Yeah, the problem this bug is meant to address is that exact scenario. I run into network hiccups quite a bit because I stream FLAC to the Boom and I'll see my volume, menu and other things slow down sometimes quite a bit. Its not that big of a deal with menu items, but not being able to lower the volume is quite an issue.

My ideal scenario would be that when you turn the knob its actually raising and lowering the DSP volume ... even though there still needs to be network traffic to adjust the screen image the volume can still be adjusted and the screen will catch up as bandwidth is available. 
Comment 6 Adrian Smith 2008-07-15 11:30:19 UTC
So do you see the control queue build up to boom when you do this?  If so then we can probably priorise packets sent from the server to the client over the slimproto connection.

See Help - Server and Network Health - Performance Monitoring - Player, does the graph for the control connection build up?
Comment 7 Adrian Smith 2008-07-15 14:36:55 UTC
I can't build up congestion in on the slimproto connection while playing flac and spinning the volume control - I assume you have a bandwidth limited connection Matt?

If you can't see anything on this health measurement, then it probably means we can do anything simple in the server (other than simple rate limiting of messages) and need to do something which includes something in the firmware.
Comment 8 Caleb Crome 2008-07-31 20:36:42 UTC
Felix, is this the bug that you already fixed with the packets? 
Comment 9 Caleb Crome 2008-07-31 20:38:02 UTC
Felix, is this the bug that you already fixed with the packets? 
Comment 10 Felix Mueller 2008-08-04 01:31:02 UTC
This is related to bug 8227 (fixed in fw 20), which throttles wheel events, which is the best we can do unless we implement local volume control.
Comment 11 Spies Steven 2008-08-29 15:10:36 UTC
Verified with SqueezeCenter Version: 7.2 - 22900
Comment 12 James Richardson 2008-12-15 12:39:24 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.