Bug 8555 - Time displayed on Now Playing screensaver (for Boom used as alarm/radio)
: Time displayed on Now Playing screensaver (for Boom used as alarm/radio)
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Windows XP
: P5 enhancement with 3 votes (vote)
: 7.x
Assigned To: Adrian Smith
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-24 11:23 UTC by Simon Turner
Modified: 2009-09-08 09:20 UTC (History)
7 users (show)

See Also:
Category: ---


Attachments
Demo of adding clock option to now playing overlay (2.10 KB, patch)
2008-07-28 15:05 UTC, Adrian Smith
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Turner 2008-06-24 11:23:37 UTC
I use Boom as alarm clock/radio/bedside hifi.
I use the deafult Now Playing screensaver setting. The screensaver does not display the time therefore when the screensaver fires up Boom ceases to be clock.

I use the two line display and would be glad if the time (pref in 24hr format, i.e 17:25) replaced the "Now Playing" text in the top lhs of the screen saver or was added to the top rhs.
Comment 1 Michael Herger 2008-06-24 13:48:49 UTC
Should we integrate MIS with SC 7.2? :-)

It might be worth a minore enhancement to the NP screensaver.
Comment 2 Michael Herger 2008-06-24 13:55:02 UTC
I meant changing the existing screensaver might be worth the effort (not integrating MIS)
Comment 3 Sue Chastain 2008-06-25 15:56:49 UTC
I voted on this even though I don't use Boom as a bedside clock radio. I use it near my pool and often have a need to check the time while out at the pool. Currently the only way to do that is hit hit power off/on in quick succession. 
Comment 4 Chris Owens 2008-07-14 10:25:26 UTC
cc'ing Dean as well.  This seems like a particularly good suggestion.
Comment 5 Simon Turner 2008-07-18 07:03:27 UTC
Another small addition....
When the alarm goes off the screen shows the time.. all the time... and doesn't seem to let the screensaver kick in. I often want to see what track is playing (as the alarm seems to want to wake me up with Random Mix). I'd be happy if the Now Playing screen saver was allowed to kick in once the alarm had gone off... *as long as it had been adapted to include the time* 
Comment 6 Mike Cappella 2008-07-18 13:58:20 UTC
Now Playing is pretty full. It seems like rather than changing the Now Playing screensaver, a new screen saver should be added that replaces one element with time and/or date.  Now Playing is useful as is for setups where one doesn't care about seeing the time during playing, but is interested in track info only.

MIS would be a very good addition, and seems to meet the needs well.

Another thought, and I have no clue how doable this is, but a screensaver that rotated through a list of screensavers might be workable as well.  The list could (optionally) restart at the beginning of each track, advance periodically to the next saver (the period being a preference):

1) Date and Time
2) Now Playing
   (list cycles)

or, cycling the list during track playback could be optional as well:

1) Now Playing
2) Date and Time
3) Now Playing
   (list does not cycle)
Comment 7 Simon Turner 2008-07-18 14:56:23 UTC
I don't know about your Now Playing screensaver but my two line display has a blank bit top right where time would easily fit. Alternatively dump the "Now Playing" text top left... it's pretty useless anyway.

Do not add MIS. If MIS is too complicated for me it will definitely be too complicated for virtually all later adopters of the system.

Auto-cycling through screensavers would irritate me no end. I do not want that much of animation/change on a screen two feet from me as I'm going to sleep/waking up.
Comment 8 Chris Owens 2008-07-21 10:57:22 UTC
Dean thinks we should have a now playing option that always displays the time somewhere on it.

However, we may not have time for it in the 7.2 release.
Comment 9 Simon Turner 2008-07-21 11:44:10 UTC
The feature is only important for Boom... without time on the screensaver it's frustrating to use it as an alarm clock.
Comment 10 Mark Miksis 2008-07-21 12:51:51 UTC
(In reply to comment #9)
> The feature is only important for Boom... without time on the screensaver it's
> frustrating to use it as an alarm clock.
> 

If this option were available, I'd probably use it on my SB2's as well.
Comment 11 Chris Owens 2008-07-28 11:09:40 UTC
triode, could we interest you in working on this? :)
Comment 12 Adrian Smith 2008-07-28 13:56:07 UTC
I think there are two high level options:

1) We add a new screensaver which allows more customisation of the now playing display, but leave the nowplaying display before the screensaver kicks in as now.  This would be exactly like MIS but perhaps with less options...

2) We add time to one of the possible options that can be displayed in the top right hand corner of the now playing display - both for screensaver and in playlist mode (only for the current song)

This second one could possibly be done so it can be selected from the web interface to add to the now playing options which you can cycle through.  This would mean that users would not see it unless they explicitly wanted to add it to the now playing options via the web interface.

For 7.2 I propose the second option - does this seem reasonable?

Longer term I would like to consider icon based now playing displays (bug 8868) and so this may give us more room to display other information such as this.
Comment 13 Adrian Smith 2008-07-28 15:05:40 UTC
Created attachment 3701 [details]
Demo of adding clock option to now playing overlay

Demo of the second option for boom only.  Does this meet requirements?

It makes an additional "Clock" option available in the drop down menu options for now playing on the player web settings screen.  Use this to add clock as one of the now playing options and then either select it here or via the setting menu.

Note this currently prefers the time format from the screensaver - is this the correct thing to do?
Comment 14 Chris Owens 2008-08-04 09:58:25 UTC
Dean have you had a look at Triode's patch?  Does it meet what you had in mind?  Should he commit it?
Comment 15 Blackketter Dean 2008-08-05 07:41:03 UTC
Patch looks reasonable to me, though if the user has to go find an advanced web setting to make it work, then its probably not really useful for 7.2.  

Can we add it to the default list?  Otherwise, let's punt to 7.3 and fix it with 8868/
Comment 16 Adrian Smith 2008-08-05 10:29:34 UTC
This would be no harder to find than buffer fullness - which the user needs to do this to see when the cycle through now playing options.

The reason for not adding it as a default would be that it would confuse used to the normal now playing.

Anyway it needs a new string so may be too late for 7.2 on this basis?
Comment 17 Simon Turner 2008-08-05 14:57:16 UTC
At the risk of adding bug spam... if one of the intended uses of the Boom is as an alarm clock/radio/bedside hifi it must be important that it displays the time after the alarm has gone off and the (most commonly used) Now Playing screen saver has kicked in. If 7.2 is the Boom release version then it'd seem strange that this clock feature wasn't included.
Comment 18 Blackketter Dean 2008-08-06 13:18:47 UTC
yes, we need another pass at the translations.  Michael:  We'll be able to do this for 7.2.1?
Comment 19 Michael Herger 2008-08-06 14:10:09 UTC
7.2.1 should be fine
Comment 20 Adrian Smith 2008-08-30 12:37:35 UTC
Do we want to include the patch as attached here for 7.2.1?  If so do we want it to be hidden initially (like the buffer fullness option)?
Comment 21 surly 2008-09-06 06:59:33 UTC
Hello I just made this comment in the Squeeze Forum:

"On the new Display when I choose now playing and elapsed Time as Screensaver I will get the Following message on the top row: "NOW PLAYING (xx of -01:45".
So the now playing info is overlayed by the time info, which isn't looking really nice.
The question is, why is the precious room on the Boom Display wasted with the Term "NOW PLAYING"?! I think it should at least be optionally possible to display just the time and for example a progress bar."

I think the upper Line should be customizable for whatever the user likes. The tracknumber info is O.K. if you have loads of room (which isn't there with the boom) and in times of downloadable content it's only used on some tracks anyway.

greetz surly
Comment 22 bwclark 2008-09-13 15:23:49 UTC

As a new Squeezebox Boom user, I mentioned this in the above link in the Slim Devices Community Forum.
http://forums.slimdevices.com/showpost.php?p=339986&postcount=1

It was mentioned that there is a bug comment section here, so I am reiterating what has already been said previously.

Since I do not use SC, I am interested in having this in the Boom firmware.

When can we expect this in the FW?
Comment 23 Blackketter Dean 2008-09-14 10:07:08 UTC
bwclark:  this is a server side enchancement, it would be fixed in SqueezeCenter and SqueezeNetwork.  No firmware changes necessary.
Comment 24 Adrian Smith 2008-09-14 13:32:34 UTC
Dean - do we want the patch above in 7.2.1?  If so do we make it like buffer fullness (hidden until you set from the web) or available by default?
Comment 25 Chris Owens 2008-09-16 14:46:17 UTC
Ping Dean.  Should this be 7.2.1 and available by default?
Comment 26 Blackketter Dean 2008-09-19 16:17:37 UTC
This keeps coming up.  Let's fix it in 7.2.1 and add it as one of the defaults.
Comment 27 Adrian Smith 2008-09-20 04:08:55 UTC
Added in 23227.
Comment 28 KDF 2008-09-21 08:07:31 UTC
I'm having an issue that appears to be due to this fix:

Slim::Control::Request::execute (1884) Error: While trying to run function coderef [Slim::Control::Queries::statusQuery]: [Can't call method "isa" on an undefined value at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.

This error repeats in the log and the clients never seem to recognise they have connected to squeezecenter.

It seems that, at least in my case, $client->display isn't defined. making this into $client->isa seems to work.
Comment 29 Adrian Smith 2008-09-21 11:45:48 UTC
What type of client are you seeing with no display class set?  Will fix but want to know what may be causing this (I can't reproduce)
Comment 30 KDF 2008-09-21 12:33:15 UTC
I have boom, sb3, sb2 and receiver clients.  I'm guessing the receiver maybe?  I'm having trouble trying to verify in the log as trying to dump client info inside prefs migration is easily causing a recursion loop.

I suspect this is what Fred is seeing in the thread he just started:
http://forums.slimdevices.com/showthread.php?t=52900
Comment 31 Adrian Smith 2008-09-21 12:35:35 UTC
Should be fixed by 23233, but all players should have a display class so I don't understand why the previous version didn't work.
Comment 32 KDF 2008-09-21 12:41:07 UTC
np, I saw the fix go in.  but, just to follow up and make sense of why, I'll keep trying to narrow down which client was the problem
Comment 33 KDF 2008-09-21 12:57:58 UTC
well, not sure what to make of it.  I added the following:
unless ($client->display) {warn ref $client};

I get a warning for all client types at this point (receiver, sb2, boom, transporter).  Otherwise, it apears fixed at change 23233

log:

[08-09-21 12:54:21.7613] Slim::Utils::Misc::msg (1125) Warning: [12:54:21.7608] Slim::Player::Squeezebox2 at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.
[08-09-21 12:54:21.7619] Slim::Utils::Misc::msg (1125) Warning: [12:54:21.7616] Use of uninitialized value in hash element at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Control/Request.pm line 993.
[08-09-21 12:54:21.8142] Slim::Utils::Misc::msg (1125) Warning: [12:54:21.8137] Slim::Player::Transporter at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.
[08-09-21 12:54:21.8149] Slim::Utils::Misc::msg (1125) Warning: [12:54:21.8146] Use of uninitialized value in hash element at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Control/Request.pm line 993.
[08-09-21 12:54:22.0204] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.0199] Slim::Player::Squeezebox2 at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.
[08-09-21 12:54:22.0210] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.0207] Use of uninitialized value in hash element at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Control/Request.pm line 993.
[08-09-21 12:54:22.0683] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.0680] Slim::Player::Boom at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.
[08-09-21 12:54:22.0689] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.0687] Use of uninitialized value in hash element at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Control/Request.pm line 993.
[08-09-21 12:54:22.1822] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.1817] Slim::Player::Receiver at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.
[08-09-21 12:54:22.1828] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.1825] Use of uninitialized value in hash element at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Control/Request.pm line 993.
[08-09-21 12:54:22.2236] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.2232] Slim::Player::Boom at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Utils/Prefs.pm line 490.
[08-09-21 12:54:22.2242] Slim::Utils::Misc::msg (1125) Warning: [12:54:22.2240] Use of uninitialized value in hash element at /usr/local/slimserver/svn/7.3/trunk/server/Slim/Control/Request.pm line 993.

Comment 34 Max Spicer 2008-09-22 09:06:02 UTC
Would it be possible to include the alarm indicator with this feature, displaying the bell symbol if there's an alarm in the next 24 hours?  This would fix bug 2118.
Comment 35 Ross Levine 2008-10-09 16:18:58 UTC
Verified in 7.2.1 - 23472. Alarm screen shows date and time and alarm indicator (bell). 
Comment 36 James Richardson 2008-12-15 12:35:20 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 37 Chris Owens 2009-07-31 10:23:16 UTC
Reduce number of active targets for SC