Bug 8426 - Controller Artist Search is restricted to whole-album Artists
: Controller Artist Search is restricted to whole-album Artists
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: P3 normal with 5 votes (vote)
: 7.3.3
Assigned To: Ross Levine
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-14 09:38 UTC by radish
Modified: 2009-06-17 09:35 UTC (History)
10 users (show)

See Also:
Category: ---


Attachments
one line patch that appears to fix the issue (441 bytes, patch)
2008-07-07 14:09 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description radish 2008-06-14 09:38:34 UTC
If you have "Group compilation albums together" selected on SC it seems that artists who are excluded from the Artist browse list (because they don't have an entire album of their own - they only appear on compilations) are also excluded from Artist search. This makes such artists virtually impossible to find unless you know which album they appear on.

This is unlike the Artist search on SC web interface and also on the SB3 interface - where Artist search matches against all Artists.
Comment 1 radish 2008-06-14 09:40:18 UTC
Should have mentioned, this is with SBC firmware r2507.
Comment 2 Michael Herger 2008-06-14 09:56:20 UTC
As this most probably is a SqueezeCenter problem - which version are you using?
Comment 3 radish 2008-06-14 13:12:11 UTC
Original bug was reported in this thread: http://forums.slimdevices.com/showthread.php?t=48603 which states 7.0.1. 

I'm running 7.2 and see it here too.
Comment 4 Gjxl 2008-06-25 07:33:13 UTC
I can confirm. Same bug here (SC 7.0.1). It is NOT dependent on the "Group compilation albums together" setting. I have it set to "List compilation albums under each artist".
Basically, tracks without an album tag do not show up when you browse by artist on the controller. They do show up in browser access to SC.
There are many other differences in behaviour between browsing on a browser, and browsing via the the SC (for which separate bugs have been entered I see), IMHO both should have the same behaviour.

And this bug is especially annoying, because there is no obvious way to browse towards songs that do not have an album tag set.
Comment 5 Ben Klaas 2008-07-07 14:09:28 UTC
Created attachment 3544 [details]
one line patch that appears to fix the issue

This is from the Schema area of the SC code, thus has implications beyond just jiveUI. I've reviewed playerUI and webUI and not found any place where things are not functioning correctly.
Comment 6 Ben Klaas 2008-07-07 14:10:59 UTC
I don't understand why the line that I removed in the attached patch was there at all though...assigning to Andy so another set of eyes can review. Andy, pass it back my way after you take a look.

also, FYI-- comment #4 on this bug is not the same issue. Closer to 8012, but probably a separate bug altogether.
Comment 7 Andy Grundman 2008-07-08 09:43:24 UTC
I'm OK removing that line, we'll have to keep an eye out for any bugs caused by it.
Comment 8 Ben Klaas 2008-07-08 09:58:41 UTC
patch applied in 7.1 21586

afaict, the patch hasn't affected playerUI or webUI behavior
Comment 9 Jim McAtee 2008-07-11 17:00:02 UTC
Yep, this change causes a bug in the VA behavior in the web ui.  VA track artists are listed in the artist listing although 'group artists' is set.  See bug 8708.
Comment 10 Andy Grundman 2008-07-11 17:50:20 UTC
OK I guess we know what that line was for.
Comment 11 Ben Klaas 2008-07-13 11:34:22 UTC
Unfortunately, the fix I checked in looks to have broken other areas of VA handling.

reverted change in 7.1 change 21709

Andy, I don't have a clue now how to fix this now. My feeling is that this gets punted to 7.2. Assigning to you/7.1. Re-target to 7.2 if you agree.
Comment 12 Johan Sombekke 2008-07-15 15:13:58 UTC
See this here too. I'm using SBC 7.1 build 21761 and controller build 2681. To avoid re-introducing #8711 :-) 
- artist search should search for artists in the artist list AND those on compilation albums
- the artist list should only contain artists with a solo album (in other words: exclude artists on compilation albums); this is working OK in 21761.

Ben / Andy, I'd suggest to target this one for 7.1, because it makes it really hard to find many artists / songs (in my case I cannot access about 210 of in total 575 artists through search). 

But let me underline that I really appreciate your hard work and the EXCELLENT way that this product is supported through Bugzilla and Forum!
Comment 13 Chris Owens 2008-07-24 10:34:39 UTC
Ben is the right thing to do with this retarget for 7.3 so that a fix will be more possible after the new schema work is in?
Comment 14 Johan Sombekke 2008-09-02 17:52:10 UTC
Hi all,

I hope this bug is indeed being solved in 7.3? Hope to hear from you soon...

Johan
Comment 15 Jim McAtee 2008-09-02 21:12:15 UTC
If this can be accomplished in the web ui with the current database schema, why can't it also be done through the Controller interface?
Comment 16 Johan Sombekke 2008-10-03 00:48:36 UTC
(In reply to comment #14)
> Hi all,
> I hope this bug is indeed being solved in 7.3? Hope to hear from you soon...
> Johan

Just to repeat my question and rise some attention to this -imho- important functionality: is this bug still targeted for 7.3?
Comment 17 Chris Owens 2008-10-03 14:23:26 UTC
It is indeed still targeted for 7.3
Comment 18 Johan Sombekke 2008-11-20 06:01:30 UTC
Hi Andy, Christopher

I noticed a slight change to target this for 7.3.1. When is this version to be released? I don't want to be impatient, but I feel this is taking too long. This bug was first raised in June (!) and then being postponed from 7.1 to 7.2 to 7.3 to 7.3.1 to ... Don't you feel we need to be able to search for all artists in the database with the Duet Controller instead of this being limited to artists with full albums only?

Kind regards,
Johan
Comment 19 Dennis Mutsaers 2008-12-09 12:43:54 UTC
Maybe contact Barry Gordon, the author of SlimPronto? The search function on his remote control application for the Philips TSU9600/SqueezeCenter does work as expected.
http://www.the-gordons.net/ 
Comment 20 James Richardson 2008-12-19 08:01:41 UTC
Changing target to next release
Comment 21 Dennis Mutsaers 2009-01-04 23:05:52 UTC
Any progress?
Comment 22 Dennis Mutsaers 2009-02-02 09:32:30 UTC
I don't see any improvements in 7.3.3
Comment 23 Chris Owens 2009-03-16 09:35:20 UTC
We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!
Comment 24 Dieter 2009-03-16 13:32:50 UTC
I also have the problem that artists who do not have their own complete album are not found in a search on the controller which is very annoying. 

This happens not only with compilation albums but also for artists which are "guests" on albums of another artist. I have for example an album of Tony Braxton comprising one song which is a duet with Baby Face. I don't want to see that album as compilation and have therefore tagged ALBUMARTIST=Tony Braxton, ARTIST=Tony Braxton for all except the duet and ARTIST=Tony Braxton & Baby Face for the duet (I have set & as separator). COMPILATION is not set for this album.

A search for Baby Face on the controller does not result in any match.

As already reported, for compilations this problem also occurs.

In my opinion this is really a very important bug since I have not chance to find songs of these kinds of artists with the controller. And I have a lot of these kinds of artists.
Comment 25 Chris Owens 2009-03-30 17:18:48 UTC
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.
Comment 26 Dennis Mutsaers 2009-03-30 22:47:13 UTC
I really feel this bug deserves more attention. The bug has been reported 9 months ago (!), and it's still not fixed. The controller search function is next to useless in the current status... And there are 3rd party remote control applications that do work, so we know it IS possible.
Comment 27 Dieter 2009-03-31 00:32:01 UTC
I also think that it is important that this bug is fixed as soon as possible. As mentioned, with this bug I have not chance to find any artist which has songs only on compilations using the controller. And in my opinion this can't be true.
Comment 28 James Richardson 2009-04-06 09:17:38 UTC
Ross: can you please test this with the latest 7.3.3 firmware r5149
Comment 29 Dieter 2009-04-06 15:23:13 UTC
Does not work for me with new firmware 7.3.3 r5149. 

Or do I have to restart SqueezeCenter and make a full scan to make it work?
Comment 30 Michael Herger 2009-04-06 21:48:34 UTC
change 25844 - use searchNames() instead of browse() method when searching for artists in the CLI

Please all test this build, not only for the search issue, but also whether you see any side-effects in other browse modes. Thanks!
Comment 31 Dieter 2009-04-07 15:29:03 UTC
It works!! Thanks a lot for resolving this issue, Michael!
Comment 32 James Richardson 2009-06-17 09:35:15 UTC
This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html 

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.