Bug 8411 - Apple Lossless file format no longer displayed
: Apple Lossless file format no longer displayed
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 7.0.1
: All All
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-13 12:12 UTC by Spies Steven
Modified: 2009-09-08 09:16 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
possible fix (1.61 KB, patch)
2008-06-16 16:21 UTC, KDF
Details | Diff
Very small Apple Lossless file for testing (3.85 KB, audio/x-m4a)
2008-07-30 08:48 UTC, Spies Steven
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Spies Steven 2008-06-13 12:12:09 UTC
I believe this is a localization issue.

Apple Lossless files fall into the "mov" file type category along with AAC and Movie Files.  I believe the File Format string for "mov" files used to be "Apple Lossless, AAC or Movie File" but now displays "Apple AAC or Movie File"  I think the word "Lossless," got dropped somewhere along the line.

Ultimately SqueezeCenter should differentiate between Apple Losless, AAC and other Movie files.
Comment 1 KDF 2008-06-13 15:04:14 UTC
content type ALC is apple lossless (as of change 9103)
content type MOV is for audio/x-quicktime-movie,audio/x-m4a.

Strings for MOV and ALC already reflect this.

Are you seeing evidence that the content type is not being set correctly?










Comment 2 Spies Steven 2008-06-13 17:19:46 UTC
(In reply to comment #1)
> 
> Are you seeing evidence that the content type is not being set correctly?
> 
What I am seeing is that ALAC files are in the SqueezeCenter database as content_type mov once they are scanned.  They play just fine through.
Comment 3 KDF 2008-06-13 20:29:57 UTC
I don't have any lossless files, so I have no experience.  
What file type shows in songinfo?
What command is executed on playback? (player.source=debug)
Comment 4 KDF 2008-06-14 01:14:46 UTC
it seems that alc type exists only at playback time.  From Player::TranscodingHelper::getConvertCommand():

	# Switch Apple Lossless files from a CT of 'mov' to 'alc' for
	# conversion purposes, so we can use 'alac' if it's available.
	# 
	# Bug: 2095
	if ($type eq 'mov' && blessed($track) && $track->lossless) {

		$log->debug("Track is alac - updating type!");

		$type = 'alc';
	}

Do we want songinfo to show alc type?  trackinfo, jive trackinfo, etc?
Or, mov type could go back to including lossless.
Comment 5 Spies Steven 2008-06-16 14:26:48 UTC
I wanted to mention related bug 8374 which turned out to be a dupe of bug 3174.

Adding Dean for comment.
Comment 6 Blackketter Dean 2008-06-16 15:11:14 UTC
I suspect that this detection should happen at scan time and not playback time, i.e. the scanner should detect that it's apple lossless and add it to the db as such.

It's not really a localization issue (i.e. different languages).
Comment 7 KDF 2008-06-16 16:21:01 UTC
Created attachment 3439 [details]
possible fix

I don't have any alc files to test with, but this seems to be the way to deal with the CT at scan time.  Initially, the suffix will tag it with mov type, but then scan should correct it to alc.  New and changed scans will have it as type alc, which is why I set to tagFormatClass to point alc to Formats::Movie as well.
Comment 8 Chris Owens 2008-06-19 09:32:24 UTC
Steven did you ever check KDF's patch?

If it works okay, please cc Michael (as main SC developer) and ask KDF to go ahead and commit it!
Comment 9 Chris Owens 2008-07-28 10:31:53 UTC
Steven to check this out when he gets back tomorrow.  If there are still issues, we should probably push this change off to 7.3
Comment 10 Spies Steven 2008-07-29 13:41:05 UTC
The possible fix provided by KDF seems to solve part of the problem.

With the fix applied I now see Apple Lossless files reported as "Apple Lossless" by SqueezeCenter after doing a rescan.  A minor issue is if I navigate to an Apple Lossless file that has been added to the library after the last scan using the music folder function SqueezeCenter will still display "Apple AAC or Movie File" until a newer scan has been performed.

I also wanted to note that I think the string "Apple AAC or Movie File" should be changed to "AAC or Movie File" once this is successfully implemented.  I still have not been able to figure out when the string changed from "Apple Lossless, AAC or Movie File" to "Apple AAC or Movie File"  Perhaps this should be filed as a separate bug?
Comment 11 Michael Herger 2008-07-30 07:46:36 UTC
change 22217 - checked kdf's patch in. Steven - could you please attach a small alac file to test the rescan issue?

Don't know about the string issue. IMHO it's correct, as ALAC has its own string. Doesn't need to be changed, does it?
Comment 12 Michael Herger 2008-07-30 07:49:49 UTC
Punting post 7.2 as I won't be able to fix this in time (if at all).
Comment 13 Michael Herger 2008-07-30 07:52:27 UTC
Oops, sorry, didn't want to punt this one. But as Steven said the main issue was fixed with this change this should be ok in 7.3. Ok?
Comment 14 Spies Steven 2008-07-30 08:48:35 UTC
Created attachment 3708 [details]
Very small Apple Lossless file for testing
Comment 15 Spies Steven 2008-07-30 08:58:52 UTC
(In reply to comment #11)
> Don't know about the string issue. IMHO it's correct, as ALAC has its own
> string. Doesn't need to be changed, does it?

Michael, IMHO the sting that should be changed is for the mov file type not the alc file type.  So if this change is implemented the string for mov should be "AAC or Movie File"  If this change is not implemented the string should be "Apple Lossless, AAC or Movie File"  The current sting "Apple AAC or Movie FIle" does not make sense since AAC files are not inherently Apple.

Noticing the string change for mov files is what prompted me to open this bug in the first place ;)
Comment 16 Michael Herger 2008-08-18 07:33:27 UTC
change 22736 - we have to update the local filetype cache, as the real format is only read after a first (inaccurate) estimation based on the file's extension
Comment 17 James Richardson 2008-12-15 12:04:59 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 18 Chris Owens 2009-07-31 10:22:44 UTC
Reduce number of active targets for SC