Bug 8246 - Different behaviour with browsing shortcuts in Music Folder
: Different behaviour with browsing shortcuts in Music Folder
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.0
: PC Windows XP
: P4 enhancement (vote)
: 7.4.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-27 14:53 UTC by Philip Meyer
Modified: 2009-10-05 14:30 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2008-05-27 14:53:36 UTC
I have noticed a difference with the way that Browse Music Folder is reporting shortcut names.

I'm sure it used to report the shortcut names, but it now seems to be reporting the destination folder name.

Eg. I have the following folder structure (-> represents a windows shortcut):

SqueezeCenter Music Folder = M:\Music\SlimServer\Music

M:\Music\Slimserver\Music\Podcasts\
  Alex's Podcasts -> M:\Music\iTunes\Alex\Podcasts
  Phil's Podcasts -> M:\Music\Podcast Enclosures

M:\Music\Podcast Enclosures\
  Coverville_[id_1391]
  Echoes_Podcast_[id_1591]
  Ultima_Thule_Ambient_Music_[id_1601]
  iTunes Podcasts -> M:\Music\iTunes\Phil\Podcasts

M:\Music\iTunes\Phil\Podcasts\
  The Times Sounds Podcast Enhanced
  U-Turn Cafe


I'm sure I used to be able to browse via: Home > Music Folder > Podcasts > iTunes Podcasts > U-Turn Cafe

However, as I now see the shortcut's destination folder, rather than the shortcut name, the way I browse is not the same as if I were to browse the folder structure in Windows Explorer.  Instead: "Home > Music Folder > Podcasts > Podcast Enclosures > Podcasts > U-Turn Cafe".
Comment 1 KDF 2008-05-27 16:07:53 UTC
see bug 4902
and bug 4940

change 11761
change 11799
change 11847
change 14531 
Comment 2 Philip Meyer 2008-05-27 16:36:53 UTC
I looked at those two bugs and they don't seem to be about the same issue.

Change revision 11761 has the following comment though:
- correctly display and follow Windows shortcuts pointing to another drive
- fix an issue with the BMF path display on the player

Is there any chance the shortcut name can be used in the BMF listings again?

My wife was especially distraught today when she couldn't find her podcasts.  She used to browse to her podcasts via BMF "Podcasts > Alex's Podcasts", which is a lot more meaningful for her than "Podcasts > Podcasts" (especially due to the other offerings within the second folder, as my Podcast shortcut destination folder is in there too).
Comment 3 Michael Herger 2008-05-27 21:09:39 UTC
Did this work as expected in 7.0?
Comment 4 Michael Herger 2008-05-28 01:43:40 UTC
The code looking up the shortcut's target url to be used instead of the real url has been in place since revision 5140 (very likely even longer, as that was a big mass change to the web interface code not related to this particular issue). Don't know what version this was, but I'd say it's been the way it is right now for ages.

Changing this to an enhancement request.
Comment 5 Philip Meyer 2008-05-29 14:01:52 UTC
It definitely used to work some time in the past by displaying the shortcut name, not the destination folder name, as that is why I created the shortcut names to be more meaningful and unambiguous.

I don't normally use Browse Music, but my wife uses it, and only recently noticed the difference. I'll try setting up a 7.0 play build.

Irrespective of how long it's been like this, I still think it's a bug, not enhancement request.

If displaying the actual destination folder in the breadcrumb trail, it should display all folders in the path (although prefer the way it used to work - displaying the shortcut name).

There could be several different shortcut names in one folder to different destination folders that have the same name.  eg:

My Music\
  Phil's Music -> M:\Music
  Alex's Music -> N:\Music

It used to display:

Home > Music Folder > My Music
  Phil's Music
  Alex's Music

but will now will display:

Home > Music Folder > My Music
  Music
  Music


For people who point a shortcut at Disk or partition, the destination label name isn't read; the item appears as the drive letter.
Comment 6 James Richardson 2008-06-02 10:42:05 UTC
QA to investigate
Comment 7 James Richardson 2008-06-20 15:31:42 UTC
*** Bug 8454 has been marked as a duplicate of this bug. ***
Comment 8 Michael Herger 2008-06-21 05:03:28 UTC
James - I don't see in which way this should be a duplicate of bug 8454. This bug is about how a shortcut is displayed. The other bug is about a shortcut not working. Or am I wrong?
Comment 9 James Richardson 2008-06-22 10:30:15 UTC
(In reply to comment #8)
> James - I don't see in which way this should be a duplicate of bug 8454. This
> bug is about how a shortcut is displayed. The other bug is about a shortcut not
> working. Or am I wrong?

I think they are related, but want to do more investigation into both bugs.
Comment 10 James Richardson 2008-08-06 13:40:13 UTC
This issues appears to have been addressed, as I don't have the issue any more.  If anyone else is able to reproduce, please reopen the bug.
Comment 11 Philip Meyer 2008-08-06 14:38:51 UTC
No, still broken.

I have a sub-folder within my SqueezeCenter music folder called "Podcasts".  Within that are two shortcuts:

Alex's Podcasts -> M:\Music\iTunes\Alex\Podcasts
Phil's Podcasts -> M:\Music\Podcast Enclosures

When I browse to this in SqueezeCenter (Home > Music Folder > Podcasts), I see:

  Podcasts
  Podcast Enclosures

instead of Alex's Podcasts and Phil's Podcasts.
Comment 12 James Richardson 2008-10-29 10:46:38 UTC
Philip thank you for the extra comments. verified this is still an issue with that setup.
Comment 13 Michael Herger 2008-12-12 01:17:18 UTC
Should be covered by the new scanner
Comment 14 Michael Herger 2009-01-14 08:07:12 UTC
change 24645 - display shortcut name instead of target file/folder name. Once inside the target item, the real name will be used again.

Eg. following "Shortcut to my favorite band - ever!" will end up in m:\ABBA, using "Music folder/ABBA" as crumblist.
Comment 15 James Richardson 2009-10-05 14:30:28 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.