Bugzilla – Bug 4902
BMF doesn't show shortcuts pointing to drive letters
Last modified: 2007-04-12 23:55:55 UTC
A user is reporting empty entries, when he's browsing music folders with shortcuts pointing to drive letters (http://forums.slimdevices.com/showthread.php?t=34380). Seems to be due to splitpath not returning any folder name, but drive letters/volumes not being displayed. The following patch could solve the issue: Index: D:/eclipse/slimpy65/Slim/Music/Info.pm =================================================================== --- D:/eclipse/slimpy65/Slim/Music/Info.pm (revision 11735) +++ D:/eclipse/slimpy65/Slim/Music/Info.pm (working copy) @@ -640,7 +640,7 @@ $j = Slim::Utils::Misc::pathFromFileURL($j); - if ($j) { + if ($j && (splitdir($j))[1]) { $j = (splitdir($j))[-1]; }
as noted elsewhere, seems to cause a hashref to be shown in the crumb list after descending to the outside volume. As there was no way to descned before, I'm not sure if the patch is the cause or not.
Created attachment 1898 [details] Patch displaying url instead of hash reference when there's no title This patch (6.5.x branch) should fix the issue where there was the hash reference displayed in the web interface instead of the folder name when following a shortcut. It additionally fixes a problem with the first line not correctly displaying the folder name in BMF.
(In reply to comment #1) > as noted elsewhere, seems to cause a hashref to be shown in the crumb list > after descending to the outside volume. As there was no way to descned before, > I'm not sure if the patch is the cause or not. For some reason there is no title set for drives. The latest patch is using the URL instead of the title if the latter is empty.
looks ok now.
Checked in in change 11760