Bug 8012 - Tracks/albums without artists don't show up in SBC list
: Tracks/albums without artists don't show up in SBC list
Status: NEW
Product: SqueezePlay
Classification: Unclassified
Component: Browser
: unspecified
: PC Fedora
: P2 normal with 1 vote (vote)
: 8.0.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-29 13:18 UTC by Eric Koldinger
Modified: 2009-10-09 13:25 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
mp3 file with artist tag removed and composer tag left intact (deleted)
2008-07-08 11:25 UTC, Ben Klaas
Details
mp3 file with artist tag removed and composer tag left intact (8.80 MB, application/octet-stream)
2008-07-08 11:28 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Koldinger 2008-04-29 13:18:08 UTC
I have a number of classical albums which are not tagged with an Artist, as they're primarily orchestral works. I have SqueezeCenter set to include Composer in the Artists list. These appear to not show up at all in either the the "artists" or "albums" menus.  The albums do appear in the main list on either an SB w/ display, or the web interface, with the composer listed under the artist.

I'm running SqueezeCenter 7.0, release version, on Linux. Haven't tried this on 7.1 yet.

Here's the tags from one of these tracks:
id3v2 tag info for 01.The_Chairman_Dances_(Foxtrot_for_Orchestra).mp3 :
TALB (Album/Movie/Show title): The Chairman Dances
TCOM (Composer): Adams, John
TCON (Content type): Classical (32)
TIT2 (Title/songname/content description): The Chairman Dances (Foxtrot for Orchestra)
TPE2 (Band/orchestra/accompaniment): San Francisco Symphony
TPE3 (Conductor/performer refinement): Edo de Waart
TPUB (Publisher): Elektra Nonesuch
TRCK (Track number/Position in set): 01
TXXX (User defined text information): (CDDB): 3c0c2b05
TYER (Year): 1987
Comment 1 James Richardson 2008-05-01 09:09:13 UTC
QA to investigate
Comment 2 Eric Koldinger 2008-05-05 00:37:43 UTC
Another interesting data point:
The composer Giovanni de Cascia showed up on the Artists menu on my SBC, but when I went through to list the albums, the list was empty.  Here's the tag:

TALB (Album/Movie/Show title): Early Music Festival
TCOM (Composer): Giovanni da Cascia
TCON (Content type): Classical/Medeival (255)
TIT2 (Title/songname/content description): Chon brachi assai
TPE2 (Band/orchestra/accompaniment): Early Music Consort of London
TPE3 (Conductor/performer refinement): David Munrow
TPOS (Part of a set): 1
TPUB (Publisher): London
TRCK (Track number/Position in set): 15
TXXX (User defined text information): (CDDB): f80bfe13
TYER (Year): 1969

Only track by this composer.  Again, no artist (TPE1), but composer, band, and conductor all set.

Comment 3 Spies Steven 2008-05-16 15:48:55 UTC
Eric, SqueezeCenter 7.0.1 has been released.  Please upgrade and report if you still see this issue, thanks.
Comment 4 Eric Koldinger 2008-05-16 22:27:55 UTC
Nope, still there in 7.0.1.
Comment 5 Ben Klaas 2008-06-13 08:30:21 UTC
assigning to myself, will attempt to fix for 7.1.

It'd be helpful for debugging if I could have a file attached to this bug that has these tagging properties.
Comment 6 Ben Klaas 2008-07-08 08:47:46 UTC
cc:ing Andy for some feedback

what I've found is that Slim::Control::Queries::albumsQuery has no code in it to honor the "include Composer, Band and/or Orchestra in Artists" user preference. Further, Slim::Schema::ResultSet::Album::browse also does not have any code for this.

I've been trying to model a fix on what's done in Slim::Schema::ResultSet::Contributor::browse --

----
my $roles = Slim::Schema->artistOnlyRoles;

# The user may not want to include all the composers / conductors
if ($roles) {
    # Bug 7992, Don't join on contributorAlbums if this is for a genre query
    if ( !exists $cond->{'genreTracks.genre'} ) {
         $cond->{'contributorAlbums.role'} = { 'in' => $roles };
    }
}
----

however, everything I've tried thus far has resulted in bad SQL. Any ideas on what's required here? Also, is this a fix that should be in the Schema area, or directly in Queries.pm?

The pref works fine when browsing album lists in playerUI...I'm a bit at a loss as to why though, since Album::browse isn't explicitly doing anything to include Composers, etc.


Comment 7 Andy Grundman 2008-07-08 10:50:37 UTC
Huh, the only place the composerInArtists pref is used in Slim::Web::Pages::Playlist, and even there it's not even used for anything!  Does this pref do anything?

Does anyone know of a bug with a sample set of tracks that can be used to reproduce this?
Comment 8 Ben Klaas 2008-07-08 11:28:43 UTC
Created attachment 3546 [details]
mp3 file with artist tag removed and composer tag left intact

another try at uploading
Comment 9 Ben Klaas 2008-07-09 10:49:37 UTC
many thanks to Andy for providing a patch for this.

fix is checked in 7.1 change 21615
Comment 10 Ben Klaas 2008-07-14 14:16:00 UTC
unfortunately, the fix for this bug caused numerous other issues (incomplete album list loading, bug 8717 and possibly 8711)

I reverted the fix in 21745

reopening bug
Comment 11 Ben Klaas 2008-07-14 14:18:01 UTC
Punt to you Andy...like the other VA bug, as in bug 8426, my recommendation is to punt on to 7.2 if you don't see an obvious fix
Comment 12 Mike Walsh 2008-12-22 20:24:34 UTC
i know its the SBC but seems related to me to bug 8380
Comment 13 Gareth Frankland 2009-07-21 20:09:49 UTC
Hi,

I am currently away on holiday and will return to the office on Monday 27th July. 

If you need to speak to someone, please call +44 845 862 8400.

YOUR EMAIL HAS NOT BEEN FORWARDED TO A COLLEGUE.  Should you require further assistance, please email sales@acdclighting.co.uk.

Many thanks,

Gareth Frankland
Managing Director
ACDC
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.
Comment 14 knarf 2009-10-09 13:25:43 UTC
I have almost the same problem as discussed here. There are two small differences:
1) I use FLAC files. ARTIST is in some files unused for the same reasons given by the OP.
2) Everything shows up correctly in SqueezeCenter (and now in SqueezeBoxServer 7.4.1). But lists are empty on the Controller if ARTIST is empty.