Bug 7997 - Songinfo screen for radio stations saves incorrect URL for favorite
: Songinfo screen for radio stations saves incorrect URL for favorite
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: -- normal (vote)
: 7.1
Assigned To: Ben Klaas
:
Depends on: 7520
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-28 06:40 UTC by Blackketter Dean
Modified: 2008-12-15 12:38 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2008-04-28 06:40:01 UTC
While playing a nice radio station last night, I couldn't find a way to add the station as a favorite. The Now Playing -> Song/Station Info screen was missing the ability to save it as a favorite.  (That exists on the SB player UI...)
Comment 1 Ben Klaas 2008-04-28 06:45:30 UTC

*** This bug has been marked as a duplicate of bug 7952 ***
Comment 2 Blackketter Dean 2008-04-28 14:56:29 UTC
Since 7952 doesn't fix the radio station problem, which is the case I saw, I'm reopening this bug.

Note that on the player UI, you can create a favorite easily from the currently playing radio station.
Comment 3 Ben Klaas 2008-04-29 07:17:03 UTC
hmmm...while I don't disagree that it would be nice to add a favorite radio station from any spot in any UI, I just investigated the player UI and it looks like an incorrect implementation.

If I browse Internet Radio->Staff Picks->Best of->Soma FM's Groove Salad, and then add a favorite, the URL that gets added is:
http://www.somafm.com/groovesalad.pls  

However, if I play the station and then via the Player UI go to Now Playing->Go Right to Add as Favorite, the URL that gets added is:
http://scfire-dll-aa01.stream.aol.com/stream/1018

which is the first URL that comes from the .pls above. That's not correct.

Further, there is no way of adding a currently playing radio station as a favorite from the WebUI. Michael probably came to the same conclusion that I did, which is that you shouldn't save underlying URLs from a playlist, because what you want is the abstracted playlist URL.

cc:ing Michael for comment.
Comment 4 Blackketter Dean 2008-04-29 07:47:03 UTC
The idea here is that the songinfo screen in the player/controller/web UI should all have the same controls and adding a favorite for the current station is an important feature.  

As far as the web UI goes, I do see a heart button on the songinfo screen for the station when I click on the title.  (I also see a heart above the title on the player pane, but I think that this is a bug related to hiding the Slacker controls, as it doesn't do anything.)  

Let's open a separate bug for possibly bad station URL being saved as a favorite instead of the canonical playlist URL.  Done bug 8008.

There was some discussion about hiding radio station playlists behind a single item in the UI.  This could probably be solved along with that.  Andy, was that on your list?


Comment 5 Andy Grundman 2008-04-29 07:53:22 UTC
Yes it's part of the work I am doing in the 7.1 remote-playlists branch.
Comment 6 Ben Klaas 2008-05-06 08:18:44 UTC
I removed the suppression of add-to-favorites for remote URLs. By doing this, bug 7520 is exposed. 

Changing bug summary to reflect the current nature of the bug.

Also, this should be targeted to 7.1
Comment 7 Ben Klaas 2008-05-21 07:41:43 UTC
Dean: this addresses one of the dings in that audioholics review. From reading that review, it sounded like they were keen enough on the product that they would want to hear about software fixes that applied to the issues they had...

With Andy's fix for remote-playlists, this is also now fixed.
Comment 8 James Richardson 2008-07-16 07:31:19 UTC
This appears to be addressed in 7.1-21761 / 7.1r2697, in that the controller UI has been modified.  It is now only able to add a Radio Stream to favorites, from that streams browse menu.  Using the controller, you can no longer add as a favorite from the now playing screen.

You can still add as a favorite from the Web UI, or by browsing to that streams starting point I.E. Internet Radio > RadioIO > 70's > Add to Favorites
Comment 9 James Richardson 2008-07-16 07:50:25 UTC
This appears to be addressed in:
SqueezeCenter 7.1-21761
Controller 7.1 r2697
Receiver r35
SB2/3 r100
Transporter r49

I have been streaming Rhapsody to 3 devices with no issues.  NOTE: Rhapsody currently limits 1 account to 3 device streams at 1 time.  I.E. if the customer adds a 4th device, then an error message will be displayed, telling the customer of the limitation.
Comment 10 Chris Owens 2008-07-30 15:29:13 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 James Richardson 2008-12-15 12:38:32 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.