Bugzilla – Bug 7952
Add/Delete favorites is broken in SC-Jive communication, 7.1 and up
Last modified: 2009-09-08 09:30:58 UTC
As best I can tell, add to favorites is missing. At least I can't find it in any of the now playing screens. This is true for mp3 tracks and for internet radio stations. In a possibly unrelated development, add to favorites in the web interface also does nothing. Add to favorites works via the SB3 remote. 7.1 - 19054
Confirm am seeing a similar thing. Add to favorites works for album, artist and genre but not for individuals songs. Following a recent update to 7.0.1 latest nightly, I managed to get favorites via the Controller back for a very short while, but it then disappeared. This is on XP. I can add songs to favorites via the web interface from the fishbone skin.
*** Bug 7997 has been marked as a duplicate of this bug. ***
this is mine to fix, a.s.a.p. Almost definitely a SC-side issue.
fixed in SC 7.0 trunk (7.0.1) change 19205. Please note that when in "Current Playlist" context, there is only an add-to-favorites link if it's a local track. This is a workaround for the fact that a radio stream in the current playlist will often have a URL for a specific IP rather than a e.g DNS .m3u URL. Radio streams can be added as favorites, but just not in that context. That's probably also a bug, but not this one.
still semi-broken. reopening. this will be a SqueezeCenter-only fix
7.0 trunk SC change 19325 should be the final fix here. Need to increment $idx for the "show artwork" menu item in the songinfo menu.
this was opened against the controller. it seems to have morphed into a Squeezecenter bug and got fixed in SC. But, as best as I can tell, as of R2416, the controller still doesn't offer add to favorites.
Just to be clear, this was never anything but a SqueezeCenter issue (which provides the data to populate these controller menus). Marc, please provide the SqueezeCenter version you are running against. This is the key point of data on this bug, not the version of Controller firmware. If you're not up to date with SC, please update, restart SC, and test again.
I'm running SqueezeCenter Version: 7.1 - 19327 @ Fri May 2 00:26:22 PDT 2008 - Debian - EN - iso-8859-1 with the contoller firmware 2416 from that nightly. First radio stations. I have a number in a playlist. On the SB3, if I navigate to one in the playlist, I'm offered "add to favorites" and it works. On the controller, there is no add to favorites. While playing such a favorite, on the SB3 I can delete it. Controller offers delete, but when I press it nothing happens, but a new favorite entry appears on the controller names function: 0x10ef40. Repeat tries make more such entries. They do not show up in the web interface and disappear on controller reboot. For mp3 tracks, navigated to via the music folder. Again, SB3 "works". On the controller, I get inconsistent behavior. Some tracks let me scroll down to an add to favorites entry. But using it does not add the track as a favorite. In others, the scroll wheel stops working, and I can only use the back button to get back. I never see the add to favorites. I see now that his may be a bug in the scroll, rather than a favorites bug - so if you want I'll open a different bug. It seems related to not having an ID3V2 -COMM field! (All this happens with 2291 firmware as well - I updated to see if it changed.)
okay, a lot going on here. let me take them one-by-one. > First radio stations. I have a number in a playlist. On the SB3, if I > navigate to one in the playlist, I'm offered "add to favorites" and it works. > On the controller, there is no add to favorites. Currently that is by (my) design, and it's actually IMO a bug on the SB3 side. The reason I say that is that internet radio stream URLs are typically playlist URLs (e.g., http://some.radiostation.com/listen.pls), but when you add-to-favorites on the SB3 with a radio stream in the current playlist, you get whatever "track" is playing from that URL (e.g., http://direct.ip.address/34525), which is NOT what you want saved to favorites. This particular issue is going to be worked out in 7.1 with a fix to bug#7520. >While playing such a favorite, on the SB3 I can delete it. Controller offers >delete, but when I press it nothing happens, but a new favorite entry appears >on the controller names function: 0x10ef40. Repeat tries make more such >entries. They do not show up in the web interface and disappear on controller >reboot. I reproduced this issue, but only in 7.1 (and above) SC. So...looks like it "got broke". I'm asking around to see if there were any changes to the favorites CLI code that would cause such a break. > In others, the scroll wheel stops working, and I can only use the back button > to get back. I never see the add to favorites. I see now that his may be a > bug in the scroll, rather than a favorites bug - so if you want I'll open a > different bug. It seems related to not having an ID3V2 -COMM field! Okay, I think I fixed that for good now-- on 7.1 you'll need to update your SC to at least revision 19353
Changing bug summary and target milestone to reflect remaining issue to be fixed
Michael, I've narrowed this problem down to the addition of icons to favorites. Will investigate further, but cc:ing you in case you know what's going on here... the icon field is showing up on Jive as a function pointer... 165237:86259 WARN (SlimBrowserApplet.lua:394) - url:db:album.titlesearch=10000 Hz Legend 165237:86259 WARN (SlimBrowserApplet.lua:394) - icon:function: 0x15e47eb0 error in event function: ...play/share/applets/SlimBrowser/SlimBrowserApplet.lua:395: attempt to concatenate local 'v' (a function value) stack traceback: ...play/share/applets/SlimBrowser/SlimBrowserApplet.lua:395: in function '_performJSONAction' ...play/share/applets/SlimBrowser/SlimBrowserApplet.lua:1306: in function <...play/share/applets/SlimBrowser/SlimBrowserApplet.lua:1134> (tail call): ? ...k/squeezeplay/src/squeezeplay/share/jive/ui/Menu.lua:115: in function '_itemListener' ...k/squeezeplay/src/squeezeplay/share/jive/ui/Menu.lua:152: in function <...k/squeezeplay/src/squeezeplay/share/jive/ui/Menu.lua:126> (tail call): ? ...squeezeplay/src/squeezeplay/share/jive/ui/Widget.lua:607: in function <...squeezeplay/src/squeezeplay/share/jive/ui/Widget.lua:583> [C 0x17157]: in function '_eventHandler' ...squeezeplay/src/squeezeplay/share/jive/ui/Window.lua:132: in function 'callback' ...squeezeplay/src/squeezeplay/share/jive/ui/Widget.lua:607: in function <...squeezeplay/src/squeezeplay/share/jive/ui/Widget.lua:583> [C 0x785d]: ? [C 0x6b0a]: in function 'processEvents' ...eezeplay/src/squeezeplay/share/jive/ui/Framework.lua:234: in function <...eezeplay/src/squeezeplay/share/jive/ui/Framework.lua:232>
fixed in SC 7.1 trunk change 19531 local music is not sending an icon param to jivefavorites cli command, which I believe to be correct. So, jivefavorites only adds the icon param that gets fed to favorites cli command if $icon exists (which it will for XMLBrowser content).
Marc, please retest with SqueezeCenter 7.1-21796. if you still see the error, then reopen the bug with added comments.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.