Bug 7507 - Latest beta builds fail to scan dirs/files with names contaning non-latin chars
: Latest beta builds fail to scan dirs/files with names contaning non-latin chars
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.0.1
: PC Debian Linux
: -- major (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-13 18:41 UTC by Nick Orlov
Modified: 2009-07-31 10:18 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Orlov 2008-03-13 18:41:25 UTC
For me it means that ~25% of my archive is not accessible anymore.
Last known to work build: 17830.

Note: seems like non-latin chars in tags are not an issue.
Comment 1 Nick Orlov 2008-03-13 19:05:21 UTC
Forgot to mention:

Debian/unstable, updated on daily basis.
System-wide locale set as

LANG=ru_RU.KOI8-R
LC_MESSAGES=C

====

SqueezeCenter Version: 7.0.1 - 17830 - Debian - EN - koi8-r
Perl Version: 5.8.8 i486-linux-gnu-thread-multi
MySQL Version: 5.0.51a-3

Platform Architecture: i686-linux

====



Comment 2 Michael Herger 2008-03-14 02:07:23 UTC
Ok, now we're seeing a pattern. This issue seems to be related to change 17864 - targetted at fixing bug 6621 :-/.

Could you please set logging for scan.* to debug, run a full scan and upload the scanner.log file to this bug? If you've got a large collection, try limiting the scan to some folder showing this issue.

Steinar - I'm CCing you, as you reported that issue in 6621 first. Could you please do the same? Thanks!
Comment 3 Michael Herger 2008-03-14 10:24:50 UTC
Can you confirm that those files are found if you run the scanner manually from the command line?

scanner.exe --wipe /path/to/your/music/files
Comment 4 Nick Orlov 2008-03-15 10:22:11 UTC
Michael,

I've sent logs you've requested over an e-mail.
Sorry for delay.

Thank you,
   Nick Orlov.
Comment 5 Michael Herger 2008-03-15 23:30:20 UTC
Thanks for the log - will take a look at it.

What about the manual scan I mentioned in my previous comment? Would it work for you?
Comment 6 Michael Herger 2008-03-16 00:17:57 UTC
*** Bug 7529 has been marked as a duplicate of this bug. ***
Comment 7 Michael Herger 2008-03-16 00:19:01 UTC
Patch to revert the change causing this issue:

Index: D:/eclipse/trunk/server/Slim/Utils/Prefs/Namespace.pm
===================================================================
--- D:/eclipse/trunk/server/Slim/Utils/Prefs/Namespace.pm	(revision 17894)
+++ D:/eclipse/trunk/server/Slim/Utils/Prefs/Namespace.pm	(working copy)
@@ -29,7 +29,7 @@
 use Slim::Utils::Prefs::Client;
 use Slim::Utils::Log;
 
-$YAML::Syck::ImplicitUnicode = 1;
+#$YAML::Syck::ImplicitUnicode = 1;
 
 my $log = logger('prefs');
 
Comment 8 Nick Orlov 2008-03-17 05:29:08 UTC
Confirmed that this patch fixes the issue for me.
Please let me know if you still want me to execute scanner manually.

Comment 9 Michael Herger 2008-03-17 05:36:19 UTC
Nick - that patch is reversal of a change we did to support non-latin characters in preferences (like player names etc.). It's not the solution we want, just a workaround for now.
Comment 10 Michael Herger 2008-03-17 06:57:46 UTC
change 17898 - this should solve your issue, without giving up non-latin characters in preferences. Please give it a try. Thanks!
Comment 11 Nick Orlov 2008-03-17 18:01:52 UTC
Confirmed: the latest patch on top of 17866 and 17897 works for me (tm)
Comment 12 Michael Herger 2008-03-18 00:53:03 UTC
Thanks for the confirmation. But you shouldn't need any additional patch to the latest trunk version.

Feel free to re-open if you still encounter this issue. Thanks.
Comment 13 Michael Herger 2008-03-25 03:57:13 UTC
change 17977 - adding a new class method to tag prefs which should not be utf8 encoded. 

Could you please verify this solution still works for you? It should basically do the same as the previous solution, but is much cleaner, prepared for other critical values, too. Thanks.
Comment 14 sbjaerum 2008-03-25 12:32:44 UTC
Works for me.
Comment 15 Michael Herger 2008-03-25 12:55:16 UTC
thanks!
Comment 16 Nick Orlov 2008-03-26 18:27:19 UTC
Works here too. Tested with r17981: I'm too lazy to use svn snapshots, I'm using deb packages from  http://debian.slimdevices.com

There is a small glitch though which does not seem to be caused by this specific commit: when one watches "Scan Details" while scan is in progress file/dirs containing non-latin characters are not being displayed correctly ... Does not cause any trouble afterwards (Location is being displayed correctly in track details). Some builds affected, some not.
Comment 17 Michael Herger 2008-03-27 01:02:43 UTC
> Works here too.

Great, thanks for the feedback!

> There is a small glitch though which does not seem to be caused by this
> specific commit: when one watches "Scan Details" while scan is in progress
> file/dirs containing non-latin characters are not being displayed correctly ...

That's bug 6689.
Comment 18 James Richardson 2008-05-09 14:54:36 UTC
(In reply to comment #16)
> Works here too. Tested with r17981: I'm too lazy to use svn snapshots, I'm
> using deb packages from  http://debian.slimdevices.com
> 
> There is a small glitch though which does not seem to be caused by this
> specific commit: when one watches "Scan Details" while scan is in progress
> file/dirs containing non-latin characters are not being displayed correctly ...
> Does not cause any trouble afterwards (Location is being displayed correctly in
> track details). Some builds affected, some not.
> 

Marking bug as closed.  If you see the issue reappear, please reopen the bug
Comment 19 Chris Owens 2009-07-31 10:18:03 UTC
Reduce number of active targets for SC