Bug 7174 - Clicking on the Delete Player hyper-link should prompt with a confirmation before deleting.
: Clicking on the Delete Player hyper-link should prompt with a confirmation be...
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Web UI
: unspecified
: PC Windows XP
: -- normal (vote)
: 7.0
Assigned To: Michael Herger
:
Depends on:
Blocks: 7173
  Show dependency treegraph
 
Reported: 2008-02-15 15:06 UTC by James Richardson
Modified: 2009-09-08 09:26 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
delete dialog (14.64 KB, image/jpeg)
2008-02-19 12:23 UTC, James Richardson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2008-02-15 15:06:09 UTC
Clicking on the Delete Player hyper-link should prompt with a Confirmation before deleting.  The current behavior is to delete the player, then display a confirmation box.  This is not a good customer experience.  Suggest we change this to a 2 step behavior, 1) display a confirmation box with Yes / No option 2) display the removed message.
Comment 1 Blackketter Dean 2008-02-16 12:24:36 UTC
Dialog box text:

Are you sure you want to delete <playername> from your SqueezeNetwork account?  You can add it back again later by reconnecting it to SqueezeNetwork using the remote.

Two choices:  Delete <playername>, Cancel

No need for a remove message, this should take you back to the list where it will be missing.
Comment 2 Andy Grundman 2008-02-18 12:04:35 UTC
Fixed in r2588.
Comment 3 James Richardson 2008-02-19 12:20:36 UTC
This is not working properly in SqueezeNetwork r2623/r17641

clicking on the delete button, nothing happens.  The player is not removed as expected.  There is a dialog box prompting me about the evils of removing the player, but not the way Dean describes it.

Also, no players are removed from SN.

This happens on connected & disconnected players.
Comment 4 James Richardson 2008-02-19 12:23:31 UTC
Created attachment 2929 [details]
delete dialog
Comment 5 James Richardson 2008-02-19 13:20:20 UTC
Verified fixed in SqueezeNetwork r2631/r17641, HW Beta
Comment 6 Andy Grundman 2008-02-20 11:15:01 UTC
Still broken.
Comment 7 Andy Grundman 2008-02-20 14:03:21 UTC
Might be fixed in r2673.
Comment 8 Andy Grundman 2008-02-20 20:23:42 UTC
Please retest.
Comment 9 James Richardson 2008-02-21 08:35:44 UTC
still broken in:
Apple Safari (PC) 3.x (BETA) * Dialog will appear, clicking OK does nothing.  Refreshing browser windows the receiver is still there
Opera 9.26 * Dialog will appear, clicking OK does nothing.  Refreshing browser windows the receiver is still there


Works in:
Mozilla Firefox 2.0.0.12 * had to close browser window, then re-launch to see change OR switch to a different page and back.  doing a "refresh" did not show the change, only switching off page and back showed change
I.E. 6.0.2900.2180  Did not need to refresh window 
Comment 10 Andy Grundman 2008-02-21 08:44:31 UTC
Argh, Michael can you look at this?  I have tried window.location, location.href, and document.location to redirect to the delete URL, none work.
Comment 11 Michael Herger 2008-02-21 08:57:23 UTC
Will take a look. IMHO the redirection is done correctly, but the handler fails.
Comment 12 Michael Herger 2008-02-21 09:06:56 UTC
The player seems to be removed but still displayed, despite the following code:

# tell viewPlayers to hide this player, since it won't be deleted immediately
$c->stash->{hidePlayer} = $player->id;

James - do you still see the players after a few minutes?
Comment 13 Andy Grundman 2008-02-23 05:53:30 UTC
Should be fixed in r2698/2699.  You can no longer delete a connected player, it must be disconnected first.
Comment 14 James Richardson 2008-02-26 11:23:39 UTC
Verified fixed in SqueezeNetwork r2738/r17710, HW Beta

Tested the 4 listed browsers in XP-SP2 & OSx 10.5