Bug 7121 - Syncing a Powered off player to a powered on player can cause music from "off" player
: Syncing a Powered off player to a powered on player can cause music from "off...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Sync
: 7.0
: Other Fedora
: -- normal (vote)
: 7.x
Assigned To: Alan Young
: new_streaming
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-13 09:44 UTC by Eric Koldinger
Modified: 2009-09-08 09:19 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Koldinger 2008-02-13 09:44:16 UTC
Doing the following:
            Slim::Player::Sync::sync($poweredOff, $poweredOn);
Where $poweredOff is a client in powered-off state and $poweredOn is a client in the powered-on state, and then starting music on $poweredOn can have music coming from the $poweredOff player, despite the fact that it is still in poweredOff state.

Found with the Synchronizer plugin for 7.0.
Comment 1 Blackketter Dean 2008-02-13 13:48:11 UTC
Eric: Is this possible to trigger from the regular UI, or is this an internal API bug?

Comment 2 Eric Koldinger 2008-02-13 13:56:14 UTC
Appears only to be an API issue.  I haven't seen it from the UI at all.
I've only been able to trigger it from my Synchronizer plugin.
Comment 3 Blackketter Dean 2008-02-13 13:58:00 UTC
Ok, cool.  Thx.  We'll take a look post 7.0.  Can you work around it for 7.0?

Assigning to Alan, the sync master!
Comment 4 Eric Koldinger 2008-02-13 14:21:09 UTC
Oh yeah.
Either you turn the player on (and off, if you want it to shut up) and you're sensible.
Or you listen to music as the clock shows.  I think you might get some occasional weird stuff on the display as the playback and the clock screensaver battle each other to decide what should be there.

Probably the only way somebody's going to hit this at all is if they're using my plugin.
Comment 5 Alan Young 2008-03-13 08:43:38 UTC
Actually it is not just an API issue. You can do it from Jive or the new WebUI.

So what should be the correct action: (a) sync-up but remain off and silent, (b) turn on?

BTW, (a) looks easy to implement.
Comment 6 Blackketter Dean 2008-03-14 07:12:03 UTC
Since on/off seems to be our shortcut for temporary unsyncing, we should probably pick A.


Comment 7 Alan Young 2008-03-16 04:21:33 UTC
Fixed in change 17897.

There are other issues related to sync-group-management and players which are off. See bug 7531.
Comment 8 Alan Young 2008-05-06 09:45:05 UTC
I have reverted (most of) the fix for this bug as it was causing too many other problems. Change 19481.
Comment 9 Alan Young 2008-06-04 13:12:56 UTC
Will not look at this until 7.2
Comment 10 Alan Young 2008-08-29 02:26:56 UTC
*** Bug 8422 has been marked as a duplicate of this bug. ***
Comment 11 Alan Young 2008-08-29 02:58:09 UTC
Fixed by new-streaming changes in 7.3
Comment 12 James Richardson 2008-11-21 21:07:25 UTC
Syncing a 'off' player with 7.3 - 23935 will now cause the sync group to stop playing if the master is streaming at the time of the sync.
Comment 13 Alan Young 2008-11-22 06:00:05 UTC
Please explain how you can recreate this problem. I cannot recreate it using either the Web-UI or the SBC-UI.
Comment 14 Eric Koldinger 2008-11-22 07:54:25 UTC
This was found using my plugin, The Synchronizer.
http://www.koldware.com/SlimStuff

Create a sync set.  Turn the master on and start it playing, and have the slave(s) be turned off.  Select the set and hit Synchronize.  Slaves remain in off state but start playing.

The affected API is no longer in 7.3.  I'll give this a try again, but it may no longer be an issue.
Comment 15 Chris Owens 2008-11-24 09:38:03 UTC
James to file his bug as a separate bug.
Comment 16 James Richardson 2008-12-15 12:04:30 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 17 Chris Owens 2009-07-31 10:17:08 UTC
Reduce number of active targets for SC