Bug 7531 - Sync/unsync operations sometimes need to consider players which are off
: Sync/unsync operations sometimes need to consider players which are off
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Sync
: 7.0
: PC Other
: -- normal (vote)
: 7.x
Assigned To: Alan Young
: new_streaming
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-16 04:19 UTC by Alan Young
Modified: 2009-07-31 10:18 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-03-16 04:19:39 UTC
The various UIs for controlling synchronization (membership of a sync-group), do not always consider players which are off in an appropriate fashion. For example, the SBC UI synchronization screen will show an empty checkbox for a player which is off and which is in the same sync-group as the controlled player. It would make more sense to show a checked checkbox in this case.
Comment 1 Max Spicer 2008-04-02 13:45:59 UTC
Slim::Player::Sync::isSyncedWith($client, $buddy) appears to return false if $buddy is off but is in the same sync group as client.  Is this the correct behaviour or is it the source of this bug?

If you then go on to try and sync client and buddy in this state, you get the following in the log:

[21:42:53.2094] Slim::Utils::Misc::msg (1310) Warning: [21:42:53.2083] Use of uninitialized value in numeric eq (==) at /usr/local/slimserver70/Slim/Player/Sync.pm line 235.
Comment 2 Alan Young 2008-06-04 13:19:29 UTC
*** Bug 1831 has been marked as a duplicate of this bug. ***
Comment 3 Alan Young 2008-08-29 02:58:20 UTC
Fixed by new-streaming changes in 7.3
Comment 4 James Richardson 2008-12-15 12:04:35 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 5 Chris Owens 2009-07-31 10:18:09 UTC
Reduce number of active targets for SC