Bugzilla – Bug 6889
songs request no longer working
Last modified: 2008-12-18 11:12:53 UTC
A request of somgs i j or titles i j where i and j are integers j>0 (e.g. songs 0 10) no longer returns any result just an echo of the sent command line
No problem here. Anything in the logs? In fact I very much doubt this is broken, as Jive wouldn't work without: songs 0 10 id%3A2749 title%3A05%20-%20Melt genre%3ARock artist%3ABozzio%20Levin%20Stevens album%3ASituation%20Dangerous duration%3A228 id%3A2898 title%3A1%2C000%20Oceans genre%3ARock artist%3ATori%20Amos album%3ATo%20Venus%20and%20Back%20-% 20orbiting duration%3A259 id%3A1 title%3A1.%20Nacht genre%3ASpeech artist%3A1001%20Nacht album%3ADie%20Geschichte%20von% 20K%C3%B6nig%20Schahriyar%20und%20Schahrasad%2C%20der%20Tochter%20des%20Wesirs%20(Disk%201) duration%3A339 id%3A12 title %3A1.%20Nacht genre%3ASpeech artist%3A1001%20Nacht album%3ADer%20Kaufmann%20und%20der%20Dschinni%20(Disk%202) duration%3 A482 id%3A10 title%3A10.%20Nacht genre%3ASpeech artist%3A1001%20Nacht album%3ADie%20Geschichte%20von%20K%C3%B6nig%20Scha hriyar%20und%20Schahrasad%2C%20der%20Tochter%20des%20Wesirs%20(Disk%201) duration%3A312 id%3A21 title%3A10.%20Nacht genr e%3ASpeech artist%3A1001%20Nacht album%3ADer%20Fischer%20und%20der%20Dschinni%20(Disk%203) duration%3A463 id%3A2326 titl e%3A1000%20Mirrors genre%3APop%2FRock artist%3ASin%C3%A9ad%20O'Connor%2C%20Asian%20Dub%20Foundation album%3ACollaboratio ns duration%3A294 id%3A11 title%3A11.%20Nacht genre%3ASpeech artist%3A1001%20Nacht album%3ADie%20Geschichte%20von%20K%C3 %B6nig%20Schahriyar%20und%20Schahrasad%2C%20der%20Tochter%20des%20Wesirs%20(Disk%201) duration%3A458 id%3A22 title%3A11. %20Nacht genre%3ASpeech artist%3A1001%20Nacht album%3ADer%20Fischer%20und%20der%20Dschinni%20(Disk%203) duration%3A482 i d%3A23 title%3A12.%20Nacht genre%3ASpeech artist%3A1001%20Nacht album%3ADer%20Fischer%20und%20der%20Dschinni%20(Disk%203 ) duration%3A337 count%3A3007
I am using the CLI interface, I didn't think that jive did. I have a PC based test program and I also have my client on the Pronto remote. They both fail on a songs request. i will try an older version of nightlies, and let you know. PS would you like the PC program?
I have telnet :-). Did you recently add some music? What do you get in server.log if you set control.command=debug and control.query=debug?
Yeah it's a request error, I have the same issue with 'songs 0 10': Slim::Control::Request::execute (1750) Error: While trying to run function coderef [Slim::Control::Queries::titlesQuery]: [Can't call method "string" on an undefined value at /home/slim/slimserver7/Slim/Player/Protocols/HTTP.pm line 443. ] I can take this one. Barry, if your log shows something different than mine, please let me know.
There are 2 issues here. 1. Remote tracks are not excluded from the titles, tracks, or songs queries. 2. Some Jive-related code expects a $client and this query does not require one. I don't believe the titles/tracks/songs queries are used by anything within SC, so I am not sure of their use case. Would you expect to have remote URLs returned in the list of songs? We could solve #2 by having $request->client return a random client if none was provided, but this would still fail if there were no players connected to the server.
Fixed in change 17062 by excluding remote tracks from the titles/songs/tracks queries.
For reference, other related bugs: bug 4571 bug 5104 bug 5100
Thanks guys I thought I was going crazy for a while.
I'm sorry Barry, didn't want to make you go crazy. But now I'm asking myself - why was I unable to reproduce this? Andy - what are you referring to with "remote tracks"? Radio stations? Whatever - thanks for fixing while I was sleeping :-).
Yeah, I guess some of the first 10 tracks in my database are remote, so they went through the getMetadataFor code which expects a $client.
At my stage in life going crazy is sometimes the only fun I have. In case you do not realize it, you guys are the best software product support team I have ever come across in almost 50 years of being in the digital world. The entire bugzilla process is world class and the individual responsiveness can not be believed. Keep it up!!!
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.